Show original path in trashbin #13954
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MorrisJobke
added
bug
2. developing
Member
Author
|
/backport to stable15 |
Member
|
@MorrisJobke check out my last commit. This fixes it I believe. |
Signed-off-by: Morris Jobke <[email protected]> Signed-off-by: Roeland Jago Douma <[email protected]>
MorrisJobke
force-pushed
the
bugfix/noid/show-original-location-in-trashbin
branch
from
325bb44 to
979cf79
Compare
Member
Author
|
Tested, works and looks good code wise 👍 |
MorrisJobke
added
3. to review
Member
Author
|
@rullzer mind to review after my rebase here? |
rullzer
approved these changes
Feb 5, 2019
|
backport to stable15 in #14026 |
Member
|
/backport to stable15 |
|
backport to stable15 in #14029 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regression from #11037
I managed to fetch the needed attribute and also set it to the
pathvariable, because it was not used before. Now I struggle with how to trigger or fill the tooltip.@skjnldsv @icewind1991 @juliushaertl Any idea?