Skip to content

Remove memory and upload PHP settings #13990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rcdailey wants to merge 1 commit into from
Closed

Remove memory and upload PHP settings #13990

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
wip: Remove memory and upload PHP settings 
Because memory & file size limitation settings are specified in the local configs, they override any
values in the global `php.ini` on the system. Because of this, it's impossible to, for example,
increase the memory limit of Nextcloud without touching its own configuration/source files.

These settings are removed in favor of the `php.ini` settings. The justification for not having
these settings specified strictly by Nextcloud is that they are variant. In other words, their
values are environment-dependent, and especially dependent on the content hosted by Nextcloud
itself. For example, hosting lots of images and thumbnails frequently causes memory issues.

Signed-off-by: Robert Dailey <[email protected]>
  • Loading branch information
@rcdailey
rcdailey committed Feb 16, 2019
commit a4ec27ca5ad57c4ec1a391c47e6bf3a1b958cbe2
6 changes: 0 additions & 6 deletions .htaccess
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,6 @@
</FilesMatch>
</IfModule>
<IfModule mod_php5.c>
php_value upload_max_filesize 511M
php_value post_max_size 511M
php_value memory_limit 512M
php_value mbstring.func_overload 0
php_value always_populate_raw_post_data -1
php_value default_charset 'UTF-8'
Expand All @@ -43,9 +40,6 @@
</IfModule>
</IfModule>
<IfModule mod_php7.c>
php_value upload_max_filesize 511M
php_value post_max_size 511M
php_value memory_limit 512M
php_value mbstring.func_overload 0
php_value default_charset 'UTF-8'
php_value output_buffering 0
Expand Down
3 changes: 0 additions & 3 deletions .user.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
upload_max_filesize=511M
post_max_size=511M
memory_limit=512M
mbstring.func_overload=0
always_populate_raw_post_data=-1
default_charset='UTF-8'
Expand Down