Fix expiration date changing for file shared by link

[adduxa]

Problem

Disabling expiration date for the link share leads to creation of a new link share.

Reason

Since 1bd6d39 setExpirationDate() accepts not only expireDate, but also shareId:

server/core/js/sharedialoglinkshareview.js

Line 625 in 1bd6d39

setExpirationDate: function(expireDate, shareId) {

It was applied at

server/core/js/sharedialoglinkshareview.js

Line 616 in 1bd6d39

self.setExpirationDate(expireDate, shareId);

but not at

server/core/js/sharedialoglinkshareview.js

Line 596 in 1bd6d39

this.setExpirationDate('');

So it ends up with creating a new link share, and not editing the existing one instead.

server/core/js/shareitemmodel.js

Line 149 in 1bd6d39

call = this.addShare(attributes, options);

Solution

Pass correct shareId to setExpirationDate()

[MorrisJobke]

Tested and works. 👍 I also checked in the compiled assets because that is what we are doing here. It's not obvious to new contributors, so don't worry. We are currently about to improve our on boarding here 😃

[MorrisJobke]

We also use "signed-off-by" messages inside the commit body to indicate that the developer certificate of origin is respected. You can read more about this in https://github.com/nextcloud/server/blob/master/.github/CONTRIBUTING.md#sign-your-work and what this means and how to apply it. Don't be scare it sounds more than it actually is.

And welcome aboard 🚀

[MorrisJobke]

/backport to stable15

[adduxa]

@MorrisJobke thanks for the clarification

[danxuliu]

Tested and works 👍

Nice explanation, thanks :-)

[danxuliu]

@MorrisJobke Wait for the "Signed-off-by"? Squash both commits? Merge as is?

[welcome]

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22
Most developers hang out on IRC. So join #nextcloud-dev on Freenode for a chat!

[backportbot-nextcloud]

The backport to stable15 failed. Please do this backport manually.

[MorrisJobke]

Backport is in #14212