Skip to content

Fix small glitches in update notification page #14177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
skjnldsv merged 2 commits into from
Feb 13, 2019
Merged

Fix small glitches in update notification page #14177

skjnldsv merged 2 commits into from
Feb 13, 2019

Conversation

@MorrisJobke
Copy link
Member

@MorrisJobke MorrisJobke commented Feb 13, 2019

  • fix border in update notification admin settings
  • fix warning for eol version in update notification admin settings

Before:

bildschirmfoto 2019-02-13 um 14 00 17
bildschirmfoto 2019-02-13 um 14 04 47

After:

bildschirmfoto 2019-02-13 um 14 00 31
bildschirmfoto 2019-02-13 um 14 04 15

@MorrisJobke MorrisJobke added the 3. to review Waiting for reviews label Feb 13, 2019
@MorrisJobke MorrisJobke added this to the Nextcloud 16 milestone Feb 13, 2019
@MorrisJobke
Copy link
Member Author

MorrisJobke commented Feb 13, 2019

The warning was back ported to stable15 and 14 - see #13664

@MorrisJobke
Copy link
Member Author

MorrisJobke commented Feb 13, 2019

/backport to stable15

@MorrisJobke
Copy link
Member Author

MorrisJobke commented Feb 13, 2019

/backport to stable14

ChristophWurst
ChristophWurst approved these changes Feb 13, 2019
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

skjnldsv
skjnldsv approved these changes Feb 13, 2019
View reviewed changes
Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! :)

@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Feb 13, 2019
@MorrisJobke MorrisJobke mentioned this pull request Feb 13, 2019
Merged
2 tasks
@skjnldsv skjnldsv merged commit cc69038 into master Feb 13, 2019
@skjnldsv skjnldsv deleted the bugfix/noid/fix-small-glitches branch February 13, 2019 13:51
@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented Feb 13, 2019

The backport to stable15 failed. Please do this backport manually.

@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented Feb 13, 2019

The backport to stable14 failed. Please do this backport manually.

This was referenced Feb 14, 2019
Merged
Merged
@MorrisJobke
Copy link
Member Author

MorrisJobke commented Feb 14, 2019

Backports are in #14205 and #14207

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@rullzer rullzer Awaiting requested review from rullzer

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

Assignees

No one assigned

Labels

4. to release Ready to be released and/or waiting for tests to finish

Projects

None yet

Milestone

Nextcloud 16

Development

Successfully merging this pull request may close these issues.

4 participants

@MorrisJobke @ChristophWurst @skjnldsv