Fix OC.getCurrentUser() on guest pages #14178
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@MorrisJobke is it too risky to backport this to stable15? |
rullzer
reviewed
Feb 19, 2019
Signed-off-by: Joas Schilling <[email protected]>
nickvergessen
force-pushed
the
bugfix/noid/get-current-user-for-guest-pages
branch
from
3633f9c to
08688af
Compare
Member
Should be fine IMO |
Member
|
/backport to stable15 |
skjnldsv
approved these changes
Feb 20, 2019
|
backport to stable15 in #14308 |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an inconsistency between the state an app can get in the UI and what all requests to the backend do.
See: nextcloud/spreed#1537
The signaling ticket contained the user, because the OCS request is authenticated, but the UI does not provide the user, so signaling continues without the user, and the signaling ticket is invalid on the external signaling server, because it is not for the current user.
As discussed @rullzer