Skip to content

Correctly determinate the owner in case of shared external storages #14194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MorrisJobke merged 1 commit into from
Feb 19, 2019
Merged

Correctly determinate the owner in case of shared external storages #14194

MorrisJobke merged 1 commit into from
Feb 19, 2019

Conversation

@nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Feb 14, 2019

Steps

  1. add an external storage
  2. created a file "shared.txt"
    i. user gets notified
  3. modified this file
    i. user gets notified
  4. shared it with another user (B)
    i. both users are getting notified
  5. user B modified this file
    i. only user B gets notified, not the creator

@nickvergessen nickvergessen added this to the Nextcloud 16 milestone Feb 14, 2019
@nickvergessen
Copy link
Member Author

nickvergessen commented Feb 14, 2019

/backport to stable15

@nickvergessen
Copy link
Member Author

nickvergessen commented Feb 14, 2019

/backport to stable14

rullzer
rullzer approved these changes Feb 14, 2019
View reviewed changes
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code makes sense.

MorrisJobke
MorrisJobke approved these changes Feb 14, 2019
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@MorrisJobke
Copy link
Member

MorrisJobke commented Feb 14, 2019

Failing tests:

There were 2 errors:
1) Test\Share20\ManagerTest::testGetAccessList
Error: Call to a member function getUID() on null

/drone/src/github.com/nextcloud/server/lib/private/Share20/Manager.php:1427
/drone/src/github.com/nextcloud/server/tests/lib/Share20/ManagerTest.php:3506

2) Test\Share20\ManagerTest::testGetAccessListWithCurrentAccess
Error: Call to a member function getUID() on null

/drone/src/github.com/nextcloud/server/lib/private/Share20/Manager.php:1427
/drone/src/github.com/nextcloud/server/tests/lib/Share20/ManagerTest.php:3624

@nickvergessen nickvergessen force-pushed the bugfix/noid/correctly-determinate-owner-in-case-of-shared-external-storages branch from 7705aee to f66c37b Compare February 18, 2019 09:57
@nickvergessen
Copy link
Member Author

nickvergessen commented Feb 18, 2019

fixed

@MorrisJobke MorrisJobke merged commit 30e7d3e into master Feb 19, 2019
@MorrisJobke MorrisJobke deleted the bugfix/noid/correctly-determinate-owner-in-case-of-shared-external-storages branch February 19, 2019 09:28
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Feb 19, 2019
Merged
@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented Feb 19, 2019

backport to stable15 in #14283

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Feb 19, 2019
Merged
@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented Feb 19, 2019

backport to stable14 in #14284

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzer rullzer rullzer approved these changes

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@icewind1991 icewind1991 Awaiting requested review from icewind1991

Assignees

No one assigned

Labels

3. to review Waiting for reviews feature: external storage feature: sharing

Projects

None yet

Milestone

Nextcloud 16

Development

Successfully merging this pull request may close these issues.

4 participants

@nickvergessen @MorrisJobke @rullzer