Remove trailing spaces from localized strings #14221
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Morris Jobke <[email protected]>
Member
Author
|
/backport to stable15 |
Member
Author
|
/backport to stable14 |
rullzer
approved these changes
Feb 15, 2019
nickvergessen
approved these changes
Feb 15, 2019
Member
nickvergessen
left a comment
nickvergessen
left a comment
There was a problem hiding this comment.
Can also remove the cast to string
Member
Author
I would do that in a followup PR to be able to not backport this then. |
|
backport to stable15 in #14225 |
|
backport to stable14 in #14226 |
Member
|
https://github.com/nextcloud/server/blob/stable12/lib/private/L10N/L10N.php#L85 It can be removed since 12 at least |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed this because some translations are missing the trailing space and thus the text is squeezed together.