Skip to content

style strong correctly as semibold #1423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jancborchardt wants to merge 1 commit into from
Closed

style strong correctly as semibold #1423

jancborchardt wants to merge 1 commit into from

Conversation

@jancborchardt
Copy link
Member

@jancborchardt jancborchardt commented Sep 15, 2016

Fixing nextcloud/mail#57 (comment), please review @skjnldsv @ChristophWurst

Also thoroughly check other aspects of Nextcloud @nextcloud/designers ;)

@jancborchardt jancborchardt added enhancement design Design, UI, UX, etc. labels Sep 15, 2016
@jancborchardt jancborchardt added this to the Nextcloud 11.0 milestone Sep 15, 2016
@jancborchardt jancborchardt mentioned this pull request Sep 15, 2016
Merged
@raghunayyar
Copy link
Member

raghunayyar commented Sep 17, 2016

Can you put this style along with the above elements like (p,a etc.)
This makes it easier to locate. Currently it is hidden in between ids and classes.
Works well otherwise.

@raghunayyar raghunayyar reopened this Sep 17, 2016
@raghunayyar
Copy link
Member

raghunayyar commented Sep 17, 2016

(Closed by mistake)

@raghunayyar raghunayyar added the 2. developing Work in progress label Sep 17, 2016
@jancborchardt
Copy link
Member Author

jancborchardt commented Sep 17, 2016

Where are the above elements like you mentioned? I of course also checked for that but they do not exist in their raw form. :)

@MorrisJobke
Copy link
Member

MorrisJobke commented Sep 17, 2016

Can you put this style along with the above elements like (p,a etc.)
This makes it easier to locate. Currently it is hidden in between ids and classes.
Works well otherwise.

Those are the reset styles. So grouping it there makes no sense.

👍 for this

@MorrisJobke MorrisJobke added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Sep 17, 2016
@jancborchardt
Copy link
Member Author

jancborchardt commented Sep 18, 2016

So apparently this is not needed after all because it works without it. Closing hence

@jancborchardt jancborchardt deleted the style-strong branch September 18, 2016 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MorrisJobke MorrisJobke MorrisJobke approved these changes

Assignees

No one assigned

Labels

3. to review Waiting for reviews design Design, UI, UX, etc. enhancement

Projects

None yet

Milestone

Nextcloud 11.0

Development

Successfully merging this pull request may close these issues.

4 participants

@jancborchardt @raghunayyar @MorrisJobke