Skip to content

Conversation

@rullzer
Copy link
Member

@rullzer rullzer commented Feb 15, 2019

Signed-off-by: Roeland Jago Douma [email protected]

@juliusknorr juliusknorr force-pushed the enh/updatenoticiation_to_single_webpack branch from 4abaca6 to 184bcac Compare February 16, 2019 14:09
@juliusknorr
Copy link
Member

@rullzer I've pushed better a fix for the hot reload issue, which causes differences in the bundled files. The actual issue is that webpack doesn't set the NODE_ENV variable when setting the mode to 'production' so vue-loader was still behaving as if it was in development mode. (https://github.com/webpack/webpack/issues/7074) Setting the environment variable as well seems to fix that: b6335e9

@skjnldsv
Copy link
Member

@juliushaertl does this impact the bundle size ? Shall we edit all of our configs?

@rullzer rullzer mentioned this pull request Feb 17, 2019
@rullzer
Copy link
Member Author

rullzer commented Feb 17, 2019

@juliushaertl nice catch. Lets fix this in a seperate PR so we keep it clean. See #14258

@juliusknorr
Copy link
Member

@juliushaertl does this impact the bundle size ? Shall we edit all of our configs?

I didn't found any huge difference, for the server bundles it was like <1kb less.

@rullzer rullzer force-pushed the enh/updatenoticiation_to_single_webpack branch from 184bcac to d6ba420 Compare February 18, 2019 12:23
@rullzer
Copy link
Member Author

rullzer commented Feb 18, 2019

Rebased. Ready to get in!

@juliusknorr juliusknorr added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Feb 19, 2019
@MorrisJobke MorrisJobke merged commit ef4e7d0 into master Feb 19, 2019
@MorrisJobke MorrisJobke deleted the enh/updatenoticiation_to_single_webpack branch February 19, 2019 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish enhancement javascript

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants