Skip to content

Add proper NODE_ENV #14258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rullzer merged 2 commits into from
Feb 18, 2019
Merged

Add proper NODE_ENV #14258

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
01b6f59
Move general webpack to NODE_ENV
juliusknorr Feb 16, 2019
ef272fe
Move settings to NODE_ENV
rullzer Feb 17, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Move general webpack to NODE_ENV 
Signed-off-by: Julius Härtl <[email protected]>
  • Loading branch information
@juliusknorr @rullzer
juliusknorr authored and rullzer committed Feb 18, 2019
commit 01b6f5928e76fd9c02af897b9b033638a6a87d07
6 changes: 3 additions & 3 deletions apps/oauth2/js/oauth2.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion apps/oauth2/js/oauth2.js.map
View file
Open in desktop

Large diffs are not rendered by default.

5 changes: 1 addition & 4 deletions apps/oauth2/webpack.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,7 @@ module.exports = {
rules: [
{
test: /\.vue$/,
loader: 'vue-loader',
options: {
hotReload: false
}
loader: 'vue-loader'
},
{
test: /\.css$/,
Expand Down
6 changes: 3 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,9 @@
"test": "tests"
},
"scripts": {
"build": "webpack --progress --hide-modules --config webpack.prod.js",
"dev": "webpack --progress --watch --config webpack.dev.js",
"watch": "webpack --progress --watch --config webpack.dev.js"
"build": "NODE_ENV=production webpack --progress --hide-modules --config webpack.prod.js",
"dev": "NODE_ENV=development webpack --progress --watch --config webpack.dev.js",
"watch": "NODE_ENV=development webpack --progress --watch --config webpack.dev.js"
},
"repository": {
"type": "git",
Expand Down