Skip to content

Bugfix/2 fa settings icons invert in dark themes #13643 #14262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Maders wants to merge 2 commits into from
Closed

Bugfix/2 fa settings icons invert in dark themes #13643 #14262

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
558c724
change img to div with css icon
Maders Feb 17, 2019
06440b8
add inline display for 2fa icons
Maders Feb 17, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions settings/css/settings.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -520,6 +520,7 @@ table.nostyle {
width: 16px;
height: 16px;
vertical-align: sub;
display: inline-block;
}
}

Expand Down
6 changes: 3 additions & 3 deletions settings/templates/settings/personal/security.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,15 +76,15 @@
/** @var \OCP\Authentication\TwoFactorAuth\IProvidesPersonalSettings $provider */
$provider = $data['provider'];
if ($provider instanceof \OCP\Authentication\TwoFactorAuth\IProvidesIcons) {
$icon = $provider->getDarkIcon();
$icon = sprintf('icon-twofactor_%s', $provider->getId());
} else {
$icon = image_path('core', 'actions/password.svg');
$icon = 'icon-password';
}
/** @var \OCP\Authentication\TwoFactorAuth\IPersonalProviderSettings $settings */
$settings = $data['settings'];
?>
<h3>
<img class="two-factor-provider-settings-icon" src="<?php p($icon) ?>" alt="">
<div class="two-factor-provider-settings-icon <?php p($icon) ?>"></div>
<?php p($provider->getDisplayName()) ?>
</h3>
<?php print_unescaped($settings->getBody()->fetchPage()) ?>
Expand Down