Skip to content

Conversation

@DominikWA
Copy link
Member

@DominikWA DominikWA commented Feb 21, 2019

Close #14374

Hello everybody,

I have change the referrer policy in the .htaccess file in the nextcloud root. I noticed that the setting does not work because there are still meta tags that manipulate the referrer policy.

In this PR I want to remove the unnecessary meta tags from the layout files so changes at the .htaccess referrer policy will work.

Best,
Dominik

@kesselb kesselb changed the base branch from stable15 to master February 25, 2019 16:11
@kesselb kesselb changed the base branch from master to stable15 February 25, 2019 16:11
@kesselb
Copy link
Contributor

kesselb commented Feb 25, 2019

Could you rebase your branch to master and change target? Backportbot will do the backport if possible. Workflow is usually pr against master and backport to stableX

@kesselb kesselb added 3. to review Waiting for reviews 2. developing Work in progress bug backport-request and removed 3. to review Waiting for reviews labels Feb 25, 2019
@kesselb
Copy link
Contributor

kesselb commented Feb 25, 2019

First-time contributor

🎉 Thank you for your contribution!

@DominikWA DominikWA changed the base branch from stable15 to master February 26, 2019 12:29
Signed-off-by: Dominik Wasielewski <[email protected]>
@DominikWA DominikWA force-pushed the RemoveUnnecessaryMetaTags branch from 4f82f8c to 782e828 Compare February 26, 2019 12:45
@DominikWA DominikWA changed the title [stable15] Fix referrer policy meta tags. Fix referrer policy meta tags. Feb 26, 2019
@DominikWA
Copy link
Member Author

DominikWA commented Feb 26, 2019

I have redone my changes based on current master and changed the target to master.

Best,
Dominik

@kesselb kesselb added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Feb 26, 2019
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with that 👍

@MorrisJobke
Copy link
Member

@DominikWA
Copy link
Member Author

What about this?

https://github.com/nextcloud/server/blob/master/core/templates/layout.public.php#L12

I have also removed this tag, I believe that this is totally unnecessary since there is no referrer-policy Never.
See: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Referrer-Policy

@juliusknorr juliusknorr added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Feb 26, 2019
@rullzer rullzer merged commit c2da3bf into nextcloud:master Feb 26, 2019
@welcome
Copy link

welcome bot commented Feb 26, 2019

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22
Most developers hang out on IRC. So join #nextcloud-dev on Freenode for a chat!

@MorrisJobke
Copy link
Member

/backport to stable15

@backportbot-nextcloud
Copy link

backport to stable15 in #14438

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants