Fix unsafe array access #14332
Merged
Fix unsafe array access #14332
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickvergessen
approved these changes
Feb 22, 2019
nickvergessen
requested changes
Feb 22, 2019
Member
|
Can easily reproduce, just run |
Signed-off-by: Daniel Kesselberg <[email protected]>
kesselb
force-pushed
the
bugfix/13098-unsafe-array-access
branch
from
c25b99f to
268c0d9
Compare
Contributor
Author
👍 can reproduce now. admin_audit was broken somehow. your suggestion make sense. no need to log occ without arguments. |
nickvergessen
approved these changes
Feb 22, 2019
Member
|
/backport to stable15 |
rullzer
approved these changes
Feb 22, 2019
|
backport to stable15 in #14340 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #13098
I see this on my instance but cannot reproduce 🙈