Parse multiple navigation items #14343
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Kesselberg <[email protected]>
kesselb
force-pushed
the
bugfix/14052-multiple-navigation-items
branch
from
f8a7b91 to
36c51bc
Compare
Member
|
We could fallback to |
Contributor
Author
Don't have a strong opinion on that. Do you think someone would bind application logic to an navigation item and use
Not nice but backwards compatible 🙈
PHP7+ looks a bit nicer 🤣 |
Member
|
Good news, master is 7.1+ Well I think at least items should have a unique ID. |
Signed-off-by: Daniel Kesselberg <[email protected]>
Signed-off-by: Daniel Kesselberg <[email protected]>
MorrisJobke
approved these changes
Feb 27, 2019
Member
MorrisJobke
left a comment
MorrisJobke
left a comment
There was a problem hiding this comment.
Code looks good, tested and works 👍
juliusknorr
approved these changes
Feb 27, 2019
Member
|
Failures unrelated. |
juliusknorr
added
4. to release
Member
|
/backport to stable15 |
Member
|
/backport to stable14 |
|
backport to stable15 in #14416 |
|
backport to stable14 in #14417 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #14052
Test
Pick any app with
<navigations>ininfo.xml(e.g. activity) and add a second<navigation>item.Expected
Two navigation items for this app
Actual
No navigation entry for this app
Known limitationIfidis not defined for navigation app name is used as fallback. At least one navigation item needs the id element with a value not equal to app name.