Skip to content

[stable15] Parse multiple navigation items #14416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MorrisJobke merged 3 commits into from
Mar 6, 2019
Merged

[stable15] Parse multiple navigation items #14416

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ee9eba5
Parse multiple navigation items
kesselb Feb 22, 2019
f32fd97
Generate id for navigation item
kesselb Feb 25, 2019
8240309
two item => two items
kesselb Feb 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
two item => two items 
Signed-off-by: Daniel Kesselberg <[email protected]>
  • Loading branch information
@kesselb
kesselb authored and Backportbot committed Feb 27, 2019
commit 8240309f0864e880a036b1f3afd1cda32b88b107
0 tests/data/app/navigation-two-item.json → tests/data/app/navigation-two-items.json
View file
Open in desktop
File renamed without changes.
0 tests/data/app/navigation-two-item.xml → tests/data/app/navigation-two-items.xml
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion tests/lib/App/InfoParserTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ public function providesInfoXml(): array {
['expected-info.json', 'valid-info.xml'],
[null, 'invalid-info.xml'],
['navigation-one-item.json', 'navigation-one-item.xml'],
['navigation-two-item.json', 'navigation-two-item.xml'],
['navigation-two-items.json', 'navigation-two-items.xml'],
];
}
}