-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Run tests that fail with "no such process" over to apache server #14440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run tests that fail with "no such process" over to apache server #14440
Conversation
48b6b87 to
3f2bb3c
Compare
Signed-off-by: Morris Jobke <[email protected]>
|
Different errors now, but at least the others are gone. |
danxuliu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hopefully this solves most of the problems we see.
I do not think so :-(
Although this will solve the No such process failures in those tests (by the way, how did you get the affected tests? Grepping No such process in the logs or just manually looking at the results? I ask because I have not seen the No such process failure in some of these tests for quite a while) as far as I can tell those are not the most common failures. That doubtful honour goes to some race conditions in the Comments app and the Files app, as well as some failures due to wrong wait conditions used in users tests.
Anyway, this is going to be an improvement nevertheless, so 👍 (although I am a bit concerned about increasing the load of Drone, but I guess that at some point we will be able to get more nodes ;-) ).
That should not happen :-/
This looks like one of the wrong wait conditions I mentioned above (basically, not giving enough time to find the element). |
I wrote a script that extracts the logs and shows the output of the failed ones. The "no such process" was the highest ranking one. Those are the errors of the two runs of this PR: Status of 16577: failure
Show full log
Show full log
Show full logStatus of 16576: failure
Show full log
Show full log
Show full log |
While talking about it - there it is - the "no such process" - in #14398: https://drone.nextcloud.com/nextcloud/server/16578/237 Status of 16578: failure
Show full log
Show full log |
Cool! :-D
Then I stand corrected and bow before your objective data ;-) |
😆 |
|
/backport to stable15 |
|
/backport to stable14 |
|
backport to stable15 in #14495 |
|
backport to stable14 in #14496 |
Ref #12104
Hopefully this solves most of the problems we see.