Fix a bug with smb notify having leading slash when it should not #14456
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ari Selseng <[email protected]>
icewind1991
approved these changes
Mar 1, 2019
Member
|
/backport to stable15 |
Member
|
/backport to stable14 |
rullzer
approved these changes
Mar 1, 2019
|
Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 |
|
backport to stable15 in #14462 |
Member
|
/backport to stable14 |
Member
|
@rullzer Did the bot just died? |
Member
|
/backport to stable14 |
Member
|
I found the branch of the bot, but there was no PR - so here it is: #14866 (stable14 back port) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@icewind1991
My SMB server with occ files_external:notify 1 -vvv reported paths like
The path for the entry in the oc_filecache table had no leading slash ("Temp/test/test123.txt") and its parent too. Which means that the parent never got updated with size = -1. This should fix some (all?) smb notify issues.