Skip to content

Conversation

@ChristophWurst
Copy link
Member

@ChristophWurst ChristophWurst commented Mar 6, 2019

v2.2.x behaves different in terms of when the page is ready. See #13496 (comment) for more detail. Apparently 7207a77 updated jquery accidentally.

Fixes #14556

Signed-off-by: Christoph Wurst <[email protected]>
@ChristophWurst
Copy link
Member Author

How to test: run npm ls jquery on master and this branch ;)

@ChristophWurst ChristophWurst added the 4. to release Ready to be released and/or waiting for tests to finish label Mar 6, 2019
@faily-bot
Copy link

faily-bot bot commented Mar 6, 2019

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 16815: failure

TESTS=acceptance, TESTS-ACCEPTANCE=app-files

  • cancelled - typically means that the tests took longer than the drone CI allows them to run

TESTS=acceptance, TESTS-ACCEPTANCE=apps

  • tests/acceptance/features/apps.feature:75
Show full log
  Scenario: View app details for app store apps   # /drone/src/github.com/nextcloud/server/tests/acceptance/features/apps.feature:75
    Given I act as Jane                           # ActorContext::iActAs()
    And I am logged in as the admin               # LoginPageContext::iAmLoggedInAsTheAdmin()
    And I open the Apps management                # SettingsMenuContext::iOpenTheAppsManagement()
    And I open the "Tools" section                # AppNavigationContext::iOpenTheSection()
      Tools section item in App Navigation could not be found after 100 seconds (NoSuchElementException)
    When I click on the "Antivirus for files" app # AppsManagementContext::iClickOnTheApp()
    Then I see that the app details are shown     # AppsManagementContext::iSeeThatTheAppDetailsAreShown()

@MorrisJobke MorrisJobke merged commit 540ec4f into master Mar 6, 2019
@MorrisJobke MorrisJobke deleted the fix/jquery-version branch March 6, 2019 14:32
@MorrisJobke MorrisJobke mentioned this pull request Mar 6, 2019
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish bug regression

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants