Skip to content

Conversation

@backportbot-nextcloud
Copy link

backport of #14424

Else this leads to a seekable stream error with chunked uploads

Signed-off-by: Roeland Jago Douma <[email protected]>
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code makes sense 👍

@rullzer rullzer added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Mar 6, 2019
@faily-bot
Copy link

faily-bot bot commented Mar 6, 2019

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 16829: failure

TESTS=acceptance, TESTS-ACCEPTANCE=app-comments

  • tests/acceptance/features/app-comments.feature:10
Show full log
  Scenario: open the comments for a different file           # /drone/src/github.com/nextcloud/server/tests/acceptance/features/app-comments.feature:10
    Given I am logged in                                     # LoginPageContext::iAmLoggedIn()
    And I create a new folder named "Folder"                 # FileListContext::iCreateANewFolderNamed()
    And I open the details view for "welcome.txt"            # FileListContext::iOpenTheDetailsViewFor()
    And I open the "Comments" tab in the details view        # FilesAppContext::iOpenTheTabInTheDetailsView()
    And I create a new comment with "Hello world" as message # CommentsAppContext::iCreateANewCommentWithAsMessage()
    And I see a comment with "Hello world" as message        # CommentsAppContext::iSeeACommentWithAsMessage()
      Comment with text "Hello world" in details view in Files app could not be found after 100 seconds (NoSuchElementException)
    When I open the details view for "Folder"                # FileListContext::iOpenTheDetailsViewFor()
    Then I see that there are no comments                    # CommentsAppContext::iSeeThatThereAreNoComments()

TESTS=acceptance, TESTS-ACCEPTANCE=app-files

  • tests/acceptance/features/app-files.feature:126
  • tests/acceptance/features/app-files.feature:133
  • tests/acceptance/features/app-files.feature:206
Show full log
  Scenario: show deleted files                                        # /drone/src/github.com/nextcloud/server/tests/acceptance/features/app-files.feature:126
    Given I am logged in                                              # LoginPageContext::iAmLoggedIn()
    And I delete "welcome.txt"                                        # FileListContext::iDelete()
    When I open the "Deleted files" section                           # AppNavigationContext::iOpenTheSection()
    Then I see that the current section is "Deleted files"            # AppNavigationContext::iSeeThatTheCurrentSectionIs()
    Then I see that the file list contains a file named "welcome.txt" # FileListContext::iSeeThatTheFileListContainsAFileNamed()
      Row for file welcome.txt in file list could not be found after 100 seconds (NoSuchElementException)

  Scenario: show deleted files for a second time                      # /drone/src/github.com/nextcloud/server/tests/acceptance/features/app-files.feature:133
    Given I am logged in                                              # LoginPageContext::iAmLoggedIn()
    And I open the "Deleted files" section                            # AppNavigationContext::iOpenTheSection()
    And I see that the current section is "Deleted files"             # AppNavigationContext::iSeeThatTheCurrentSectionIs()
    And I open the "All files" section                                # AppNavigationContext::iOpenTheSection()
    And I see that the current section is "All files"                 # AppNavigationContext::iSeeThatTheCurrentSectionIs()
    And I delete "welcome.txt"                                        # FileListContext::iDelete()
    When I open the "Deleted files" section                           # AppNavigationContext::iOpenTheSection()
    Then I see that the current section is "Deleted files"            # AppNavigationContext::iSeeThatTheCurrentSectionIs()
    Then I see that the file list contains a file named "welcome.txt" # FileListContext::iSeeThatTheFileListContainsAFileNamed()
      Row for file welcome.txt in file list could not be found after 100 seconds (NoSuchElementException)

  Scenario: rename a file with the details view open                         # /drone/src/github.com/nextcloud/server/tests/acceptance/features/app-files.feature:206
    Given I am logged in                                                     # LoginPageContext::iAmLoggedIn()
    And I open the details view for "welcome.txt"                            # FileListContext::iOpenTheDetailsViewFor()
    When I rename "welcome.txt" to "farewell.txt"                            # FileListContext::iRenameTo()
    Then I see that the file list contains a file named "farewell.txt"       # FileListContext::iSeeThatTheFileListContainsAFileNamed()
      Row for file farewell.txt in file list could not be found after 100 seconds (NoSuchElementException)
    And I see that the file name shown in the details view is "farewell.txt" # FilesAppContext::iSeeThatTheFileNameShownInTheDetailsViewIs()

TESTS=acceptance, TESTS-ACCEPTANCE=app-files-sharing

  • cancelled - typically means that the tests took longer than the drone CI allows them to run

TESTS=acceptance, TESTS-ACCEPTANCE=login

  • tests/acceptance/features/login.feature:15
Show full log
  Scenario: log in with valid user and invalid password once fixed by admin # /drone/src/github.com/nextcloud/server/tests/acceptance/features/login.feature:15
    Given I act as John                                                     # ActorContext::iActAs()
    And I can not log in with user user0 and password 654231                # LoginPageContext::iCanNotLogInWithUserAndPassword()
    When I act as Jane                                                      # ActorContext::iActAs()
    And I am logged in as the admin                                         # LoginPageContext::iAmLoggedInAsTheAdmin()
    And I open the User settings                                            # SettingsMenuContext::iOpenTheUserSettings()
    And I set the password for user0 to 654321                              # UsersSettingsContext::iSetTheFieldForUserTo()
    And I act as John                                                       # ActorContext::iActAs()
    And I log in with user user0 and password 654321                        # LoginPageContext::iLogInWithUserAndPassword()
    Then I see that the current page is the Files app                       # FilesAppContext::iSeeThatTheCurrentPageIsTheFilesApp()
      Failed asserting that 'http://acceptance-login/index.php/login?user=user0' starts with "http://acceptance-login/index.php/apps/files/".

TESTS=acceptance, TESTS-ACCEPTANCE=users

  • cancelled - typically means that the tests took longer than the drone CI allows them to run

@rullzer rullzer merged commit 3de750c into stable15 Mar 6, 2019
@rullzer rullzer deleted the backport/14424/stable15 branch March 6, 2019 19:35
@mzamot
Copy link
Contributor

mzamot commented Mar 8, 2019

With the latest commit in stable15 I still get a similar error: "Unable to seek to stream position 0 with whence 0" in files bigger than 10mb.

@rullzer rullzer mentioned this pull request Mar 29, 2019
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish regression

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants