Skip to content

Force enable apps #14578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rullzer merged 4 commits into from
Mar 20, 2019
Merged

Force enable apps #14578

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
769cb62
allow enforcing apps to ignore the max version
rullzer Mar 6, 2019
95c9e0e
Remove apps from the list which have no release at all
nickvergessen Mar 20, 2019
2d00e2b
Do not ignore the max-version for the "update-available" check
nickvergessen Mar 20, 2019
942281a
Remove unused IUserSession
nickvergessen Mar 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Remove unused IUserSession 
Signed-off-by: Joas Schilling <[email protected]>
  • Loading branch information
@nickvergessen @rullzer
nickvergessen authored and rullzer committed Mar 20, 2019
commit 942281a48e2791cf6c46de758985e62806bed363
4 changes: 0 additions & 4 deletions apps/updatenotification/lib/Settings/Admin.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,6 @@ class Admin implements ISettings {
private $groupManager;
/** @var IDateTimeFormatter */
private $dateTimeFormatter;
/** @var IUserSession */
private $session;
/** @var IFactory */
private $l10nFactory;

Expand All @@ -55,14 +53,12 @@ public function __construct(
UpdateChecker $updateChecker,
IGroupManager $groupManager,
IDateTimeFormatter $dateTimeFormatter,
IUserSession $session,
IFactory $l10nFactory
) {
$this->config = $config;
$this->updateChecker = $updateChecker;
$this->groupManager = $groupManager;
$this->dateTimeFormatter = $dateTimeFormatter;
$this->session = $session;
$this->l10nFactory = $l10nFactory;
}

Expand Down
5 changes: 1 addition & 4 deletions apps/updatenotification/tests/Settings/AdminTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,6 @@
use Test\TestCase;

class AdminTest extends TestCase {
/** @var IUserSession|\PHPUnit_Framework_MockObject_MockObject */
protected $userSession;
/** @var IFactory|\PHPUnit_Framework_MockObject_MockObject */
protected $l10nFactory;
/** @var Admin */
Expand All @@ -61,11 +59,10 @@ public function setUp() {
$this->updateChecker = $this->createMock(UpdateChecker::class);
$this->groupManager = $this->createMock(IGroupManager::class);
$this->dateTimeFormatter = $this->createMock(IDateTimeFormatter::class);
$this->userSession = $this->createMock(IUserSession::class);
$this->l10nFactory = $this->createMock(IFactory::class);

$this->admin = new Admin(
$this->config, $this->updateChecker, $this->groupManager, $this->dateTimeFormatter, $this->userSession, $this->l10nFactory
$this->config, $this->updateChecker, $this->groupManager, $this->dateTimeFormatter, $this->l10nFactory
);
}

Expand Down