Remove Google+ from Social Sharing Bundle #14587

MariusBluem · 2019-03-07T13:58:54Z

No description provided.

Signed-off-by: Marius Blüm <[email protected]>

faily-bot · 2019-03-07T15:08:24Z

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 16853: failure

TESTS=acceptance, TESTS-ACCEPTANCE=app-comments

tests/acceptance/features/app-comments.feature:10

Show full log

  Scenario: open the comments for a different file           # /drone/src/github.com/nextcloud/server/tests/acceptance/features/app-comments.feature:10
    Given I am logged in                                     # LoginPageContext::iAmLoggedIn()
    And I create a new folder named "Folder"                 # FileListContext::iCreateANewFolderNamed()
    And I open the details view for "welcome.txt"            # FileListContext::iOpenTheDetailsViewFor()
    And I open the "Comments" tab in the details view        # FilesAppContext::iOpenTheTabInTheDetailsView()
    And I create a new comment with "Hello world" as message # CommentsAppContext::iCreateANewCommentWithAsMessage()
    And I see a comment with "Hello world" as message        # CommentsAppContext::iSeeACommentWithAsMessage()
      Comment with text "Hello world" in details view in Files app could not be found after 100 seconds (NoSuchElementException)
    When I open the details view for "Folder"                # FileListContext::iOpenTheDetailsViewFor()

TESTS=acceptance, TESTS-ACCEPTANCE=app-files

tests/acceptance/features/app-files.feature:90
tests/acceptance/features/app-files.feature:97
tests/acceptance/features/app-files.feature:172

Show full log

  Scenario: show favorites                                            # /drone/src/github.com/nextcloud/server/tests/acceptance/features/app-files.feature:90
    Given I am logged in                                              # LoginPageContext::iAmLoggedIn()
    And I mark "welcome.txt" as favorite                              # FileListContext::iMarkAsFavorite()
    When I open the "Favorites" section                               # AppNavigationContext::iOpenTheSection()
    Then I see that the current section is "Favorites"                # AppNavigationContext::iSeeThatTheCurrentSectionIs()
    Then I see that the file list contains a file named "welcome.txt" # FileListContext::iSeeThatTheFileListContainsAFileNamed()
      Row for file welcome.txt in file list could not be found after 100 seconds (NoSuchElementException)

  Scenario: show favorites for a second time                          # /drone/src/github.com/nextcloud/server/tests/acceptance/features/app-files.feature:97
    Given I am logged in                                              # LoginPageContext::iAmLoggedIn()
    And I open the "Favorites" section                                # AppNavigationContext::iOpenTheSection()
    And I see that the current section is "Favorites"                 # AppNavigationContext::iSeeThatTheCurrentSectionIs()
    And I open the "All files" section                                # AppNavigationContext::iOpenTheSection()
    And I see that the current section is "All files"                 # AppNavigationContext::iSeeThatTheCurrentSectionIs()
    And I mark "welcome.txt" as favorite                              # FileListContext::iMarkAsFavorite()
    When I open the "Favorites" section                               # AppNavigationContext::iOpenTheSection()
    Then I see that the current section is "Favorites"                # AppNavigationContext::iSeeThatTheCurrentSectionIs()
    Then I see that the file list contains a file named "welcome.txt" # FileListContext::iSeeThatTheFileListContainsAFileNamed()
      Row for file welcome.txt in file list could not be found after 100 seconds (NoSuchElementException)

  Scenario: copy a file to another folder                            # /drone/src/github.com/nextcloud/server/tests/acceptance/features/app-files.feature:172
    Given I am logged in                                             # LoginPageContext::iAmLoggedIn()
    And I create a new folder named "Destination"                    # FileListContext::iCreateANewFolderNamed()
    When I start the move or copy operation for "welcome.txt"        # FileListContext::iStartTheMoveOrCopyOperationFor()
    And I select "Destination" in the file picker                    # FilePickerContext::iSelectInTheFilePicker()
      Row for file Destination in the file picker dialog could not be found after 100 seconds (NoSuchElementException)
    And I copy to the last selected folder in the file picker        # FilePickerContext::iCopyToTheLastSelectedFolderInTheFilePicker()
    Then I enter in the folder named "Destination"                   # FileListContext::iEnterInTheFolderNamed()
    And I see that the file list contains a file named "welcome.txt" # FileListContext::iSeeThatTheFileListContainsAFileNamed()
    And I open the Files app                                         # FilesAppContext::iOpenTheFilesApp()
    And I see that the file list contains a file named "welcome.txt" # FileListContext::iSeeThatTheFileListContainsAFileNamed()

TESTS=acceptance, TESTS-ACCEPTANCE=app-files-tags

tests/acceptance/features/app-files-tags.feature:11

Show full log

  Scenario: show the input field for tags in the details view after closing and opening the details view again # /drone/src/github.com/nextcloud/server/tests/acceptance/features/app-files-tags.feature:11
    Given I am logged in                                                                                       # LoginPageContext::iAmLoggedIn()
    And I open the details view for "welcome.txt"                                                              # FileListContext::iOpenTheDetailsViewFor()
    And I see that the details view is open                                                                    # FilesAppContext::iSeeThatTheDetailsViewIsOpen()
    And I close the details view                                                                               # FilesAppContext::iCloseTheDetailsView()
    And I see that the details view is closed                                                                  # FilesAppContext::iSeeThatTheDetailsViewIsClosed()
    And I open the details view for "welcome.txt"                                                              # FileListContext::iOpenTheDetailsViewFor()
    And I see that the details view is open                                                                    # FilesAppContext::iSeeThatTheDetailsViewIsOpen()
    When I open the input field for tags in the details view                                                   # FilesAppContext::iOpenTheInputFieldForTagsInTheDetailsView()
    Then I see that the input field for tags in the details view is shown                                      # FilesAppContext::iSeeThatTheInputFieldForTagsInTheDetailsViewIsShown()
      Failed asserting that false is true.

TESTS=acceptance, TESTS-ACCEPTANCE=login

tests/acceptance/features/login.feature:9
tests/acceptance/features/login.feature:15
tests/acceptance/features/login.feature:26
tests/acceptance/features/login.feature:38

Show full log

  Scenario: try to log in with valid user and invalid password # /drone/src/github.com/nextcloud/server/tests/acceptance/features/login.feature:9
    Given I visit the Home page                                # FeatureContext::iVisitTheHomePage()
    When I log in with user user0 and password 654321          # LoginPageContext::iLogInWithUserAndPassword()
    Then I see that the current page is the Login page         # LoginPageContext::iSeeThatTheCurrentPageIsTheLoginPage()
    And I see that a wrong password message is shown           # LoginPageContext::iSeeThatAWrongPasswordMessageIsShown()
      Wrong password message in Login page could not be found after 100 seconds (NoSuchElementException)

  Scenario: log in with valid user and invalid password once fixed by admin # /drone/src/github.com/nextcloud/server/tests/acceptance/features/login.feature:15
    Given I act as John                                                     # ActorContext::iActAs()
    And I can not log in with user user0 and password 654231                # LoginPageContext::iCanNotLogInWithUserAndPassword()
      Wrong password message in Login page could not be found after 100 seconds (NoSuchElementException)
    When I act as Jane                                                      # ActorContext::iActAs()
    And I am logged in as the admin                                         # LoginPageContext::iAmLoggedInAsTheAdmin()
    And I open the User settings                                            # SettingsMenuContext::iOpenTheUserSettings()
    And I set the password for user0 to 654321                              # UsersSettingsContext::iSetTheFieldForUserTo()
    And I act as John                                                       # ActorContext::iActAs()
    And I log in with user user0 and password 654321                        # LoginPageContext::iLogInWithUserAndPassword()
    Then I see that the current page is the Files app                       # FilesAppContext::iSeeThatTheCurrentPageIsTheFilesApp()

  Scenario: try to log in with invalid user                    # /drone/src/github.com/nextcloud/server/tests/acceptance/features/login.feature:26
    Given I visit the Home page                                # FeatureContext::iVisitTheHomePage()
    When I log in with user unknownUser and password 123456acb # LoginPageContext::iLogInWithUserAndPassword()
    Then I see that the current page is the Login page         # LoginPageContext::iSeeThatTheCurrentPageIsTheLoginPage()
    And I see that a wrong password message is shown           # LoginPageContext::iSeeThatAWrongPasswordMessageIsShown()
      Wrong password message in Login page could not be found after 100 seconds (NoSuchElementException)

  Scenario: log in with invalid user once fixed by admin              # /drone/src/github.com/nextcloud/server/tests/acceptance/features/login.feature:38
    Given I act as John                                               # ActorContext::iActAs()
    And I can not log in with user unknownUser and password 123456acb # LoginPageContext::iCanNotLogInWithUserAndPassword()
      Wrong password message in Login page could not be found after 100 seconds (NoSuchElementException)
    When I act as Jane                                                # ActorContext::iActAs()
    And I am logged in as the admin                                   # LoginPageContext::iAmLoggedInAsTheAdmin()
    And I open the User settings                                      # SettingsMenuContext::iOpenTheUserSettings()
    And I click the New user button                                   # UsersSettingsContext::iClickTheNewUserButton()
    And I see that the new user form is shown                         # UsersSettingsContext::iSeeThatTheNewUserFormIsShown()
    And I create user unknownUser with password 123456acb             # UsersSettingsContext::iCreateUserWithPassword()
    And I see that the list of users contains the user unknownUser    # UsersSettingsContext::iSeeThatTheListOfUsersContainsTheUser()
    And I act as John                                                 # ActorContext::iActAs()
    And I log in with user unknownUser and password 123456acb         # LoginPageContext::iLogInWithUserAndPassword()

rullzer

sure

MorrisJobke · 2019-03-08T08:05:00Z

/backport to stable15

MorrisJobke · 2019-03-08T08:05:11Z

/backport to stable14

backportbot-nextcloud · 2019-03-08T08:07:00Z

backport to stable14 in #14595

backportbot-nextcloud · 2019-03-08T08:07:00Z

backport to stable15 in #14596

rBradderzz · 2019-03-08T09:25:13Z

[email protected]<mailto:[email protected]> left the company sometime ago however hundreds of emails per day are being sent to him from yourself – could the address be removed from your database please? [Cloud53 Ltd] Craig Robinson | Director T: 0333 444 5353 | M: 07710 100 949 E: [email protected] W: http://www.cloud53.co.uk<http://www.cloud53.co.uk/> [cid:[email protected]]<http://www.cloud53.co.uk/brochures/cloud53.pdf>Click here for the Cloud53 Service summary<http://www.cloud53.co.uk/brochures/cloud53.pdf> [icon-googleplus_28x28]<https://plus.google.com/112106875848692053939/about>[icon-facebook_28x28]<https://www.facebook.com/pages/Cloud53/1401200130189347>[icon-linkedin_28x28]<https://www.linkedin.com/company/cloud53-ltd>[icon-twitter_28x28]<http://www.twitter.com/Cloud53ltd> [http://www.linkedin.com/img/webpromo/btn_viewmy_160x25.gif]<http://uk.linkedin.com/in/craigrobinson> From: Morris Jobke <[email protected]> Sent: 08 March 2019 08:05 To: nextcloud/server <[email protected]> Cc: Subscribed <[email protected]> Subject: Re: [nextcloud/server] Remove Google+ from Social Sharing Bundle (#14587) /backport to stable15 — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub<#14587 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AU8Y-4icdUsYWAsdOsgyxanHRx-VHHA7ks5vUhm0gaJpZM4bjP0Z>.

MorrisJobke · 2019-03-08T09:27:23Z

[email protected]mailto:[email protected] left the company sometime ago however hundreds of emails per day are being sent to him from yourself – could the address be removed from your database please?

@rBradderzz Please contact Github.

MariusBluem added 2 commits March 7, 2019 14:56

Remove "socialsharing_googleplus" from Social Sharing Bundle

8093715

Signed-off-by: Marius Blüm <[email protected]>

Remove Google+ from Social Sharing Bundle (2)

f7ea96f

Signed-off-by: Marius Blüm <[email protected]>

MariusBluem added the feature: apps management label Mar 7, 2019

MariusBluem added this to the Nextcloud 16 milestone Mar 7, 2019

MariusBluem requested review from MorrisJobke, rullzer and schiessle March 7, 2019 13:58

MariusBluem added the 3. to review Waiting for reviews label Mar 7, 2019

rullzer approved these changes Mar 7, 2019

View reviewed changes

MorrisJobke approved these changes Mar 8, 2019

View reviewed changes

backportbot-nextcloud bot added the backport-request label Mar 8, 2019

MorrisJobke merged commit 70aa859 into master Mar 8, 2019

MorrisJobke deleted the remove-googleplus-social-sharing-bundle branch March 8, 2019 08:05

This was referenced Mar 8, 2019

[stable14] Remove Google+ from Social Sharing Bundle #14595

Merged

[stable15] Remove Google+ from Social Sharing Bundle #14596

Merged

backportbot-nextcloud bot removed the backport-request label Mar 8, 2019

backportbot-nextcloud bot added the backport-request label Mar 8, 2019

MorrisJobke removed the backport-request label Mar 8, 2019

MorrisJobke mentioned this pull request Mar 20, 2019

16.0.0 Beta 1 #14573

Merged

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Remove Google+ from Social Sharing Bundle #14587

Remove Google+ from Social Sharing Bundle #14587

Uh oh!

MariusBluem commented Mar 7, 2019

Uh oh!

faily-bot bot commented Mar 7, 2019

Uh oh!

rullzer left a comment

Uh oh!

MorrisJobke commented Mar 8, 2019

Uh oh!

MorrisJobke commented Mar 8, 2019

Uh oh!

backportbot-nextcloud bot commented Mar 8, 2019

Uh oh!

backportbot-nextcloud bot commented Mar 8, 2019

Uh oh!

rBradderzz commented Mar 8, 2019 via email

Uh oh!

MorrisJobke commented Mar 8, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Remove Google+ from Social Sharing Bundle #14587

Remove Google+ from Social Sharing Bundle #14587

Uh oh!

Conversation

MariusBluem commented Mar 7, 2019

Uh oh!

faily-bot bot commented Mar 7, 2019

Status of 16853: failure

TESTS=acceptance, TESTS-ACCEPTANCE=app-comments

TESTS=acceptance, TESTS-ACCEPTANCE=app-files

TESTS=acceptance, TESTS-ACCEPTANCE=app-files-tags

TESTS=acceptance, TESTS-ACCEPTANCE=login

Uh oh!

rullzer left a comment

Choose a reason for hiding this comment

Uh oh!

MorrisJobke commented Mar 8, 2019

Uh oh!

MorrisJobke commented Mar 8, 2019

Uh oh!

backportbot-nextcloud bot commented Mar 8, 2019

Uh oh!

backportbot-nextcloud bot commented Mar 8, 2019

Uh oh!

rBradderzz commented Mar 8, 2019 via email

Uh oh!

MorrisJobke commented Mar 8, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants