Skip to content

Make check for empty trusted proxies more strict #14606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MorrisJobke merged 2 commits into from
Mar 21, 2019
Merged

Make check for empty trusted proxies more strict #14606

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3855d78
Make check for empty trusted proxies more strict
kesselb Mar 9, 2019
ff629ad
Trigger warning if empty array or false and X-Forwarded-Host is present
kesselb Mar 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Trigger warning if empty array or false and X-Forwarded-Host is present 
Signed-off-by: Daniel Kesselberg <[email protected]>
  • Loading branch information
@kesselb
kesselb committed Mar 20, 2019
commit ff629ad158a6e2b1ae0202733e31f1ae14723d96
2 changes: 1 addition & 1 deletion settings/Controller/CheckSetupController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,7 +289,7 @@ private function forwardedForHeadersWorking() {
$trustedProxies = $this->config->getSystemValue('trusted_proxies', []);
$remoteAddress = $this->request->getHeader('REMOTE_ADDR');

if ($trustedProxies === [] && $this->request->getHeader('X-Forwarded-Host') !== '') {
if (empty($trustedProxies) && $this->request->getHeader('X-Forwarded-Host') !== '') {
return false;
}

Expand Down