Skip to content

Fix acceptance tests for wrong password message due to changed message #14623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MorrisJobke merged 1 commit into from
Mar 11, 2019
Merged

Fix acceptance tests for wrong password message due to changed message #14623

MorrisJobke merged 1 commit into from
Mar 11, 2019

Conversation

@MorrisJobke
Copy link
Member

@MorrisJobke MorrisJobke commented Mar 11, 2019

Regression from #14561

@MorrisJobke MorrisJobke added bug 3. to review Waiting for reviews labels Mar 11, 2019
@MorrisJobke MorrisJobke added this to the Nextcloud 16 milestone Mar 11, 2019
skjnldsv
skjnldsv approved these changes Mar 11, 2019
View reviewed changes
Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈

@faily-bot
Copy link

faily-bot bot commented Mar 11, 2019

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 16906: failure

TESTS=integration-federation_features

  • build/integration/federation_features/federated.feature:183
  • build/integration/federation_features/federated.feature:232
  • build/integration/federation_features/federated.feature:247
  • build/integration/federation_features/federated.feature:263
Show full log 
[Mon Mar 11 11:09:54 2019] 127.0.0.1:52700 [200]: /ocs/v1.php/apps/testing/api/v1/app/files_sharing/incoming_server2server_group_share_enabled
[Mon Mar 11 11:09:54 2019] 127.0.0.1:52724 [200]: /ocs/v1.php/apps/testing/api/v1/app/files_sharing/outgoing_server2server_group_share_enabled
  Scenario: Reshare a federated shared file                                                             # /drone/src/github.com/nextcloud/server/build/integration/federation_features/federated.feature:183
    Given Using server "REMOTE"                                                                         # FederationContext::usingServer()
[Mon Mar 11 11:09:56 2019] 127.0.0.1:58138 [404]: /ocs/v2.php/cloud/users/user1
[Mon Mar 11 11:09:58 2019] 127.0.0.1:58188 [200]: /ocs/v1.php/cloud/users
[Mon Mar 11 11:10:16 2019] 127.0.0.1:58300 [200]: /ocs/v1.php/cloud/users/user1
[Mon Mar 11 11:10:17 2019] 127.0.0.1:59044 [200]: /ocs/v2.php/cloud/users/user1
    And user "user1" exists                                                                             # FederationContext::assureUserExists()
[Mon Mar 11 11:10:18 2019] 127.0.0.1:59062 [404]: /ocs/v2.php/cloud/users/user2
[Mon Mar 11 11:10:21 2019] 127.0.0.1:59096 [200]: /ocs/v1.php/cloud/users
[Mon Mar 11 11:10:39 2019] 127.0.0.1:59236 [200]: /ocs/v1.php/cloud/users/user2
[Mon Mar 11 11:10:40 2019] 127.0.0.1:59940 [200]: /ocs/v2.php/cloud/users/user2
    And user "user2" exists                                                                             # FederationContext::assureUserExists()
    And Using server "LOCAL"                                                                            # FederationContext::usingServer()
[Mon Mar 11 11:10:42 2019] 127.0.0.1:54632 [404]: /ocs/v2.php/cloud/users/user0
[Mon Mar 11 11:10:45 2019] 127.0.0.1:54720 [200]: /ocs/v1.php/cloud/users
[Mon Mar 11 11:11:08 2019] 127.0.0.1:55004 [200]: /ocs/v1.php/cloud/users/user0
[Mon Mar 11 11:11:09 2019] 127.0.0.1:55866 [200]: /ocs/v2.php/cloud/users/user0
    And user "user0" exists                                                                             # FederationContext::assureUserExists()
[Mon Mar 11 11:11:10 2019] 127.0.0.1:33114 [200]: /ocm-provider/
[Mon Mar 11 11:11:12 2019] 127.0.0.1:33116 [201]: /index.php/ocm/shares
[Mon Mar 11 11:11:12 2019] 127.0.0.1:55934 [200]: /ocs/v1.php/apps/files_sharing/api/v1/shares
    And User "user0" from server "LOCAL" shares "/textfile0.txt" with user "user1" from server "REMOTE" # FederationContext::federateSharing()
[Mon Mar 11 11:11:13 2019] 127.0.0.1:33146 [200]: /ocs/v1.php/apps/files_sharing/api/v1/remote_shares/pending
[Mon Mar 11 11:11:15 2019] 127.0.0.1:56024 [200]: //ocm-provider/
[Mon Mar 11 11:11:15 2019] 127.0.0.1:56026 [201]: /index.php/ocm/notifications
[Mon Mar 11 11:11:15 2019] 127.0.0.1:56028 [200]: //ocs-provider/
[Mon Mar 11 11:11:15 2019] 127.0.0.1:56030 [200]: /ocs/v2.php/cloud/shares/8/accept?format=json
[Mon Mar 11 11:11:15 2019] 127.0.0.1:33162 [200]: /ocs/v1.php/apps/files_sharing/api/v1/remote_shares/pending/9
    And User "user1" from server "REMOTE" accepts last pending share                                    # FederationContext::acceptLastPendingShare()
    And Using server "REMOTE"                                                                           # FederationContext::usingServer()
    And As an "user1"                                                                                   # FederationContext::asAn()
[Mon Mar 11 11:11:16 2019] 127.0.0.1:56036 [200]: //ocs-provider/
[Mon Mar 11 11:11:16 2019] 127.0.0.1:56038 [200]: //status.php
[Mon Mar 11 11:11:16 2019] 127.0.0.1:56040 [200]: //status.php
[Mon Mar 11 11:11:16 2019] 127.0.0.1:56042 [200]: /index.php/apps/files_sharing/shareinfo?t=Z3QRjcJTMLsPEwU
[Mon Mar 11 11:11:16 2019] 127.0.0.1:33188 [200]: /ocs/v1.php/apps/files_sharing/api/v1/shares
    When creating a share with                                                                          # FederationContext::creatingShare()
      | path        | /textfile0 (2).txt |
      | shareType   | 0                  |
      | shareWith   | user2              |
      | permissions | 19                 |
    Then the OCS status code should be "100"                                                            # FederationContext::theOCSStatusCodeShouldBe()
      Failed asserting that SimpleXMLElement Object &000000005872f3da0000000042464f3c (
          0 => '404'
      ) matches expected '100'.
    And the HTTP status code should be "200"                                                            # FederationContext::theHTTPStatusCodeShouldBe()
    And Share fields of last share match with                                                           # FederationContext::checkShareFields()
      | id                     | A_NUMBER           |
      | item_type              | file               |
      | item_source            | A_NUMBER           |
      | share_type             | 0                  |
      | file_source            | A_NUMBER           |
      | path                   | /textfile0 (2).txt |
      | permissions            | 19                 |
      | stime                  | A_NUMBER           |
      | storage                | A_NUMBER           |
      | mail_send              | 1                  |
      | uid_owner              | user1              |
      | file_parent            | A_NUMBER           |
      | displayname_owner      | user1              |
      | share_with             | user2              |
      | share_with_displayname | user2              |
[Mon Mar 11 11:11:28 2019] 127.0.0.1:56044 [200]: /ocs/v1.php/cloud/users/user0
[Mon Mar 11 11:11:29 2019] 127.0.0.1:56220 [404]: /ocs/v2.php/cloud/users/user0
[Mon Mar 11 11:11:41 2019] 127.0.0.1:56716 [200]: //ocm-provider/
[Mon Mar 11 11:11:42 2019] 127.0.0.1:56722 [400]: /index.php/ocm/notifications
[Mon Mar 11 11:11:42 2019] error while sending notification for federated share: Client error: `POST http://localhost:8080/index.php/ocm/notifications` resulted in a `400 Bad request` response:
{"message":"Can not find share with ID: 8"}

[Mon Mar 11 11:14:20 2019] 127.0.0.1:35056 [200]: /ocs/v1.php/apps/testing/api/v1/app/files_sharing/incoming_server2server_group_share_enabled
[Mon Mar 11 11:14:21 2019] 127.0.0.1:35108 [200]: /ocs/v1.php/apps/testing/api/v1/app/files_sharing/outgoing_server2server_group_share_enabled
  Scenario: Overwrite a federated shared folder as recipient                                             # /drone/src/github.com/nextcloud/server/build/integration/federation_features/federated.feature:232
    Given Using server "REMOTE"                                                                          # FederationContext::usingServer()
[Mon Mar 11 11:14:22 2019] 127.0.0.1:40526 [404]: /ocs/v2.php/cloud/users/user1
[Mon Mar 11 11:14:24 2019] 127.0.0.1:40560 [200]: /ocs/v1.php/cloud/users
[Mon Mar 11 11:14:42 2019] 127.0.0.1:40628 [200]: /ocs/v1.php/cloud/users/user1
[Mon Mar 11 11:14:43 2019] 127.0.0.1:41294 [200]: /ocs/v2.php/cloud/users/user1
    And user "user1" exists                                                                              # FederationContext::assureUserExists()
[Mon Mar 11 11:14:44 2019] 127.0.0.1:41328 [404]: /ocs/v2.php/cloud/users/user2
[Mon Mar 11 11:14:47 2019] 127.0.0.1:41398 [200]: /ocs/v1.php/cloud/users
[Mon Mar 11 11:15:09 2019] 127.0.0.1:41496 [200]: /ocs/v1.php/cloud/users/user2
[Mon Mar 11 11:15:10 2019] 127.0.0.1:42532 [200]: /ocs/v2.php/cloud/users/user2
    And user "user2" exists                                                                              # FederationContext::assureUserExists()
    And Using server "LOCAL"                                                                             # FederationContext::usingServer()
[Mon Mar 11 11:15:11 2019] 127.0.0.1:37196 [404]: /ocs/v2.php/cloud/users/user0
[Mon Mar 11 11:15:13 2019] 127.0.0.1:37286 [200]: /ocs/v1.php/cloud/users
[Mon Mar 11 11:15:32 2019] 127.0.0.1:37386 [200]: /ocs/v1.php/cloud/users/user0
[Mon Mar 11 11:15:33 2019] 127.0.0.1:38094 [200]: /ocs/v2.php/cloud/users/user0
    And user "user0" exists                                                                              # FederationContext::assureUserExists()
[Mon Mar 11 11:15:34 2019] 127.0.0.1:43534 [200]: /ocm-provider/
[Mon Mar 11 11:15:34 2019] 127.0.0.1:43536 [201]: /index.php/ocm/shares
[Mon Mar 11 11:15:34 2019] 127.0.0.1:38118 [200]: /ocs/v1.php/apps/files_sharing/api/v1/shares
    And User "user0" from server "LOCAL" shares "/PARENT" with user "user1" from server "REMOTE"         # FederationContext::federateSharing()
[Mon Mar 11 11:15:35 2019] 127.0.0.1:43542 [200]: /ocs/v1.php/apps/files_sharing/api/v1/remote_shares/pending
[Mon Mar 11 11:15:35 2019] 127.0.0.1:38254 [200]: //ocm-provider/
[Mon Mar 11 11:15:35 2019] 127.0.0.1:38256 [201]: /index.php/ocm/notifications
[Mon Mar 11 11:15:35 2019] 127.0.0.1:38258 [200]: //ocs-provider/
[Mon Mar 11 11:15:35 2019] 127.0.0.1:38260 [200]: /ocs/v2.php/cloud/shares/10/accept?format=json
[Mon Mar 11 11:15:35 2019] 127.0.0.1:43610 [200]: /ocs/v1.php/apps/files_sharing/api/v1/remote_shares/pending/11
    And User "user1" from server "REMOTE" accepts last pending share                                     # FederationContext::acceptLastPendingShare()
    And Using server "REMOTE"                                                                            # FederationContext::usingServer()
    And As an "user1"                                                                                    # FederationContext::asAn()
    And User "user1" modifies text of "/textfile0.txt" with text "BLABLABLA"                             # FederationContext::modifyTextOfFile()
[Mon Mar 11 11:15:37 2019] 127.0.0.1:38336 [200]: //ocs-provider/
[Mon Mar 11 11:15:37 2019] 127.0.0.1:38338 [401]: /public.php/webdav/textfile0.txt
[Mon Mar 11 11:15:37 2019] 127.0.0.1:38340 [404]: /public.php/webdav/textfile0.txt
[Mon Mar 11 11:15:37 2019] 127.0.0.1:38342 [200]: //status.php
[Mon Mar 11 11:15:37 2019] 127.0.0.1:38344 [200]: //status.php
[Mon Mar 11 11:15:37 2019] 127.0.0.1:38346 [200]: /index.php/apps/files_sharing/shareinfo?t=g7xFK3MpQ8ZBI8x
[Mon Mar 11 11:15:37 2019] Undefined index: size at /drone/src/github.com/nextcloud/server/lib/private/Files/View.php#1324
[Mon Mar 11 11:15:37 2019] Undefined index: storage_mtime at /drone/src/github.com/nextcloud/server/lib/private/Files/Cache/Watcher.php#126
[Mon Mar 11 11:15:37 2019] 127.0.0.1:38348 [207]: /public.php/webdav/
[Mon Mar 11 11:15:37 2019] Undefined index: etag at /drone/src/github.com/nextcloud/server/lib/private/Files/Storage/DAV.php#784
[Mon Mar 11 11:15:37 2019] 127.0.0.1:38392 [200]: //status.php
[Mon Mar 11 11:15:37 2019] 127.0.0.1:38394 [200]: //status.php
[Mon Mar 11 11:15:37 2019] 127.0.0.1:38396 [200]: /index.php/apps/files_sharing/shareinfo?t=g7xFK3MpQ8ZBI8x
[Mon Mar 11 11:15:37 2019] Undefined index: mimetype at /drone/src/github.com/nextcloud/server/lib/private/Files/Cache/Watcher.php#108
[Mon Mar 11 11:15:37 2019] 127.0.0.1:43684 [404]: /remote.php/webdav/PARENT%20(2)/textfile0.txt
    When User "user1" uploads file "../../data/user1/files/textfile0.txt" to "/PARENT (2)/textfile0.txt" # FederationContext::userUploadsAFileTo()
      Client error: `PUT http://localhost:8180/remote.php/webdav/PARENT%20(2)/textfile0.txt` resulted in a `404 Not Found` response:
      <?xml version="1.0" encoding="utf-8"?>
      <d:error xmlns:d="DAV:" xmlns:s="http://sabredav.org/ns">
        <s:exception>Sabre\DA (truncated...)
       (GuzzleHttp\Exception\ClientException)
    And Downloading file "/PARENT (2)/textfile0.txt" with range "bytes=0-8"                              # FederationContext::downloadFileWithRange()
    Then Downloaded content should be "BLABLABLA"                                                        # FederationContext::downloadedContentShouldBe()
[Mon Mar 11 11:15:46 2019] 127.0.0.1:38428 [200]: /ocs/v1.php/cloud/users/user0
[Mon Mar 11 11:15:47 2019] 127.0.0.1:39160 [404]: /ocs/v2.php/cloud/users/user0
[Mon Mar 11 11:15:59 2019] 127.0.0.1:39670 [200]: //ocm-provider/
[Mon Mar 11 11:15:59 2019] 127.0.0.1:39672 [400]: /index.php/ocm/notifications
[Mon Mar 11 11:15:59 2019] error while sending notification for federated share: Client error: `POST http://localhost:8080/index.php/ocm/notifications` resulted in a `400 Bad request` response:
{"message":"Can not find share with ID: 10"}

[Mon Mar 11 11:16:13 2019] 127.0.0.1:40292 [200]: /ocs/v1.php/apps/testing/api/v1/app/files_sharing/incoming_server2server_group_share_enabled
[Mon Mar 11 11:16:14 2019] 127.0.0.1:40346 [200]: /ocs/v1.php/apps/testing/api/v1/app/files_sharing/outgoing_server2server_group_share_enabled
  Scenario: Overwrite a federated shared file as recipient using old chunking                           # /drone/src/github.com/nextcloud/server/build/integration/federation_features/federated.feature:247
    Given Using server "REMOTE"                                                                         # FederationContext::usingServer()
[Mon Mar 11 11:16:15 2019] 127.0.0.1:45758 [404]: /ocs/v2.php/cloud/users/user1
[Mon Mar 11 11:16:18 2019] 127.0.0.1:45792 [200]: /ocs/v1.php/cloud/users
[Mon Mar 11 11:16:42 2019] 127.0.0.1:45892 [200]: /ocs/v1.php/cloud/users/user1
[Mon Mar 11 11:16:42 2019] 127.0.0.1:46592 [200]: /ocs/v2.php/cloud/users/user1
    And user "user1" exists                                                                             # FederationContext::assureUserExists()
[Mon Mar 11 11:16:43 2019] 127.0.0.1:46624 [404]: /ocs/v2.php/cloud/users/user2
[Mon Mar 11 11:16:46 2019] 127.0.0.1:46646 [200]: /ocs/v1.php/cloud/users
[Mon Mar 11 11:17:06 2019] 127.0.0.1:46710 [200]: /ocs/v1.php/cloud/users/user2
[Mon Mar 11 11:17:07 2019] 127.0.0.1:48018 [200]: /ocs/v2.php/cloud/users/user2
    And user "user2" exists                                                                             # FederationContext::assureUserExists()
    And Using server "LOCAL"                                                                            # FederationContext::usingServer()
[Mon Mar 11 11:17:08 2019] 127.0.0.1:42672 [404]: /ocs/v2.php/cloud/users/user0
[Mon Mar 11 11:17:11 2019] 127.0.0.1:42704 [200]: /ocs/v1.php/cloud/users
[Mon Mar 11 11:17:22 2019] 127.0.0.1:42786 [200]: /ocs/v1.php/cloud/users/user0
[Mon Mar 11 11:17:23 2019] 127.0.0.1:43400 [200]: /ocs/v2.php/cloud/users/user0
    And user "user0" exists                                                                             # FederationContext::assureUserExists()
[Mon Mar 11 11:17:24 2019] 127.0.0.1:48928 [200]: /ocm-provider/
[Mon Mar 11 11:17:25 2019] 127.0.0.1:48930 [201]: /index.php/ocm/shares
[Mon Mar 11 11:17:26 2019] 127.0.0.1:43468 [200]: /ocs/v1.php/apps/files_sharing/api/v1/shares
    And User "user0" from server "LOCAL" shares "/textfile0.txt" with user "user1" from server "REMOTE" # FederationContext::federateSharing()
[Mon Mar 11 11:17:26 2019] 127.0.0.1:49026 [200]: /ocs/v1.php/apps/files_sharing/api/v1/remote_shares/pending
[Mon Mar 11 11:17:27 2019] 127.0.0.1:43690 [200]: //ocm-provider/
[Mon Mar 11 11:17:27 2019] 127.0.0.1:43692 [201]: /index.php/ocm/notifications
[Mon Mar 11 11:17:27 2019] 127.0.0.1:43696 [200]: //ocs-provider/
[Mon Mar 11 11:17:27 2019] 127.0.0.1:43702 [200]: /ocs/v2.php/cloud/shares/11/accept?format=json
[Mon Mar 11 11:17:27 2019] 127.0.0.1:49056 [200]: /ocs/v1.php/apps/files_sharing/api/v1/remote_shares/pending/12
    And User "user1" from server "REMOTE" accepts last pending share                                    # FederationContext::acceptLastPendingShare()
    And Using server "REMOTE"                                                                           # FederationContext::usingServer()
    And As an "user1"                                                                                   # FederationContext::asAn()
[Mon Mar 11 11:17:28 2019] 127.0.0.1:43752 [200]: //ocs-provider/
[Mon Mar 11 11:17:28 2019] 127.0.0.1:43776 [401]: /public.php/webdav/
[Mon Mar 11 11:17:28 2019] 127.0.0.1:43778 [207]: /public.php/webdav/
[Mon Mar 11 11:17:28 2019] 127.0.0.1:43868 [200]: //status.php
[Mon Mar 11 11:17:28 2019] 127.0.0.1:43872 [200]: //status.php
[Mon Mar 11 11:17:28 2019] 127.0.0.1:43876 [200]: /index.php/apps/files_sharing/shareinfo?t=nkFWLfKKXGg6erV
[Mon Mar 11 11:17:28 2019] 127.0.0.1:49094 [404]: /remote.php/webdav/textfile0%20(2).txt-chunking-42-3-0
    And user "user1" uploads chunk file "1" of "3" with "AAAAA" to "/textfile0 (2).txt"                 # FederationContext::userUploadsChunkFileOfWithToWithChecksum()
      Client error: `PUT http://localhost:8180/remote.php/webdav/textfile0%20(2).txt-chunking-42-3-0` resulted in a `404 Not Found` response:
      <?xml version="1.0" encoding="utf-8"?>
      <d:error xmlns:d="DAV:" xmlns:s="http://sabredav.org/ns">
        <s:exception>Sabre\DA (truncated...)
       (GuzzleHttp\Exception\ClientException)
    And user "user1" uploads chunk file "2" of "3" with "BBBBB" to "/textfile0 (2).txt"                 # FederationContext::userUploadsChunkFileOfWithToWithChecksum()
    And user "user1" uploads chunk file "3" of "3" with "CCCCC" to "/textfile0 (2).txt"                 # FederationContext::userUploadsChunkFileOfWithToWithChecksum()
    When Downloading file "/textfile0 (2).txt" with range "bytes=0-4"                                   # FederationContext::downloadFileWithRange()
    Then Downloaded content should be "AAAAA"                                                           # FederationContext::downloadedContentShouldBe()
[Mon Mar 11 11:17:35 2019] 127.0.0.1:43894 [200]: /ocs/v1.php/cloud/users/user0
[Mon Mar 11 11:17:35 2019] 127.0.0.1:44464 [404]: /ocs/v2.php/cloud/users/user0
[Mon Mar 11 11:17:45 2019] 127.0.0.1:45216 [200]: //ocm-provider/
[Mon Mar 11 11:17:45 2019] 127.0.0.1:45220 [400]: /index.php/ocm/notifications
[Mon Mar 11 11:17:45 2019] error while sending notification for federated share: Client error: `POST http://localhost:8080/index.php/ocm/notifications` resulted in a `400 Bad request` response:
{"message":"Can not find share with ID: 11"}

[Mon Mar 11 11:17:58 2019] 127.0.0.1:46034 [200]: /ocs/v1.php/apps/testing/api/v1/app/files_sharing/incoming_server2server_group_share_enabled
[Mon Mar 11 11:17:58 2019] 127.0.0.1:46082 [200]: /ocs/v1.php/apps/testing/api/v1/app/files_sharing/outgoing_server2server_group_share_enabled
  Scenario: Overwrite a federated shared folder as recipient using old chunking                  # /drone/src/github.com/nextcloud/server/build/integration/federation_features/federated.feature:263
    Given Using server "REMOTE"                                                                  # FederationContext::usingServer()
[Mon Mar 11 11:17:59 2019] 127.0.0.1:51490 [404]: /ocs/v2.php/cloud/users/user1
[Mon Mar 11 11:18:02 2019] 127.0.0.1:51510 [200]: /ocs/v1.php/cloud/users
[Mon Mar 11 11:18:27 2019] 127.0.0.1:51594 [200]: /ocs/v1.php/cloud/users/user1
[Mon Mar 11 11:18:28 2019] 127.0.0.1:52356 [200]: /ocs/v2.php/cloud/users/user1
    And user "user1" exists                                                                      # FederationContext::assureUserExists()
[Mon Mar 11 11:18:29 2019] 127.0.0.1:52386 [404]: /ocs/v2.php/cloud/users/user2
[Mon Mar 11 11:18:31 2019] 127.0.0.1:52408 [200]: /ocs/v1.php/cloud/users
[Mon Mar 11 11:18:59 2019] 127.0.0.1:52508 [200]: /ocs/v1.php/cloud/users/user2
[Mon Mar 11 11:19:00 2019] 127.0.0.1:54282 [200]: /ocs/v2.php/cloud/users/user2
    And user "user2" exists                                                                      # FederationContext::assureUserExists()
    And Using server "LOCAL"                                                                     # FederationContext::usingServer()
[Mon Mar 11 11:19:01 2019] 127.0.0.1:48978 [404]: /ocs/v2.php/cloud/users/user0
[Mon Mar 11 11:19:03 2019] 127.0.0.1:49012 [200]: /ocs/v1.php/cloud/users
[Mon Mar 11 11:19:22 2019] 127.0.0.1:49190 [200]: /ocs/v1.php/cloud/users/user0
[Mon Mar 11 11:19:22 2019] 127.0.0.1:50554 [200]: /ocs/v2.php/cloud/users/user0
    And user "user0" exists                                                                      # FederationContext::assureUserExists()
[Mon Mar 11 11:19:24 2019] 127.0.0.1:56148 [200]: /ocm-provider/
[Mon Mar 11 11:19:24 2019] 127.0.0.1:56150 [201]: /index.php/ocm/shares
[Mon Mar 11 11:19:24 2019] 127.0.0.1:50598 [200]: /ocs/v1.php/apps/files_sharing/api/v1/shares
    And User "user0" from server "LOCAL" shares "/PARENT" with user "user1" from server "REMOTE" # FederationContext::federateSharing()
[Mon Mar 11 11:19:25 2019] 127.0.0.1:56178 [200]: /ocs/v1.php/apps/files_sharing/api/v1/remote_shares/pending
[Mon Mar 11 11:19:26 2019] 127.0.0.1:51070 [200]: //ocm-provider/
[Mon Mar 11 11:19:26 2019] 127.0.0.1:51074 [201]: /index.php/ocm/notifications
[Mon Mar 11 11:19:26 2019] 127.0.0.1:51076 [200]: //ocs-provider/
[Mon Mar 11 11:19:26 2019] 127.0.0.1:51078 [200]: /ocs/v2.php/cloud/shares/12/accept?format=json
[Mon Mar 11 11:19:26 2019] 127.0.0.1:56238 [200]: /ocs/v1.php/apps/files_sharing/api/v1/remote_shares/pending/13
    And User "user1" from server "REMOTE" accepts last pending share                             # FederationContext::acceptLastPendingShare()
    And Using server "REMOTE"                                                                    # FederationContext::usingServer()
    And As an "user1"                                                                            # FederationContext::asAn()
[Mon Mar 11 11:19:27 2019] 127.0.0.1:51152 [200]: //ocs-provider/
[Mon Mar 11 11:19:28 2019] 127.0.0.1:51162 [200]: //status.php
[Mon Mar 11 11:19:28 2019] 127.0.0.1:51164 [200]: //status.php
[Mon Mar 11 11:19:28 2019] 127.0.0.1:51168 [200]: /index.php/apps/files_sharing/shareinfo?t=ua1tnFvvW6y9SQt
[Mon Mar 11 11:19:28 2019] Undefined index: size at /drone/src/github.com/nextcloud/server/lib/private/Files/View.php#1324
[Mon Mar 11 11:19:28 2019] Undefined index: storage_mtime at /drone/src/github.com/nextcloud/server/lib/private/Files/Cache/Watcher.php#126
[Mon Mar 11 11:19:28 2019] 127.0.0.1:51176 [401]: /public.php/webdav/
[Mon Mar 11 11:19:28 2019] 127.0.0.1:51180 [207]: /public.php/webdav/
[Mon Mar 11 11:19:28 2019] Undefined index: etag at /drone/src/github.com/nextcloud/server/lib/private/Files/Storage/DAV.php#784
[Mon Mar 11 11:19:28 2019] 127.0.0.1:51206 [200]: //status.php
[Mon Mar 11 11:19:28 2019] 127.0.0.1:51208 [200]: //status.php
[Mon Mar 11 11:19:28 2019] 127.0.0.1:51210 [200]: /index.php/apps/files_sharing/shareinfo?t=ua1tnFvvW6y9SQt
[Mon Mar 11 11:19:28 2019] Undefined index: mimetype at /drone/src/github.com/nextcloud/server/lib/private/Files/Cache/Watcher.php#108
[Mon Mar 11 11:19:28 2019] 127.0.0.1:56470 [404]: /remote.php/webdav/PARENT%20(2)/textfile0.txt-chunking-42-3-0
    And user "user1" uploads chunk file "1" of "3" with "AAAAA" to "/PARENT (2)/textfile0.txt"   # FederationContext::userUploadsChunkFileOfWithToWithChecksum()
      Client error: `PUT http://localhost:8180/remote.php/webdav/PARENT%20(2)/textfile0.txt-chunking-42-3-0` resulted in a `404 Not Found` response:
      <?xml version="1.0" encoding="utf-8"?>
      <d:error xmlns:d="DAV:" xmlns:s="http://sabredav.org/ns">
        <s:exception>Sabre\DA (truncated...)
       (GuzzleHttp\Exception\ClientException)
    And user "user1" uploads chunk file "2" of "3" with "BBBBB" to "/PARENT (2)/textfile0.txt"   # FederationContext::userUploadsChunkFileOfWithToWithChecksum()
    And user "user1" uploads chunk file "3" of "3" with "CCCCC" to "/PARENT (2)/textfile0.txt"   # FederationContext::userUploadsChunkFileOfWithToWithChecksum()
    When Downloading file "/PARENT (2)/textfile0.txt" with range "bytes=3-13"                    # FederationContext::downloadFileWithRange()
    Then Downloaded content should be "AABBBBBCCCC"                                              # FederationContext::downloadedContentShouldBe()
[Mon Mar 11 11:19:42 2019] 127.0.0.1:51284 [200]: /ocs/v1.php/cloud/users/user0
[Mon Mar 11 11:19:43 2019] 127.0.0.1:52096 [404]: /ocs/v2.php/cloud/users/user0
[Mon Mar 11 11:19:56 2019] 127.0.0.1:52830 [200]: //ocm-provider/
[Mon Mar 11 11:19:56 2019] 127.0.0.1:52834 [400]: /index.php/ocm/notifications
[Mon Mar 11 11:19:56 2019] error while sending notification for federated share: Client error: `POST http://localhost:8080/index.php/ocm/notifications` resulted in a `400 Bad request` response:
{"message":"Can not find share with ID: 12"}

TESTS=integration-sharing-v1

  • build/integration/features/sharing-v1.feature:58
Show full log 
  Scenario: Creating a new public share                    # /drone/src/github.com/nextcloud/server/build/integration/features/sharing-v1.feature:58
[Mon Mar 11 11:02:37 2019] 127.0.0.1:54850 [404]: /ocs/v2.php/cloud/users/user0
[Mon Mar 11 11:02:37 2019] 127.0.0.1:54864 [200]: /ocs/v1.php/cloud/users
[Mon Mar 11 11:02:37 2019] 127.0.0.1:54886 [200]: /ocs/v1.php/cloud/users/user0
[Mon Mar 11 11:02:37 2019] 127.0.0.1:54916 [200]: /ocs/v2.php/cloud/users/user0
    Given user "user0" exists                              # FeatureContext::assureUserExists()
    And As an "user0"                                      # FeatureContext::asAn()
[Mon Mar 11 11:02:38 2019] 127.0.0.1:54932 [200]: /ocs/v1.php/apps/files_sharing/api/v1/shares
    When creating a share with                             # FeatureContext::creatingShare()
      | path      | welcome.txt |
      | shareType | 3           |
    Then the OCS status code should be "100"               # FeatureContext::theOCSStatusCodeShouldBe()
    And the HTTP status code should be "200"               # FeatureContext::theHTTPStatusCodeShouldBe()
[Mon Mar 11 11:02:39 2019] 127.0.0.1:54946 [404]: /index.php/s/ie3KrfyHxnCY9cR/download
    And Public shared file "welcome.txt" can be downloaded # FeatureContext::checkPublicSharedFile()
      Client error: `GET http://localhost:8080/index.php/s/ie3KrfyHxnCY9cR/download` resulted in a `404 Not Found` response (GuzzleHttp\Exception\ClientException)
[Mon Mar 11 11:02:40 2019] 127.0.0.1:55156 [200]: /ocs/v1.php/cloud/users/user0
[Mon Mar 11 11:02:40 2019] 127.0.0.1:55208 [404]: /ocs/v2.php/cloud/users/user0
[Mon Mar 11 11:02:40 2019] Login failed: 'user0' (Remote IP: '127.0.0.1')
[Mon Mar 11 11:02:40 2019] 127.0.0.1:55220 [401]: /remote.php/webdav/myFileToComment.txt
[Mon Mar 11 11:02:40 2019] 127.0.0.1:55226 [207]: /remote.php/dav/systemtags/
[Mon Mar 11 11:02:40 2019] Login failed: 'user0' (Remote IP: '127.0.0.1')
[Mon Mar 11 11:02:40 2019] 127.0.0.1:55240 [401]: /remote.php/webdav/myFileToTag.txt
[Mon Mar 11 11:02:40 2019] 127.0.0.1:55242 [404]: /remote.php/dav/addressbooks/users/admin/MyAddressbook
[Mon Mar 11 11:02:40 2019] 127.0.0.1:55252 [404]: /remote.php/dav/calendars/admin/MyCalendar

TESTS=acceptance, TESTS-ACCEPTANCE=app-comments

  • tests/acceptance/features/app-comments.feature:10
Show full log 
  Scenario: open the comments for a different file           # /drone/src/github.com/nextcloud/server/tests/acceptance/features/app-comments.feature:10
    Given I am logged in                                     # LoginPageContext::iAmLoggedIn()
    And I create a new folder named "Folder"                 # FileListContext::iCreateANewFolderNamed()
    And I open the details view for "welcome.txt"            # FileListContext::iOpenTheDetailsViewFor()
    And I open the "Comments" tab in the details view        # FilesAppContext::iOpenTheTabInTheDetailsView()
    And I create a new comment with "Hello world" as message # CommentsAppContext::iCreateANewCommentWithAsMessage()
    And I see a comment with "Hello world" as message        # CommentsAppContext::iSeeACommentWithAsMessage()
      Comment with text "Hello world" in details view in Files app could not be found after 100 seconds (NoSuchElementException)
    When I open the details view for "Folder"                # FileListContext::iOpenTheDetailsViewFor()

TESTS=acceptance, TESTS-ACCEPTANCE=app-files-sharing-link

  • tests/acceptance/features/app-files-sharing-link.feature:3
  • tests/acceptance/features/app-files-sharing-link.feature:26
  • tests/acceptance/features/app-files-sharing-link.feature:40
  • tests/acceptance/features/app-files-sharing-link.feature:60
  • tests/acceptance/features/app-files-sharing-link.feature:81
  • tests/acceptance/features/app-files-sharing-link.feature:116
  • tests/acceptance/features/app-files-sharing-link.feature:128
  • tests/acceptance/features/app-files-sharing-link.feature:139
Show full log 
  Scenario: open the menu in a public shared link                   # /drone/src/github.com/nextcloud/server/tests/acceptance/features/app-files-sharing-link.feature:3
    Given I act as John                                             # ActorContext::iActAs()
    And I am logged in                                              # LoginPageContext::iAmLoggedIn()
    And I share the link for "welcome.txt"                          # FilesAppSharingContext::iShareTheLinkFor()
    And I write down the shared link                                # FilesAppSharingContext::iWriteDownTheSharedLink()
    When I act as Jane                                              # ActorContext::iActAs()
    And I visit the shared link I wrote down                        # PublicShareContext::iVisitTheSharedLinkIWroteDown()
    And I see that the current page is the shared link I wrote down # PublicShareContext::iSeeThatTheCurrentPageIsTheSharedLinkIWroteDown()
    And I open the Share menu                                       # PublicShareContext::iOpenTheShareMenu()
      Share menu button in Shared file page could not be found after 100 seconds (NoSuchElementException)
    Then I see that the Share menu is shown                         # PublicShareContext::iSeeThatTheShareMenuIsShown()

  Scenario: show download again in a public shared link             # /drone/src/github.com/nextcloud/server/tests/acceptance/features/app-files-sharing-link.feature:26
    Given I act as John                                             # ActorContext::iActAs()
    And I am logged in                                              # LoginPageContext::iAmLoggedIn()
    And I share the link for "welcome.txt"                          # FilesAppSharingContext::iShareTheLinkFor()
    And I set the download of the shared link as hidden             # FilesAppSharingContext::iSetTheDownloadOfTheSharedLinkAsHidden()
    And I set the download of the shared link as shown              # FilesAppSharingContext::iSetTheDownloadOfTheSharedLinkAsShown()
    And I write down the shared link                                # FilesAppSharingContext::iWriteDownTheSharedLink()
    When I act as Jane                                              # ActorContext::iActAs()
    And I visit the shared link I wrote down                        # PublicShareContext::iVisitTheSharedLinkIWroteDown()
    And I see that the current page is the shared link I wrote down # PublicShareContext::iSeeThatTheCurrentPageIsTheSharedLinkIWroteDown()
    Then I see that the download button is shown                    # PublicShareContext::iSeeThatTheDownloadButtonIsShown()
      The download button is not visible yet after 100 seconds
    And I open the Share menu                                       # PublicShareContext::iOpenTheShareMenu()
    And I see that the Share menu is shown                          # PublicShareContext::iSeeThatTheShareMenuIsShown()

  Scenario: creation is not possible by default in a public shared folder # /drone/src/github.com/nextcloud/server/tests/acceptance/features/app-files-sharing-link.feature:40
    Given I act as John                                                   # ActorContext::iActAs()
    And I am logged in                                                    # LoginPageContext::iAmLoggedIn()
    And I create a new folder named "Shared folder"                       # FileListContext::iCreateANewFolderNamed()
    And I close the details view                                          # FilesAppContext::iCloseTheDetailsView()
    And I see that the details view is closed                             # FilesAppContext::iSeeThatTheDetailsViewIsClosed()
    And I share the link for "Shared folder"                              # FilesAppSharingContext::iShareTheLinkFor()
    And I write down the shared link                                      # FilesAppSharingContext::iWriteDownTheSharedLink()
    When I act as Jane                                                    # ActorContext::iActAs()
    And I visit the shared link I wrote down                              # PublicShareContext::iVisitTheSharedLinkIWroteDown()
    And I see that the current page is the shared link I wrote down       # PublicShareContext::iSeeThatTheCurrentPageIsTheSharedLinkIWroteDown()
    And I see that the file list is eventually loaded                     # FileListContext::iSeeThatTheFileListIsEventuallyLoaded()
    Then I see that it is not possible to create new files                # FileListContext::iSeeThatItIsNotPossibleToCreateNewFiles()
      Create menu button in file list could not be found (NoSuchElementException)

  Scenario: create folder in a public editable shared folder        # /drone/src/github.com/nextcloud/server/tests/acceptance/features/app-files-sharing-link.feature:60
    Given I act as John                                             # ActorContext::iActAs()
    And I am logged in                                              # LoginPageContext::iAmLoggedIn()
    And I create a new folder named "Editable shared folder"        # FileListContext::iCreateANewFolderNamed()
    And I close the details view                                    # FilesAppContext::iCloseTheDetailsView()
    And I see that the details view is closed                       # FilesAppContext::iSeeThatTheDetailsViewIsClosed()
    And I share the link for "Editable shared folder"               # FilesAppSharingContext::iShareTheLinkFor()
    And I set the shared link as editable                           # FilesAppSharingContext::iSetTheSharedLinkAsEditable()
    And I write down the shared link                                # FilesAppSharingContext::iWriteDownTheSharedLink()
    When I act as Jane                                              # ActorContext::iActAs()
    And I visit the shared link I wrote down                        # PublicShareContext::iVisitTheSharedLinkIWroteDown()
    And I see that the current page is the shared link I wrote down # PublicShareContext::iSeeThatTheCurrentPageIsTheSharedLinkIWroteDown()
    And I create a new folder named "Subfolder"                     # FileListContext::iCreateANewFolderNamed()
      Create menu button in file list could not be found after 100 seconds (NoSuchElementException)
    Then I see that the file list contains a file named "Subfolder" # FileListContext::iSeeThatTheFileListContainsAFileNamed()

  Scenario: owner sees folder created in the public page of an editable shared folder # /drone/src/github.com/nextcloud/server/tests/acceptance/features/app-files-sharing-link.feature:81
    Given I act as John                                                               # ActorContext::iActAs()
    And I am logged in                                                                # LoginPageContext::iAmLoggedIn()
    And I create a new folder named "Editable shared folder"                          # FileListContext::iCreateANewFolderNamed()
    And I close the details view                                                      # FilesAppContext::iCloseTheDetailsView()
    And I see that the details view is closed                                         # FilesAppContext::iSeeThatTheDetailsViewIsClosed()
    And I share the link for "Editable shared folder"                                 # FilesAppSharingContext::iShareTheLinkFor()
    And I set the shared link as editable                                             # FilesAppSharingContext::iSetTheSharedLinkAsEditable()
    And I write down the shared link                                                  # FilesAppSharingContext::iWriteDownTheSharedLink()
    And I act as Jane                                                                 # ActorContext::iActAs()
    And I visit the shared link I wrote down                                          # PublicShareContext::iVisitTheSharedLinkIWroteDown()
    And I see that the current page is the shared link I wrote down                   # PublicShareContext::iSeeThatTheCurrentPageIsTheSharedLinkIWroteDown()
    And I create a new folder named "Subfolder"                                       # FileListContext::iCreateANewFolderNamed()
      Create menu button in file list could not be found after 100 seconds (NoSuchElementException)
    And I see that the file list contains a file named "Subfolder"                    # FileListContext::iSeeThatTheFileListContainsAFileNamed()
    When I act as John                                                                # ActorContext::iActAs()
    And I enter in the folder named "Editable shared folder"                          # FileListContext::iEnterInTheFolderNamed()
    Then I see that the file list contains a file named "Subfolder"                   # FileListContext::iSeeThatTheFileListContainsAFileNamed()

  Scenario: access a shared link protected by password with a valid password                   # /drone/src/github.com/nextcloud/server/tests/acceptance/features/app-files-sharing-link.feature:116
    Given I act as John                                                                        # ActorContext::iActAs()
    And I am logged in                                                                         # LoginPageContext::iAmLoggedIn()
    And I share the link for "welcome.txt" protected by the password "abcdef"                  # FilesAppSharingContext::iShareTheLinkForProtectedByThePassword()
    And I write down the shared link                                                           # FilesAppSharingContext::iWriteDownTheSharedLink()
    When I act as Jane                                                                         # ActorContext::iActAs()
    And I visit the shared link I wrote down                                                   # PublicShareContext::iVisitTheSharedLinkIWroteDown()
    And I see that the current page is the Authenticate page for the shared link I wrote down  # PublicShareContext::iSeeThatTheCurrentPageIsTheAuthenticatePageForTheSharedLinkIWroteDown()
      Failed asserting that two strings are equal.
      --- Expected
      +++ Actual
      @@ @@
      -'http://acceptance-app-files-sharing-link/index.php/s/XWfXYjfGBjYLxoM/authenticate/showShare'
      +'http://acceptance-app-files-sharing-link/index.php/s/XWfXYjfGBjYLxoM'
    And I authenticate with password "abcdef"                                                  # PublicShareContext::iAuthenticateWithPassword()
    Then I see that the current page is the shared link I wrote down                           # PublicShareContext::iSeeThatTheCurrentPageIsTheSharedLinkIWroteDown()
    And I see that the shared file preview shows the text "Welcome to your Nextcloud account!" # PublicShareContext::iSeeThatTheSharedFilePreviewShowsTheText()

  Scenario: access a shared link protected by password with an invalid password                # /drone/src/github.com/nextcloud/server/tests/acceptance/features/app-files-sharing-link.feature:128
    Given I act as John                                                                        # ActorContext::iActAs()
    And I am logged in                                                                         # LoginPageContext::iAmLoggedIn()
    And I share the link for "welcome.txt" protected by the password "abcdef"                  # FilesAppSharingContext::iShareTheLinkForProtectedByThePassword()
    And I write down the shared link                                                           # FilesAppSharingContext::iWriteDownTheSharedLink()
    When I act as Jane                                                                         # ActorContext::iActAs()
    And I visit the shared link I wrote down                                                   # PublicShareContext::iVisitTheSharedLinkIWroteDown()
    And I authenticate with password "fedcba"                                                  # PublicShareContext::iAuthenticateWithPassword()
      Password field in Authenticate page could not be found after 100 seconds (NoSuchElementException)
    Then I see that the current page is the Authenticate page for the shared link I wrote down # PublicShareContext::iSeeThatTheCurrentPageIsTheAuthenticatePageForTheSharedLinkIWroteDown()
    And I see that a wrong password for the shared file message is shown                       # PublicShareContext::iSeeThatAWrongPasswordForTheSharedFileMessageIsShown()

  Scenario: access a direct download shared link protected by password with a valid password                  # /drone/src/github.com/nextcloud/server/tests/acceptance/features/app-files-sharing-link.feature:139
    Given I act as John                                                                                       # ActorContext::iActAs()
    And I am logged in                                                                                        # LoginPageContext::iAmLoggedIn()
    And I share the link for "welcome.txt" protected by the password "abcdef"                                 # FilesAppSharingContext::iShareTheLinkForProtectedByThePassword()
    And I write down the shared link                                                                          # FilesAppSharingContext::iWriteDownTheSharedLink()
    When I act as Jane                                                                                        # ActorContext::iActAs()
    And I visit the direct download shared link I wrote down                                                  # PublicShareContext::iVisitTheDirectDownloadSharedLinkIWroteDown()
    And I see that the current page is the Authenticate page for the direct download shared link I wrote down # PublicShareContext::iSeeThatTheCurrentPageIsTheAuthenticatePageForTheDirectDownloadSharedLinkIWroteDown()
      Failed asserting that two strings are equal.
      --- Expected
      +++ Actual
      @@ @@
      -'http://acceptance-app-files-sharing-link/index.php/s/D4XpxJE9gx8JGBQ/authenticate/downloadShare'
      +'http://acceptance-app-files-sharing-link/index.php/s/D4XpxJE9gx8JGBQ/download'
    And I authenticate with password "abcdef"                                                                 # PublicShareContext::iAuthenticateWithPassword()
    And I see that the current page is the Authenticate page for the direct download shared link I wrote down # PublicShareContext::iSeeThatTheCurrentPageIsTheAuthenticatePageForTheDirectDownloadSharedLinkIWroteDown()

@nickvergessen nickvergessen added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Mar 11, 2019
@MorrisJobke MorrisJobke merged commit 1832537 into master Mar 11, 2019
@MorrisJobke MorrisJobke deleted the fix/noid/login-page-wrong-password branch March 11, 2019 11:49
@MorrisJobke MorrisJobke mentioned this pull request Mar 20, 2019
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzer rullzer rullzer approved these changes

@nickvergessen nickvergessen nickvergessen approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@kesselb kesselb Awaiting requested review from kesselb

Assignees

No one assigned

Labels

4. to release Ready to be released and/or waiting for tests to finish bug

Projects

None yet

Milestone

Nextcloud 16

Development

Successfully merging this pull request may close these issues.

5 participants

@MorrisJobke @rullzer @nickvergessen @skjnldsv