Skip to content

fix database select styling in setup page #14643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rullzer merged 3 commits into from
Mar 15, 2019
Merged

fix database select styling in setup page #14643

rullzer merged 3 commits into from
Mar 15, 2019

Conversation

@icewind1991
Copy link
Member

@icewind1991 icewind1991 commented Mar 12, 2019 •
edited by jancborchardt
Loading

result

@icewind1991 icewind1991 added the 3. to review Waiting for reviews label Mar 12, 2019
@icewind1991 icewind1991 added this to the Nextcloud 16 milestone Mar 12, 2019
@icewind1991 icewind1991 mentioned this pull request Mar 12, 2019
Closed
62 tasks
@icewind1991
remove dangling space
ed0e3d3 
Signed-off-by: Robin Appelman <[email protected]>
@icewind1991
Copy link
Member Author

icewind1991 commented Mar 12, 2019

also removes a dangling space

@jancborchardt
Copy link
Member

jancborchardt commented Mar 12, 2019

Nice! Can we also get rid of the visible radio circle, so it’s like it was before? The bolding and darker background & text is already sufficient. :)

@skjnldsv
Copy link
Member

skjnldsv commented Mar 15, 2019

Done
Capture d’écran_2019-03-15_12-02-58

@faily-bot
Copy link

faily-bot bot commented Mar 15, 2019

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 17068: failure

TESTS=integration-webdav-related

  • git clone failure - can typically be ignored

@MorrisJobke
Copy link
Member

MorrisJobke commented Mar 15, 2019

  • on hover the text is not bold anymore causing the UI to flicker

Bildschirmfoto 2019-03-15 um 14 31 18

vs

Bildschirmfoto 2019-03-15 um 14 32 04

@skjnldsv
Removed radio and shadow on active
4965f8c 
Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
@skjnldsv skjnldsv force-pushed the setup-page-db-select branch from 0cf1120 to 4965f8c Compare March 15, 2019 14:39
@skjnldsv
Copy link
Member

skjnldsv commented Mar 15, 2019

Done @MorrisJobke

@MorrisJobke
Copy link
Member

MorrisJobke commented Mar 15, 2019

Shouldn't it be bold? But I'm fine with both ways 👍

cc @jancborchardt

MorrisJobke
MorrisJobke approved these changes Mar 15, 2019
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works 👍

@MorrisJobke MorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Mar 15, 2019
@rullzer
Copy link
Member

rullzer commented Mar 15, 2019

Lets do this. If it needs to be bold we fix it later. @jancborchardt

@rullzer rullzer merged commit 24d239d into master Mar 15, 2019
@rullzer rullzer deleted the setup-page-db-select branch March 15, 2019 17:18
@MorrisJobke
Copy link
Member

MorrisJobke commented Mar 15, 2019

I talked with Jan about it and non-bold is fine.

@MorrisJobke MorrisJobke mentioned this pull request Mar 20, 2019
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@jancborchardt jancborchardt Awaiting requested review from jancborchardt

Assignees

No one assigned

Labels

4. to release Ready to be released and/or waiting for tests to finish design Design, UI, UX, etc. feature: install and update

Projects

None yet

Milestone

Nextcloud 16

Development

Successfully merging this pull request may close these issues.

6 participants

@icewind1991 @jancborchardt @skjnldsv @MorrisJobke @rullzer