Skip to content

remove user_external example from config.sample.php #14663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rullzer merged 1 commit into from
Mar 13, 2019
Merged

remove user_external example from config.sample.php #14663

rullzer merged 1 commit into from
Mar 13, 2019

Conversation

@violoncelloCH
Copy link
Member

@violoncelloCH violoncelloCH commented Mar 13, 2019

because the APP isn't shipped any more any ways
detailed and up to date documentation of the app can found in https://github.com/nextcloud/user_external#readme

@violoncelloCH violoncelloCH added the 3. to review Waiting for reviews label Mar 13, 2019
ChristophWurst
ChristophWurst approved these changes Mar 13, 2019
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 Thanks!

@faily-bot
Copy link

faily-bot bot commented Mar 13, 2019

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 16967: failure

DB=sqlite, ENABLE_REDIS=false, PHP=7.3

Show full log 
There was 1 failure:

1) TrashbinTest::testExpireOldFiles
Failed asserting that null is identical to 'file2.txt'.

/drone/src/github.com/nextcloud/server/apps/files_trashbin/tests/TrashbinTest.php:186

--

There was 1 risky test:

1) OCA\TwoFactorBackupCodes\Tests\Db\BackupCodeMapperTest::testInsertArgonEncryptedCodes
This test did not perform any assertions

TESTS=integration-federation_features

  • build/integration/federation_features/federated.feature:183
  • build/integration/federation_features/federated.feature:232
  • build/integration/federation_features/federated.feature:247
  • build/integration/federation_features/federated.feature:263
Show full log 
[Wed Mar 13 19:00:11 2019] 127.0.0.1:52372 [200]: /ocs/v1.php/apps/testing/api/v1/app/files_sharing/incoming_server2server_group_share_enabled
[Wed Mar 13 19:00:12 2019] 127.0.0.1:52378 [200]: /ocs/v1.php/apps/testing/api/v1/app/files_sharing/outgoing_server2server_group_share_enabled
  Scenario: Reshare a federated shared file                                                             # /drone/src/github.com/nextcloud/server/build/integration/federation_features/federated.feature:183
    Given Using server "REMOTE"                                                                         # FederationContext::usingServer()
[Wed Mar 13 19:00:12 2019] 127.0.0.1:60744 [404]: /ocs/v2.php/cloud/users/user1
[Wed Mar 13 19:00:12 2019] 127.0.0.1:60748 [200]: /ocs/v1.php/cloud/users
[Wed Mar 13 19:00:12 2019] 127.0.0.1:60758 [200]: /ocs/v1.php/cloud/users/user1
[Wed Mar 13 19:00:12 2019] 127.0.0.1:60780 [200]: /ocs/v2.php/cloud/users/user1
    And user "user1" exists                                                                             # FederationContext::assureUserExists()
[Wed Mar 13 19:00:12 2019] 127.0.0.1:60786 [404]: /ocs/v2.php/cloud/users/user2
[Wed Mar 13 19:00:13 2019] 127.0.0.1:60788 [200]: /ocs/v1.php/cloud/users
[Wed Mar 13 19:00:13 2019] 127.0.0.1:60798 [200]: /ocs/v1.php/cloud/users/user2
[Wed Mar 13 19:00:13 2019] 127.0.0.1:60814 [200]: /ocs/v2.php/cloud/users/user2
    And user "user2" exists                                                                             # FederationContext::assureUserExists()
    And Using server "LOCAL"                                                                            # FederationContext::usingServer()
[Wed Mar 13 19:00:13 2019] 127.0.0.1:52456 [404]: /ocs/v2.php/cloud/users/user0
[Wed Mar 13 19:00:13 2019] 127.0.0.1:52460 [200]: /ocs/v1.php/cloud/users
[Wed Mar 13 19:00:14 2019] 127.0.0.1:52472 [200]: /ocs/v1.php/cloud/users/user0
[Wed Mar 13 19:00:14 2019] 127.0.0.1:52488 [200]: /ocs/v2.php/cloud/users/user0
    And user "user0" exists                                                                             # FederationContext::assureUserExists()
[Wed Mar 13 19:00:14 2019] 127.0.0.1:60860 [200]: /ocm-provider/
[Wed Mar 13 19:00:14 2019] 127.0.0.1:60862 [201]: /index.php/ocm/shares
[Wed Mar 13 19:00:14 2019] 127.0.0.1:52494 [200]: /ocs/v1.php/apps/files_sharing/api/v1/shares
    And User "user0" from server "LOCAL" shares "/textfile0.txt" with user "user1" from server "REMOTE" # FederationContext::federateSharing()
[Wed Mar 13 19:00:14 2019] 127.0.0.1:60866 [200]: /ocs/v1.php/apps/files_sharing/api/v1/remote_shares/pending
[Wed Mar 13 19:00:14 2019] 127.0.0.1:52510 [200]: //ocm-provider/
[Wed Mar 13 19:00:14 2019] 127.0.0.1:52512 [201]: /index.php/ocm/notifications
[Wed Mar 13 19:00:14 2019] 127.0.0.1:52514 [200]: //ocs-provider/
[Wed Mar 13 19:00:14 2019] 127.0.0.1:52516 [200]: /ocs/v2.php/cloud/shares/8/accept?format=json
[Wed Mar 13 19:00:14 2019] 127.0.0.1:60868 [200]: /ocs/v1.php/apps/files_sharing/api/v1/remote_shares/pending/9
    And User "user1" from server "REMOTE" accepts last pending share                                    # FederationContext::acceptLastPendingShare()
    And Using server "REMOTE"                                                                           # FederationContext::usingServer()
    And As an "user1"                                                                                   # FederationContext::asAn()
[Wed Mar 13 19:00:14 2019] 127.0.0.1:52524 [200]: //ocs-provider/
[Wed Mar 13 19:00:14 2019] 127.0.0.1:52528 [200]: //status.php
[Wed Mar 13 19:00:14 2019] 127.0.0.1:52530 [200]: //status.php
[Wed Mar 13 19:00:14 2019] 127.0.0.1:52532 [200]: /index.php/apps/files_sharing/shareinfo?t=1TPfsGhYZR5arrA
[Wed Mar 13 19:00:14 2019] 127.0.0.1:60878 [200]: /ocs/v1.php/apps/files_sharing/api/v1/shares
    When creating a share with                                                                          # FederationContext::creatingShare()
      | path        | /textfile0 (2).txt |
      | shareType   | 0                  |
      | shareWith   | user2              |
      | permissions | 19                 |
    Then the OCS status code should be "100"                                                            # FederationContext::theOCSStatusCodeShouldBe()
      Failed asserting that SimpleXMLElement Object &000000005fc25eb8000000001fa976d0 (
          0 => '404'
      ) matches expected '100'.
    And the HTTP status code should be "200"                                                            # FederationContext::theHTTPStatusCodeShouldBe()
    And Share fields of last share match with                                                           # FederationContext::checkShareFields()
      | id                     | A_NUMBER           |
      | item_type              | file               |
      | item_source            | A_NUMBER           |
      | share_type             | 0                  |
      | file_source            | A_NUMBER           |
      | path                   | /textfile0 (2).txt |
      | permissions            | 19                 |
      | stime                  | A_NUMBER           |
      | storage                | A_NUMBER           |
      | mail_send              | 1                  |
      | uid_owner              | user1              |
      | file_parent            | A_NUMBER           |
      | displayname_owner      | user1              |
      | share_with             | user2              |
      | share_with_displayname | user2              |
[Wed Mar 13 19:00:15 2019] 127.0.0.1:52534 [200]: /ocs/v1.php/cloud/users/user0
[Wed Mar 13 19:00:15 2019] 127.0.0.1:52562 [404]: /ocs/v2.php/cloud/users/user0
[Wed Mar 13 19:00:16 2019] 127.0.0.1:52592 [200]: //ocm-provider/
[Wed Mar 13 19:00:16 2019] 127.0.0.1:52594 [400]: /index.php/ocm/notifications
[Wed Mar 13 19:00:16 2019] error while sending notification for federated share: Client error: `POST http://localhost:8080/index.php/ocm/notifications` resulted in a `400 Bad request` response:
{"message":"Can not find share with ID: 8"}

[Wed Mar 13 19:00:27 2019] 127.0.0.1:53440 [200]: /ocs/v1.php/apps/testing/api/v1/app/files_sharing/incoming_server2server_group_share_enabled
[Wed Mar 13 19:00:27 2019] 127.0.0.1:53454 [200]: /ocs/v1.php/apps/testing/api/v1/app/files_sharing/outgoing_server2server_group_share_enabled
  Scenario: Overwrite a federated shared folder as recipient                                             # /drone/src/github.com/nextcloud/server/build/integration/federation_features/federated.feature:232
    Given Using server "REMOTE"                                                                          # FederationContext::usingServer()
[Wed Mar 13 19:00:27 2019] 127.0.0.1:33612 [404]: /ocs/v2.php/cloud/users/user1
[Wed Mar 13 19:00:37 2019] 127.0.0.1:33628 [200]: /ocs/v1.php/cloud/users
[Wed Mar 13 19:00:41 2019] 127.0.0.1:34018 [200]: /ocs/v1.php/cloud/users/user1
[Wed Mar 13 19:00:41 2019] 127.0.0.1:34050 [200]: /ocs/v2.php/cloud/users/user1
    And user "user1" exists                                                                              # FederationContext::assureUserExists()
[Wed Mar 13 19:00:41 2019] 127.0.0.1:34052 [404]: /ocs/v2.php/cloud/users/user2
[Wed Mar 13 19:00:42 2019] 127.0.0.1:34054 [200]: /ocs/v1.php/cloud/users
[Wed Mar 13 19:00:43 2019] 127.0.0.1:34056 [200]: /ocs/v1.php/cloud/users/user2
[Wed Mar 13 19:00:43 2019] 127.0.0.1:34058 [200]: /ocs/v2.php/cloud/users/user2
    And user "user2" exists                                                                              # FederationContext::assureUserExists()
    And Using server "LOCAL"                                                                             # FederationContext::usingServer()
[Wed Mar 13 19:00:43 2019] 127.0.0.1:53932 [404]: /ocs/v2.php/cloud/users/user0
[Wed Mar 13 19:00:43 2019] 127.0.0.1:53934 [200]: /ocs/v1.php/cloud/users
[Wed Mar 13 19:00:44 2019] 127.0.0.1:53938 [200]: /ocs/v1.php/cloud/users/user0
[Wed Mar 13 19:00:44 2019] 127.0.0.1:53942 [200]: /ocs/v2.php/cloud/users/user0
    And user "user0" exists                                                                              # FederationContext::assureUserExists()
[Wed Mar 13 19:00:45 2019] 127.0.0.1:34076 [200]: /ocm-provider/
[Wed Mar 13 19:00:45 2019] 127.0.0.1:34078 [201]: /index.php/ocm/shares
[Wed Mar 13 19:00:45 2019] 127.0.0.1:53944 [200]: /ocs/v1.php/apps/files_sharing/api/v1/shares
    And User "user0" from server "LOCAL" shares "/PARENT" with user "user1" from server "REMOTE"         # FederationContext::federateSharing()
[Wed Mar 13 19:00:45 2019] 127.0.0.1:34080 [200]: /ocs/v1.php/apps/files_sharing/api/v1/remote_shares/pending
[Wed Mar 13 19:00:45 2019] 127.0.0.1:53956 [200]: //ocm-provider/
[Wed Mar 13 19:00:45 2019] 127.0.0.1:53958 [201]: /index.php/ocm/notifications
[Wed Mar 13 19:00:45 2019] 127.0.0.1:53960 [200]: //ocs-provider/
[Wed Mar 13 19:00:45 2019] 127.0.0.1:53962 [200]: /ocs/v2.php/cloud/shares/10/accept?format=json
[Wed Mar 13 19:00:45 2019] 127.0.0.1:34082 [200]: /ocs/v1.php/apps/files_sharing/api/v1/remote_shares/pending/11
    And User "user1" from server "REMOTE" accepts last pending share                                     # FederationContext::acceptLastPendingShare()
    And Using server "REMOTE"                                                                            # FederationContext::usingServer()
    And As an "user1"                                                                                    # FederationContext::asAn()
    And User "user1" modifies text of "/textfile0.txt" with text "BLABLABLA"                             # FederationContext::modifyTextOfFile()
[Wed Mar 13 19:00:46 2019] 127.0.0.1:53966 [200]: //ocs-provider/
[Wed Mar 13 19:00:46 2019] 127.0.0.1:53968 [401]: /public.php/webdav/textfile0.txt
[Wed Mar 13 19:00:46 2019] 127.0.0.1:53970 [404]: /public.php/webdav/textfile0.txt
[Wed Mar 13 19:00:46 2019] 127.0.0.1:53972 [200]: //status.php
[Wed Mar 13 19:00:46 2019] 127.0.0.1:53974 [200]: //status.php
[Wed Mar 13 19:00:46 2019] 127.0.0.1:53976 [200]: /index.php/apps/files_sharing/shareinfo?t=7riCBnQ0pmEfB29
[Wed Mar 13 19:00:46 2019] Undefined index: size at /drone/src/github.com/nextcloud/server/lib/private/Files/View.php#1324
[Wed Mar 13 19:00:46 2019] Undefined index: storage_mtime at /drone/src/github.com/nextcloud/server/lib/private/Files/Cache/Watcher.php#126
[Wed Mar 13 19:00:46 2019] 127.0.0.1:53978 [207]: /public.php/webdav/
[Wed Mar 13 19:00:46 2019] Undefined index: etag at /drone/src/github.com/nextcloud/server/lib/private/Files/Storage/DAV.php#784
[Wed Mar 13 19:00:46 2019] 127.0.0.1:53980 [200]: //status.php
[Wed Mar 13 19:00:46 2019] 127.0.0.1:53982 [200]: //status.php
[Wed Mar 13 19:00:46 2019] 127.0.0.1:53984 [200]: /index.php/apps/files_sharing/shareinfo?t=7riCBnQ0pmEfB29
[Wed Mar 13 19:00:46 2019] Undefined index: mimetype at /drone/src/github.com/nextcloud/server/lib/private/Files/Cache/Watcher.php#108
[Wed Mar 13 19:00:46 2019] 127.0.0.1:34092 [404]: /remote.php/webdav/PARENT%20(2)/textfile0.txt
    When User "user1" uploads file "../../data/user1/files/textfile0.txt" to "/PARENT (2)/textfile0.txt" # FederationContext::userUploadsAFileTo()
      Client error: `PUT http://localhost:8180/remote.php/webdav/PARENT%20(2)/textfile0.txt` resulted in a `404 Not Found` response:
      <?xml version="1.0" encoding="utf-8"?>
      <d:error xmlns:d="DAV:" xmlns:s="http://sabredav.org/ns">
        <s:exception>Sabre\DA (truncated...)
       (GuzzleHttp\Exception\ClientException)
    And Downloading file "/PARENT (2)/textfile0.txt" with range "bytes=0-8"                              # FederationContext::downloadFileWithRange()
    Then Downloaded content should be "BLABLABLA"                                                        # FederationContext::downloadedContentShouldBe()
[Wed Mar 13 19:00:46 2019] 127.0.0.1:53986 [200]: /ocs/v1.php/cloud/users/user0
[Wed Mar 13 19:00:46 2019] 127.0.0.1:53990 [404]: /ocs/v2.php/cloud/users/user0
[Wed Mar 13 19:00:47 2019] 127.0.0.1:53994 [200]: //ocm-provider/
[Wed Mar 13 19:00:47 2019] 127.0.0.1:53996 [400]: /index.php/ocm/notifications
[Wed Mar 13 19:00:47 2019] error while sending notification for federated share: Client error: `POST http://localhost:8080/index.php/ocm/notifications` resulted in a `400 Bad request` response:
{"message":"Can not find share with ID: 10"}

[Wed Mar 13 19:00:47 2019] 127.0.0.1:54010 [200]: /ocs/v1.php/apps/testing/api/v1/app/files_sharing/incoming_server2server_group_share_enabled
[Wed Mar 13 19:00:47 2019] 127.0.0.1:54012 [200]: /ocs/v1.php/apps/testing/api/v1/app/files_sharing/outgoing_server2server_group_share_enabled
  Scenario: Overwrite a federated shared file as recipient using old chunking                           # /drone/src/github.com/nextcloud/server/build/integration/federation_features/federated.feature:247
    Given Using server "REMOTE"                                                                         # FederationContext::usingServer()
[Wed Mar 13 19:00:48 2019] 127.0.0.1:34144 [404]: /ocs/v2.php/cloud/users/user1
[Wed Mar 13 19:00:48 2019] 127.0.0.1:34148 [200]: /ocs/v1.php/cloud/users
[Wed Mar 13 19:00:48 2019] 127.0.0.1:34152 [200]: /ocs/v1.php/cloud/users/user1
[Wed Mar 13 19:00:48 2019] 127.0.0.1:34158 [200]: /ocs/v2.php/cloud/users/user1
    And user "user1" exists                                                                             # FederationContext::assureUserExists()
[Wed Mar 13 19:00:48 2019] 127.0.0.1:34160 [404]: /ocs/v2.php/cloud/users/user2
[Wed Mar 13 19:00:49 2019] 127.0.0.1:34162 [200]: /ocs/v1.php/cloud/users
[Wed Mar 13 19:00:50 2019] 127.0.0.1:34166 [200]: /ocs/v1.php/cloud/users/user2
[Wed Mar 13 19:00:50 2019] 127.0.0.1:34180 [200]: /ocs/v2.php/cloud/users/user2
    And user "user2" exists                                                                             # FederationContext::assureUserExists()
    And Using server "LOCAL"                                                                            # FederationContext::usingServer()
[Wed Mar 13 19:00:50 2019] 127.0.0.1:54054 [404]: /ocs/v2.php/cloud/users/user0
[Wed Mar 13 19:00:50 2019] 127.0.0.1:54056 [200]: /ocs/v1.php/cloud/users
[Wed Mar 13 19:00:51 2019] 127.0.0.1:54064 [200]: /ocs/v1.php/cloud/users/user0
[Wed Mar 13 19:00:51 2019] 127.0.0.1:54068 [200]: /ocs/v2.php/cloud/users/user0
    And user "user0" exists                                                                             # FederationContext::assureUserExists()
[Wed Mar 13 19:00:51 2019] 127.0.0.1:34208 [200]: /ocm-provider/
[Wed Mar 13 19:00:51 2019] 127.0.0.1:34210 [201]: /index.php/ocm/shares
[Wed Mar 13 19:00:51 2019] 127.0.0.1:54076 [200]: /ocs/v1.php/apps/files_sharing/api/v1/shares
    And User "user0" from server "LOCAL" shares "/textfile0.txt" with user "user1" from server "REMOTE" # FederationContext::federateSharing()
[Wed Mar 13 19:00:51 2019] 127.0.0.1:34212 [200]: /ocs/v1.php/apps/files_sharing/api/v1/remote_shares/pending
[Wed Mar 13 19:00:51 2019] 127.0.0.1:54092 [200]: //ocm-provider/
[Wed Mar 13 19:00:51 2019] 127.0.0.1:54094 [201]: /index.php/ocm/notifications
[Wed Mar 13 19:00:51 2019] 127.0.0.1:54096 [200]: //ocs-provider/
[Wed Mar 13 19:00:51 2019] 127.0.0.1:54098 [200]: /ocs/v2.php/cloud/shares/11/accept?format=json
[Wed Mar 13 19:00:51 2019] 127.0.0.1:34214 [200]: /ocs/v1.php/apps/files_sharing/api/v1/remote_shares/pending/12
    And User "user1" from server "REMOTE" accepts last pending share                                    # FederationContext::acceptLastPendingShare()
    And Using server "REMOTE"                                                                           # FederationContext::usingServer()
    And As an "user1"                                                                                   # FederationContext::asAn()
[Wed Mar 13 19:00:51 2019] 127.0.0.1:54104 [200]: //ocs-provider/
[Wed Mar 13 19:00:51 2019] 127.0.0.1:54106 [401]: /public.php/webdav/
[Wed Mar 13 19:00:51 2019] 127.0.0.1:54108 [207]: /public.php/webdav/
[Wed Mar 13 19:00:52 2019] 127.0.0.1:54110 [200]: //status.php
[Wed Mar 13 19:00:52 2019] 127.0.0.1:54112 [200]: //status.php
[Wed Mar 13 19:00:52 2019] 127.0.0.1:54114 [200]: /index.php/apps/files_sharing/shareinfo?t=Lv3x5hgXv9Lsv1E
[Wed Mar 13 19:00:52 2019] 127.0.0.1:34230 [404]: /remote.php/webdav/textfile0%20(2).txt-chunking-42-3-0
    And user "user1" uploads chunk file "1" of "3" with "AAAAA" to "/textfile0 (2).txt"                 # FederationContext::userUploadsChunkFileOfWithToWithChecksum()
      Client error: `PUT http://localhost:8180/remote.php/webdav/textfile0%20(2).txt-chunking-42-3-0` resulted in a `404 Not Found` response:
      <?xml version="1.0" encoding="utf-8"?>
      <d:error xmlns:d="DAV:" xmlns:s="http://sabredav.org/ns">
        <s:exception>Sabre\DA (truncated...)
       (GuzzleHttp\Exception\ClientException)
    And user "user1" uploads chunk file "2" of "3" with "BBBBB" to "/textfile0 (2).txt"                 # FederationContext::userUploadsChunkFileOfWithToWithChecksum()
    And user "user1" uploads chunk file "3" of "3" with "CCCCC" to "/textfile0 (2).txt"                 # FederationContext::userUploadsChunkFileOfWithToWithChecksum()
    When Downloading file "/textfile0 (2).txt" with range "bytes=0-4"                                   # FederationContext::downloadFileWithRange()
    Then Downloaded content should be "AAAAA"                                                           # FederationContext::downloadedContentShouldBe()
[Wed Mar 13 19:00:52 2019] 127.0.0.1:54116 [200]: /ocs/v1.php/cloud/users/user0
[Wed Mar 13 19:00:52 2019] 127.0.0.1:54118 [404]: /ocs/v2.php/cloud/users/user0
[Wed Mar 13 19:00:53 2019] 127.0.0.1:54122 [200]: //ocm-provider/
[Wed Mar 13 19:00:53 2019] 127.0.0.1:54124 [400]: /index.php/ocm/notifications
[Wed Mar 13 19:00:53 2019] error while sending notification for federated share: Client error: `POST http://localhost:8080/index.php/ocm/notifications` resulted in a `400 Bad request` response:
{"message":"Can not find share with ID: 11"}

[Wed Mar 13 19:00:53 2019] 127.0.0.1:54148 [200]: /ocs/v1.php/apps/testing/api/v1/app/files_sharing/incoming_server2server_group_share_enabled
[Wed Mar 13 19:00:54 2019] 127.0.0.1:54152 [200]: /ocs/v1.php/apps/testing/api/v1/app/files_sharing/outgoing_server2server_group_share_enabled
  Scenario: Overwrite a federated shared folder as recipient using old chunking                  # /drone/src/github.com/nextcloud/server/build/integration/federation_features/federated.feature:263
    Given Using server "REMOTE"                                                                  # FederationContext::usingServer()
[Wed Mar 13 19:00:54 2019] 127.0.0.1:34288 [404]: /ocs/v2.php/cloud/users/user1
[Wed Mar 13 19:00:54 2019] 127.0.0.1:34290 [200]: /ocs/v1.php/cloud/users
[Wed Mar 13 19:00:55 2019] 127.0.0.1:34294 [200]: /ocs/v1.php/cloud/users/user1
[Wed Mar 13 19:00:55 2019] 127.0.0.1:34304 [200]: /ocs/v2.php/cloud/users/user1
    And user "user1" exists                                                                      # FederationContext::assureUserExists()
[Wed Mar 13 19:00:55 2019] 127.0.0.1:34308 [404]: /ocs/v2.php/cloud/users/user2
[Wed Mar 13 19:00:55 2019] 127.0.0.1:34310 [200]: /ocs/v1.php/cloud/users
[Wed Mar 13 19:00:56 2019] 127.0.0.1:34314 [200]: /ocs/v1.php/cloud/users/user2
[Wed Mar 13 19:00:56 2019] 127.0.0.1:34336 [200]: /ocs/v2.php/cloud/users/user2
    And user "user2" exists                                                                      # FederationContext::assureUserExists()
    And Using server "LOCAL"                                                                     # FederationContext::usingServer()
[Wed Mar 13 19:00:56 2019] 127.0.0.1:54216 [404]: /ocs/v2.php/cloud/users/user0
[Wed Mar 13 19:00:56 2019] 127.0.0.1:54222 [200]: /ocs/v1.php/cloud/users
[Wed Mar 13 19:00:57 2019] 127.0.0.1:54234 [200]: /ocs/v1.php/cloud/users/user0
[Wed Mar 13 19:00:57 2019] 127.0.0.1:54260 [200]: /ocs/v2.php/cloud/users/user0
    And user "user0" exists                                                                      # FederationContext::assureUserExists()
[Wed Mar 13 19:00:57 2019] 127.0.0.1:34406 [200]: /ocm-provider/
[Wed Mar 13 19:00:57 2019] 127.0.0.1:34410 [201]: /index.php/ocm/shares
[Wed Mar 13 19:00:57 2019] 127.0.0.1:54266 [200]: /ocs/v1.php/apps/files_sharing/api/v1/shares
    And User "user0" from server "LOCAL" shares "/PARENT" with user "user1" from server "REMOTE" # FederationContext::federateSharing()
[Wed Mar 13 19:00:57 2019] 127.0.0.1:34412 [200]: /ocs/v1.php/apps/files_sharing/api/v1/remote_shares/pending
[Wed Mar 13 19:00:57 2019] 127.0.0.1:54298 [200]: //ocm-provider/
[Wed Mar 13 19:00:57 2019] 127.0.0.1:54302 [201]: /index.php/ocm/notifications
[Wed Mar 13 19:00:57 2019] 127.0.0.1:54306 [200]: //ocs-provider/
[Wed Mar 13 19:00:57 2019] 127.0.0.1:54308 [200]: /ocs/v2.php/cloud/shares/12/accept?format=json
[Wed Mar 13 19:00:57 2019] 127.0.0.1:34418 [200]: /ocs/v1.php/apps/files_sharing/api/v1/remote_shares/pending/13
    And User "user1" from server "REMOTE" accepts last pending share                             # FederationContext::acceptLastPendingShare()
    And Using server "REMOTE"                                                                    # FederationContext::usingServer()
    And As an "user1"                                                                            # FederationContext::asAn()
[Wed Mar 13 19:00:57 2019] 127.0.0.1:54318 [200]: //ocs-provider/
[Wed Mar 13 19:00:57 2019] 127.0.0.1:54322 [200]: //status.php
[Wed Mar 13 19:00:57 2019] 127.0.0.1:54324 [200]: //status.php
[Wed Mar 13 19:00:57 2019] 127.0.0.1:54326 [200]: /index.php/apps/files_sharing/shareinfo?t=7VJd9EQKmrok5nf
[Wed Mar 13 19:00:57 2019] Undefined index: size at /drone/src/github.com/nextcloud/server/lib/private/Files/View.php#1324
[Wed Mar 13 19:00:57 2019] Undefined index: storage_mtime at /drone/src/github.com/nextcloud/server/lib/private/Files/Cache/Watcher.php#126
[Wed Mar 13 19:00:57 2019] 127.0.0.1:54330 [401]: /public.php/webdav/
[Wed Mar 13 19:00:57 2019] 127.0.0.1:54332 [207]: /public.php/webdav/
[Wed Mar 13 19:00:57 2019] Undefined index: etag at /drone/src/github.com/nextcloud/server/lib/private/Files/Storage/DAV.php#784
[Wed Mar 13 19:00:57 2019] 127.0.0.1:54340 [200]: //status.php
[Wed Mar 13 19:00:57 2019] 127.0.0.1:54342 [200]: //status.php
[Wed Mar 13 19:00:57 2019] 127.0.0.1:54346 [200]: /index.php/apps/files_sharing/shareinfo?t=7VJd9EQKmrok5nf
[Wed Mar 13 19:00:57 2019] Undefined index: mimetype at /drone/src/github.com/nextcloud/server/lib/private/Files/Cache/Watcher.php#108
[Wed Mar 13 19:00:57 2019] 127.0.0.1:34438 [404]: /remote.php/webdav/PARENT%20(2)/textfile0.txt-chunking-42-3-0
    And user "user1" uploads chunk file "1" of "3" with "AAAAA" to "/PARENT (2)/textfile0.txt"   # FederationContext::userUploadsChunkFileOfWithToWithChecksum()
      Client error: `PUT http://localhost:8180/remote.php/webdav/PARENT%20(2)/textfile0.txt-chunking-42-3-0` resulted in a `404 Not Found` response:
      <?xml version="1.0" encoding="utf-8"?>
      <d:error xmlns:d="DAV:" xmlns:s="http://sabredav.org/ns">
        <s:exception>Sabre\DA (truncated...)
       (GuzzleHttp\Exception\ClientException)
    And user "user1" uploads chunk file "2" of "3" with "BBBBB" to "/PARENT (2)/textfile0.txt"   # FederationContext::userUploadsChunkFileOfWithToWithChecksum()
    And user "user1" uploads chunk file "3" of "3" with "CCCCC" to "/PARENT (2)/textfile0.txt"   # FederationContext::userUploadsChunkFileOfWithToWithChecksum()
    When Downloading file "/PARENT (2)/textfile0.txt" with range "bytes=3-13"                    # FederationContext::downloadFileWithRange()
    Then Downloaded content should be "AABBBBBCCCC"                                              # FederationContext::downloadedContentShouldBe()
[Wed Mar 13 19:01:10 2019] 127.0.0.1:54350 [200]: /ocs/v1.php/cloud/users/user0
[Wed Mar 13 19:01:10 2019] 127.0.0.1:54590 [404]: /ocs/v2.php/cloud/users/user0
[Wed Mar 13 19:01:11 2019] 127.0.0.1:54606 [200]: //ocm-provider/
[Wed Mar 13 19:01:11 2019] 127.0.0.1:54608 [400]: /index.php/ocm/notifications
[Wed Mar 13 19:01:11 2019] error while sending notification for federated share: Client error: `POST http://localhost:8080/index.php/ocm/notifications` resulted in a `400 Bad request` response:
{"message":"Can not find share with ID: 12"}

TESTS=acceptance, TESTS-ACCEPTANCE=app-comments

  • tests/acceptance/features/app-comments.feature:10
Show full log 
  Scenario: open the comments for a different file           # /drone/src/github.com/nextcloud/server/tests/acceptance/features/app-comments.feature:10
    Given I am logged in                                     # LoginPageContext::iAmLoggedIn()
    And I create a new folder named "Folder"                 # FileListContext::iCreateANewFolderNamed()
    And I open the details view for "welcome.txt"            # FileListContext::iOpenTheDetailsViewFor()
    And I open the "Comments" tab in the details view        # FilesAppContext::iOpenTheTabInTheDetailsView()
    And I create a new comment with "Hello world" as message # CommentsAppContext::iCreateANewCommentWithAsMessage()
    And I see a comment with "Hello world" as message        # CommentsAppContext::iSeeACommentWithAsMessage()
      Comment with text "Hello world" in details view in Files app could not be found after 100 seconds (NoSuchElementException)
    When I open the details view for "Folder"                # FileListContext::iOpenTheDetailsViewFor()

TESTS=acceptance, TESTS-ACCEPTANCE=app-files

  • tests/acceptance/features/app-files.feature:144
  • tests/acceptance/features/app-files.feature:154
Show full log 
  Scenario: move a file to another folder                                     # /drone/src/github.com/nextcloud/server/tests/acceptance/features/app-files.feature:144
    Given I am logged in                                                      # LoginPageContext::iAmLoggedIn()
    And I create a new folder named "Destination"                             # FileListContext::iCreateANewFolderNamed()
    When I start the move or copy operation for "welcome.txt"                 # FileListContext::iStartTheMoveOrCopyOperationFor()
    And I select "Destination" in the file picker                             # FilePickerContext::iSelectInTheFilePicker()
      Row for file Destination in the file picker dialog could not be found after 100 seconds (NoSuchElementException)
    And I move to the last selected folder in the file picker                 # FilePickerContext::iMoveToTheLastSelectedFolderInTheFilePicker()
    Then I see that the file list does not contain a file named "welcome.txt" # FileListContext::iSeeThatTheFileListDoesNotContainAFileNamed()
    And I enter in the folder named "Destination"                             # FileListContext::iEnterInTheFolderNamed()
    And I see that the file list contains a file named "welcome.txt"          # FileListContext::iSeeThatTheFileListContainsAFileNamed()

  Scenario: move a selection to another folder                                       # /drone/src/github.com/nextcloud/server/tests/acceptance/features/app-files.feature:154
    Given I am logged in                                                             # LoginPageContext::iAmLoggedIn()
    And I create a new folder named "Folder"                                         # FileListContext::iCreateANewFolderNamed()
    And I create a new folder named "Not selected folder"                            # FileListContext::iCreateANewFolderNamed()
    And I create a new folder named "Destination"                                    # FileListContext::iCreateANewFolderNamed()
    When I select "welcome.txt"                                                      # FileListContext::iSelect()
    And I select "Folder"                                                            # FileListContext::iSelect()
    And I start the move or copy operation for the selected files                    # FileListContext::iStartTheMoveOrCopyOperationForTheSelectedFiles()
    And I select "Destination" in the file picker                                    # FilePickerContext::iSelectInTheFilePicker()
      Row for file Destination in the file picker dialog could not be found after 100 seconds (NoSuchElementException)
    And I move to the last selected folder in the file picker                        # FilePickerContext::iMoveToTheLastSelectedFolderInTheFilePicker()
    Then I see that the file list does not contain a file named "welcome.txt"        # FileListContext::iSeeThatTheFileListDoesNotContainAFileNamed()
    And I see that the file list does not contain a file named "Folder"              # FileListContext::iSeeThatTheFileListDoesNotContainAFileNamed()
    And I see that the file list contains a file named "Not selected folder"         # FileListContext::iSeeThatTheFileListContainsAFileNamed()
    And I enter in the folder named "Destination"                                    # FileListContext::iEnterInTheFolderNamed()
    And I see that the file list contains a file named "welcome.txt"                 # FileListContext::iSeeThatTheFileListContainsAFileNamed()
    And I see that the file list contains a file named "Folder"                      # FileListContext::iSeeThatTheFileListContainsAFileNamed()
    And I see that the file list does not contain a file named "Not selected folder" # FileListContext::iSeeThatTheFileListDoesNotContainAFileNamed()

@rullzer rullzer added this to the Nextcloud 16 milestone Mar 13, 2019
@rullzer rullzer merged commit ac10ff0 into master Mar 13, 2019
@rullzer rullzer deleted the remove_userExternal_example branch March 13, 2019 20:45
@MorrisJobke MorrisJobke mentioned this pull request Mar 20, 2019
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzer rullzer rullzer approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@MorrisJobke MorrisJobke Awaiting requested review from MorrisJobke

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

Assignees

No one assigned

Labels

3. to review Waiting for reviews

Projects

None yet

Milestone

Nextcloud 16

Development

Successfully merging this pull request may close these issues.

4 participants

@violoncelloCH @rullzer @ChristophWurst