Hide collaborative tag input when empty #1469
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nickvergessen, thanks for your PR! By analyzing the annotation information on this pull request, we identified @jancborchardt, @skjnldsv and @LukasReschke to be potential reviewers |
9 tasks
MorrisJobke
requested changes
Sep 20, 2016
core/img/actions/tag.svg
Outdated
| @@ -0,0 +1,5 @@ | |||
| <?xml version="1.0" encoding="UTF-8" standalone="no"?> | |||
| <svg xmlns="http://www.w3.org/2000/svg" height="16" width="16" version="1.0"> | |||
Member
There was a problem hiding this comment.
Please add viewBox="0 0 16 16" for proper scaling in Firefox ;)
MorrisJobke
approved these changes
Sep 20, 2016
Member
|
Tested and works (even if IE and Firefox) ;) 👍 |
Member
|
Two things we need to fix:
|
Member
|
LGTM, now with proper padding! @karlitschek Requesting backport since the tags field really really distracts from the Sharing input field, as confirmed by @schiessle, @oparoz and multiple others. |
Member
|
hmm. bigger change. but backport makes sense 👍 |
This was referenced Apr 14, 2021
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checkbox 1.1 from #1465
@jancborchardt @MorrisJobke
No tags
Has tags