Skip to content

[stable15] improve lookup server behaviour #14696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rullzer merged 4 commits into from
Mar 18, 2019
Merged

[stable15] improve lookup server behaviour #14696

rullzer merged 4 commits into from
Mar 18, 2019

Conversation

@backportbot-nextcloud
Copy link

@backportbot-nextcloud backportbot-nextcloud bot commented Mar 14, 2019

backport of #13401

@backportbot-nextcloud backportbot-nextcloud bot added this to the Nextcloud 15.0.6 milestone Mar 14, 2019
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Mar 14, 2019
Merged
@MorrisJobke MorrisJobke added the 3. to review Waiting for reviews label Mar 14, 2019
rullzer
rullzer approved these changes Mar 14, 2019
View reviewed changes
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@rullzer rullzer added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Mar 14, 2019
@nextcloud nextcloud deleted a comment from faily-bot bot Mar 15, 2019
@schiessle @rullzer
improve lookup server behaviour
23c57b2 
Don't try to connect to the lookup server if the lookup server was disabled
by the admin or an empty lookup server URL was given

Signed-off-by: Bjoern Schiessle <[email protected]>
@schiessle @rullzer
increase timespan between each retry
edbe99d 
Signed-off-by: Bjoern Schiessle <[email protected]>
@rullzer rullzer force-pushed the backport/13401/stable15 branch from c89cb30 to edbe99d Compare March 17, 2019 19:39
@MorrisJobke
Copy link
Member

MorrisJobke commented Mar 17, 2019 

[Sun Mar 17 19:52:15 2019] Undefined property: OCA\LookupServerConnector\UpdateLookupServer::$config at /drone/src/github.com/nextcloud/server/apps/lookup_server_connector/lib/UpdateLookupServer.php#73
[Sun Mar 17 19:52:15 2019] Error: Call to a member function getAppValue() on null at /drone/src/github.com/nextcloud/server/apps/lookup_server_connector/lib/UpdateLookupServer.php#73

🙈

@rullzer
Copy link
Member

rullzer commented Mar 18, 2019

Also applied #14519 and #14529

@faily-bot
Copy link

faily-bot bot commented Mar 18, 2019

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 17110: failure

TESTS=acceptance, TESTS-ACCEPTANCE=app-comments

  • cancelled - typically means that the tests took longer than the drone CI allows them to run

TESTS=acceptance, TESTS-ACCEPTANCE=app-files-sharing

  • cancelled - typically means that the tests took longer than the drone CI allows them to run

@rullzer rullzer merged commit 3f559dd into stable15 Mar 18, 2019
@rullzer rullzer deleted the backport/13401/stable15 branch March 18, 2019 09:07
@rullzer rullzer mentioned this pull request Mar 29, 2019
Merged
1 task
@tflidd tflidd mentioned this pull request Jun 27, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzer rullzer rullzer approved these changes

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@blizzz blizzz Awaiting requested review from blizzz

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@schiessle schiessle Awaiting requested review from schiessle

Assignees

No one assigned

Labels

4. to release Ready to be released and/or waiting for tests to finish bug

Projects

None yet

Milestone

Nextcloud 15.0.6

Development

Successfully merging this pull request may close these issues.

5 participants

@MorrisJobke @rullzer @schiessle @kesselb