Temp disable bundle tests #14774
Merged
Temp disable bundle tests #14774
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The bundle acceptance tests fails after #14578 sometimes. This is because of a race condition. not all apps have compatible 16 versions yet. So trying to enable them results in those apps doing 💥. Because of #14578 we do show them now. So we try to enable them. However depending on which requests finishes first the disable button for the audit app either shows up or now. Signed-off-by: Roeland Jago Douma <[email protected]>
ChristophWurst
approved these changes
Mar 20, 2019
MorrisJobke
approved these changes
Mar 20, 2019
MorrisJobke
added
4. to release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bundle acceptance tests fails after #14578 sometimes. This is
because of a race condition. not all apps have compatible 16 versions
yet. So trying to enable them results in those apps doing 💥.
Because of #14578 we do show them now. So we try to enable them. However
depending on which requests finishes first the disable button for the
audit app either shows up or now.
I'll create a PR to revert this right away. So that we can have the tests back when we have releases for all the apps.