Skip to content

[stable15] Fix user creation using LDAP Plugin #14781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MorrisJobke merged 3 commits into from
Mar 21, 2019
Merged

[stable15] Fix user creation using LDAP Plugin #14781

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
20b0817
fix user creation using LDAP Plugin
viniciuscb Mar 1, 2019
7d6a7ab
Cache cleaning when subadmin adds user to group
viniciuscb Mar 4, 2019
79b7f12
LDAP plugin: force createUser to return new user's DN
viniciuscb Mar 14, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
LDAP plugin: force createUser to return new user's DN 
LDAP plugins must change the createUser method to return the DN, as we
need this to update the cache.

Signed-off-by: Vinicius Cubas Brand <[email protected]>
  • Loading branch information
@viniciuscb
viniciuscb authored and Backportbot committed Mar 21, 2019
commit 79b7f12a79013a48ac03d18e9f195f2a5e5309f4
3 changes: 2 additions & 1 deletion apps/user_ldap/lib/User_LDAP.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -615,6 +615,7 @@ public function getNewLDAPConnection($uid) {
* create new user
* @param string $username username of the new user
* @param string $password password of the new user
* @throws \UnexpectedValueException
* @return bool
*/
public function createUser($username, $password) {
Expand All @@ -624,7 +625,7 @@ public function createUser($username, $password) {
//updates user mapping
$this->access->dn2ocname($dn, $username, true);
} else {
throw new \Exception("LDAP Plugin: Method createUser changed to return the user DN instead of boolean.");
throw new \UnexpectedValueException("LDAP Plugin: Method createUser changed to return the user DN instead of boolean.");
}
}
return (bool) $dn;
Expand Down