Skip to content

Always pass old value to 'triggerChange' in User class #14788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
MorrisJobke wants to merge 3 commits into from
Closed

Always pass old value to 'triggerChange' in User class #14788

MorrisJobke wants to merge 3 commits into from

Conversation

@MorrisJobke
Copy link
Member

@MorrisJobke MorrisJobke commented Mar 21, 2019

Same version as #14566 but rebased on master to check the CI status.

@MorrisJobke MorrisJobke added the 3. to review Waiting for reviews label Mar 21, 2019
@MorrisJobke MorrisJobke added this to the Nextcloud 16 milestone Mar 21, 2019
Leon Klingele added 3 commits March 21, 2019 13:50
@MorrisJobke
lib/private/User,apps/user_ldap/lib/User: always pass old value to Us…
93089c9 
…er::triggerChange

Signed-off-by: Morris Jobke <[email protected]>
@MorrisJobke
lib/private/User: do not change user properties if value has not changed
a7b11c4 
Signed-off-by: Morris Jobke <[email protected]>
@MorrisJobke
lib/private/User: add reminder to first change 'enabled' property, th…
f75fc36 
…en issue event

A new event, 'preChangeUser', should be used for this instead.
See #14565.

Signed-off-by: Morris Jobke <[email protected]>
@MorrisJobke MorrisJobke force-pushed the lib-private-user-trigger-pass-old branch from 39e78aa to f75fc36 Compare March 21, 2019 12:50
@MorrisJobke MorrisJobke mentioned this pull request Mar 21, 2019
Closed
@faily-bot
Copy link

faily-bot bot commented Mar 21, 2019

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 17216: failure

ENABLE_REDIS=true, TESTS=db-codecov

Show full log 
There were 5 failures:

1) Test\User\UserTest::testSetEMailAddressNoChange
Expectation failed for method name is equal to "setUserValue" when invoked 1 time(s).
Method was expected to be called 1 times, actually called 0 times.

2) Test\User\UserTest::testSetQuotaAddressNoChange
Expectation failed for method name is equal to "setUserValue" when invoked 1 time(s).
Method was expected to be called 1 times, actually called 0 times.

3) OCA\Files_Sharing\Tests\CacheTest::testGetFolderContentsInRoot
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'User One'
+'test-share-user1'

/drone/src/github.com/nextcloud/server/apps/files_sharing/tests/CacheTest.php:472
/drone/src/github.com/nextcloud/server/apps/files_sharing/tests/CacheTest.php:456
/drone/src/github.com/nextcloud/server/apps/files_sharing/tests/CacheTest.php:359

4) OCA\Files_Sharing\Tests\CacheTest::testGetFolderContentsInSubdir
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'User One'
+'test-share-user1'

/drone/src/github.com/nextcloud/server/apps/files_sharing/tests/CacheTest.php:472
/drone/src/github.com/nextcloud/server/apps/files_sharing/tests/CacheTest.php:456
/drone/src/github.com/nextcloud/server/apps/files_sharing/tests/CacheTest.php:390

5) OCA\Files_Sharing\Tests\CacheTest::testGetFolderContentsWhenSubSubdirShared
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'User One'
+'test-share-user1'

/drone/src/github.com/nextcloud/server/apps/files_sharing/tests/CacheTest.php:472
/drone/src/github.com/nextcloud/server/apps/files_sharing/tests/CacheTest.php:456
/drone/src/github.com/nextcloud/server/apps/files_sharing/tests/CacheTest.php:436

--

There was 1 risky test:

1) OCA\TwoFactorBackupCodes\Tests\Db\BackupCodeMapperTest::testInsertArgonEncryptedCodes
This test did not perform any assertions

DB=sqlite, ENABLE_REDIS=true, PHP=7.1

Show full log 
There were 5 failures:

1) Test\User\UserTest::testSetEMailAddressNoChange
Expectation failed for method name is equal to "setUserValue" when invoked 1 time(s).
Method was expected to be called 1 times, actually called 0 times.

2) Test\User\UserTest::testSetQuotaAddressNoChange
Expectation failed for method name is equal to "setUserValue" when invoked 1 time(s).
Method was expected to be called 1 times, actually called 0 times.

3) OCA\Files_Sharing\Tests\CacheTest::testGetFolderContentsInRoot
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'User One'
+'test-share-user1'

/drone/src/github.com/nextcloud/server/apps/files_sharing/tests/CacheTest.php:472
/drone/src/github.com/nextcloud/server/apps/files_sharing/tests/CacheTest.php:456
/drone/src/github.com/nextcloud/server/apps/files_sharing/tests/CacheTest.php:359

4) OCA\Files_Sharing\Tests\CacheTest::testGetFolderContentsInSubdir
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'User One'
+'test-share-user1'

/drone/src/github.com/nextcloud/server/apps/files_sharing/tests/CacheTest.php:472
/drone/src/github.com/nextcloud/server/apps/files_sharing/tests/CacheTest.php:456
/drone/src/github.com/nextcloud/server/apps/files_sharing/tests/CacheTest.php:390

5) OCA\Files_Sharing\Tests\CacheTest::testGetFolderContentsWhenSubSubdirShared
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'User One'
+'test-share-user1'

/drone/src/github.com/nextcloud/server/apps/files_sharing/tests/CacheTest.php:472
/drone/src/github.com/nextcloud/server/apps/files_sharing/tests/CacheTest.php:456
/drone/src/github.com/nextcloud/server/apps/files_sharing/tests/CacheTest.php:436

--

There was 1 risky test:

1) OCA\TwoFactorBackupCodes\Tests\Db\BackupCodeMapperTest::testInsertArgonEncryptedCodes
This test did not perform any assertions

DB=sqlite, ENABLE_REDIS=false, PHP=7.2

Show full log 
There were 5 failures:

1) Test\User\UserTest::testSetEMailAddressNoChange
Expectation failed for method name is equal to "setUserValue" when invoked 1 time(s).
Method was expected to be called 1 times, actually called 0 times.

2) Test\User\UserTest::testSetQuotaAddressNoChange
Expectation failed for method name is equal to "setUserValue" when invoked 1 time(s).
Method was expected to be called 1 times, actually called 0 times.

3) OCA\Files_Sharing\Tests\CacheTest::testGetFolderContentsInRoot
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'User One'
+'test-share-user1'

/drone/src/github.com/nextcloud/server/apps/files_sharing/tests/CacheTest.php:472
/drone/src/github.com/nextcloud/server/apps/files_sharing/tests/CacheTest.php:456
/drone/src/github.com/nextcloud/server/apps/files_sharing/tests/CacheTest.php:359

4) OCA\Files_Sharing\Tests\CacheTest::testGetFolderContentsInSubdir
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'User One'
+'test-share-user1'

/drone/src/github.com/nextcloud/server/apps/files_sharing/tests/CacheTest.php:472
/drone/src/github.com/nextcloud/server/apps/files_sharing/tests/CacheTest.php:456
/drone/src/github.com/nextcloud/server/apps/files_sharing/tests/CacheTest.php:390

5) OCA\Files_Sharing\Tests\CacheTest::testGetFolderContentsWhenSubSubdirShared
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'User One'
+'test-share-user1'

/drone/src/github.com/nextcloud/server/apps/files_sharing/tests/CacheTest.php:472
/drone/src/github.com/nextcloud/server/apps/files_sharing/tests/CacheTest.php:456
/drone/src/github.com/nextcloud/server/apps/files_sharing/tests/CacheTest.php:436

--

There was 1 risky test:

1) OCA\TwoFactorBackupCodes\Tests\Db\BackupCodeMapperTest::testInsertArgonEncryptedCodes
This test did not perform any assertions

DB=sqlite, ENABLE_REDIS=false, PHP=7.3

Show full log 
There were 5 failures:

1) Test\User\UserTest::testSetEMailAddressNoChange
Expectation failed for method name is equal to "setUserValue" when invoked 1 time(s).
Method was expected to be called 1 times, actually called 0 times.

2) Test\User\UserTest::testSetQuotaAddressNoChange
Expectation failed for method name is equal to "setUserValue" when invoked 1 time(s).
Method was expected to be called 1 times, actually called 0 times.

3) OCA\Files_Sharing\Tests\CacheTest::testGetFolderContentsInRoot
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'User One'
+'test-share-user1'

/drone/src/github.com/nextcloud/server/apps/files_sharing/tests/CacheTest.php:472
/drone/src/github.com/nextcloud/server/apps/files_sharing/tests/CacheTest.php:456
/drone/src/github.com/nextcloud/server/apps/files_sharing/tests/CacheTest.php:340

4) OCA\Files_Sharing\Tests\CacheTest::testGetFolderContentsInSubdir
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'User One'
+'test-share-user1'

/drone/src/github.com/nextcloud/server/apps/files_sharing/tests/CacheTest.php:472
/drone/src/github.com/nextcloud/server/apps/files_sharing/tests/CacheTest.php:456
/drone/src/github.com/nextcloud/server/apps/files_sharing/tests/CacheTest.php:369

5) OCA\Files_Sharing\Tests\CacheTest::testGetFolderContentsWhenSubSubdirShared
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'User One'
+'test-share-user1'

/drone/src/github.com/nextcloud/server/apps/files_sharing/tests/CacheTest.php:472
/drone/src/github.com/nextcloud/server/apps/files_sharing/tests/CacheTest.php:456
/drone/src/github.com/nextcloud/server/apps/files_sharing/tests/CacheTest.php:415

--

There was 1 risky test:

1) OCA\TwoFactorBackupCodes\Tests\Db\BackupCodeMapperTest::testInsertArgonEncryptedCodes
This test did not perform any assertions

DB=mysql, ENABLE_REDIS=true, PHP=7.1

Show full log 
There were 5 failures:

1) Test\User\UserTest::testSetEMailAddressNoChange
Expectation failed for method name is equal to "setUserValue" when invoked 1 time(s).
Method was expected to be called 1 times, actually called 0 times.

2) Test\User\UserTest::testSetQuotaAddressNoChange
Expectation failed for method name is equal to "setUserValue" when invoked 1 time(s).
Method was expected to be called 1 times, actually called 0 times.

3) OCA\Files_Sharing\Tests\CacheTest::testGetFolderContentsInRoot
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'User One'
+'test-share-user1'

/drone/src/github.com/nextcloud/server/apps/files_sharing/tests/CacheTest.php:472
/drone/src/github.com/nextcloud/server/apps/files_sharing/tests/CacheTest.php:456
/drone/src/github.com/nextcloud/server/apps/files_sharing/tests/CacheTest.php:359

4) OCA\Files_Sharing\Tests\CacheTest::testGetFolderContentsInSubdir
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'User One'
+'test-share-user1'

/drone/src/github.com/nextcloud/server/apps/files_sharing/tests/CacheTest.php:472
/drone/src/github.com/nextcloud/server/apps/files_sharing/tests/CacheTest.php:456
/drone/src/github.com/nextcloud/server/apps/files_sharing/tests/CacheTest.php:390

5) OCA\Files_Sharing\Tests\CacheTest::testGetFolderContentsWhenSubSubdirShared
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'User One'
+'test-share-user1'

/drone/src/github.com/nextcloud/server/apps/files_sharing/tests/CacheTest.php:472
/drone/src/github.com/nextcloud/server/apps/files_sharing/tests/CacheTest.php:456
/drone/src/github.com/nextcloud/server/apps/files_sharing/tests/CacheTest.php:436

--

There was 1 risky test:

1) OCA\TwoFactorBackupCodes\Tests\Db\BackupCodeMapperTest::testInsertArgonEncryptedCodes
This test did not perform any assertions

DB=mysql, ENABLE_REDIS=false, PHP=7.2

Show full log 
There were 5 failures:

1) Test\User\UserTest::testSetEMailAddressNoChange
Expectation failed for method name is equal to "setUserValue" when invoked 1 time(s).
Method was expected to be called 1 times, actually called 0 times.

2) Test\User\UserTest::testSetQuotaAddressNoChange
Expectation failed for method name is equal to "setUserValue" when invoked 1 time(s).
Method was expected to be called 1 times, actually called 0 times.

3) OCA\Files_Sharing\Tests\CacheTest::testGetFolderContentsInRoot
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'User One'
+'test-share-user1'

/drone/src/github.com/nextcloud/server/apps/files_sharing/tests/CacheTest.php:472
/drone/src/github.com/nextcloud/server/apps/files_sharing/tests/CacheTest.php:456
/drone/src/github.com/nextcloud/server/apps/files_sharing/tests/CacheTest.php:359

4) OCA\Files_Sharing\Tests\CacheTest::testGetFolderContentsInSubdir
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'User One'
+'test-share-user1'

/drone/src/github.com/nextcloud/server/apps/files_sharing/tests/CacheTest.php:472
/drone/src/github.com/nextcloud/server/apps/files_sharing/tests/CacheTest.php:456
/drone/src/github.com/nextcloud/server/apps/files_sharing/tests/CacheTest.php:390

5) OCA\Files_Sharing\Tests\CacheTest::testGetFolderContentsWhenSubSubdirShared
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'User One'
+'test-share-user1'

/drone/src/github.com/nextcloud/server/apps/files_sharing/tests/CacheTest.php:472
/drone/src/github.com/nextcloud/server/apps/files_sharing/tests/CacheTest.php:456
/drone/src/github.com/nextcloud/server/apps/files_sharing/tests/CacheTest.php:436

--

There was 1 risky test:

1) OCA\TwoFactorBackupCodes\Tests\Db\BackupCodeMapperTest::testInsertArgonEncryptedCodes
This test did not perform any assertions

DB=mysql, ENABLE_REDIS=false, PHP=7.3

Show full log 
There were 5 failures:

1) Test\User\UserTest::testSetEMailAddressNoChange
Expectation failed for method name is equal to "setUserValue" when invoked 1 time(s).
Method was expected to be called 1 times, actually called 0 times.

2) Test\User\UserTest::testSetQuotaAddressNoChange
Expectation failed for method name is equal to "setUserValue" when invoked 1 time(s).
Method was expected to be called 1 times, actually called 0 times.

3) OCA\Files_Sharing\Tests\CacheTest::testGetFolderContentsInRoot
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'User One'
+'test-share-user1'

/drone/src/github.com/nextcloud/server/apps/files_sharing/tests/CacheTest.php:472
/drone/src/github.com/nextcloud/server/apps/files_sharing/tests/CacheTest.php:456
/drone/src/github.com/nextcloud/server/apps/files_sharing/tests/CacheTest.php:340

4) OCA\Files_Sharing\Tests\CacheTest::testGetFolderContentsInSubdir
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'User One'
+'test-share-user1'

/drone/src/github.com/nextcloud/server/apps/files_sharing/tests/CacheTest.php:472
/drone/src/github.com/nextcloud/server/apps/files_sharing/tests/CacheTest.php:456
/drone/src/github.com/nextcloud/server/apps/files_sharing/tests/CacheTest.php:369

5) OCA\Files_Sharing\Tests\CacheTest::testGetFolderContentsWhenSubSubdirShared
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'User One'
+'test-share-user1'

/drone/src/github.com/nextcloud/server/apps/files_sharing/tests/CacheTest.php:472
/drone/src/github.com/nextcloud/server/apps/files_sharing/tests/CacheTest.php:456
/drone/src/github.com/nextcloud/server/apps/files_sharing/tests/CacheTest.php:415

--

There was 1 risky test:

1) OCA\TwoFactorBackupCodes\Tests\Db\BackupCodeMapperTest::testInsertArgonEncryptedCodes
This test did not perform any assertions

DB=mysql5.6, ENABLE_REDIS=true, PHP=7.1

Show full log 
There were 5 failures:

1) Test\User\UserTest::testSetEMailAddressNoChange
Expectation failed for method name is equal to "setUserValue" when invoked 1 time(s).
Method was expected to be called 1 times, actually called 0 times.

2) Test\User\UserTest::testSetQuotaAddressNoChange
Expectation failed for method name is equal to "setUserValue" when invoked 1 time(s).
Method was expected to be called 1 times, actually called 0 times.

3) OCA\Files_Sharing\Tests\CacheTest::testGetFolderContentsInRoot
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'User One'
+'test-share-user1'

/drone/src/github.com/nextcloud/server/apps/files_sharing/tests/CacheTest.php:472
/drone/src/github.com/nextcloud/server/apps/files_sharing/tests/CacheTest.php:456
/drone/src/github.com/nextcloud/server/apps/files_sharing/tests/CacheTest.php:359

4) OCA\Files_Sharing\Tests\CacheTest::testGetFolderContentsInSubdir
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'User One'
+'test-share-user1'

/drone/src/github.com/nextcloud/server/apps/files_sharing/tests/CacheTest.php:472
/drone/src/github.com/nextcloud/server/apps/files_sharing/tests/CacheTest.php:456
/drone/src/github.com/nextcloud/server/apps/files_sharing/tests/CacheTest.php:390

5) OCA\Files_Sharing\Tests\CacheTest::testGetFolderContentsWhenSubSubdirShared
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'User One'
+'test-share-user1'

/drone/src/github.com/nextcloud/server/apps/files_sharing/tests/CacheTest.php:472
/drone/src/github.com/nextcloud/server/apps/files_sharing/tests/CacheTest.php:456
/drone/src/github.com/nextcloud/server/apps/files_sharing/tests/CacheTest.php:436

--

There was 1 risky test:

1) OCA\TwoFactorBackupCodes\Tests\Db\BackupCodeMapperTest::testInsertArgonEncryptedCodes
This test did not perform any assertions

DB=mysql5.5, ENABLE_REDIS=true, PHP=7.1

Show full log 
There were 5 failures:

1) Test\User\UserTest::testSetEMailAddressNoChange
Expectation failed for method name is equal to "setUserValue" when invoked 1 time(s).
Method was expected to be called 1 times, actually called 0 times.

2) Test\User\UserTest::testSetQuotaAddressNoChange
Expectation failed for method name is equal to "setUserValue" when invoked 1 time(s).
Method was expected to be called 1 times, actually called 0 times.

3) OCA\Files_Sharing\Tests\CacheTest::testGetFolderContentsInRoot
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'User One'
+'test-share-user1'

/drone/src/github.com/nextcloud/server/apps/files_sharing/tests/CacheTest.php:472
/drone/src/github.com/nextcloud/server/apps/files_sharing/tests/CacheTest.php:456
/drone/src/github.com/nextcloud/server/apps/files_sharing/tests/CacheTest.php:359

4) OCA\Files_Sharing\Tests\CacheTest::testGetFolderContentsInSubdir
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'User One'
+'test-share-user1'

/drone/src/github.com/nextcloud/server/apps/files_sharing/tests/CacheTest.php:472
/drone/src/github.com/nextcloud/server/apps/files_sharing/tests/CacheTest.php:456
/drone/src/github.com/nextcloud/server/apps/files_sharing/tests/CacheTest.php:390

5) OCA\Files_Sharing\Tests\CacheTest::testGetFolderContentsWhenSubSubdirShared
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'User One'
+'test-share-user1'

/drone/src/github.com/nextcloud/server/apps/files_sharing/tests/CacheTest.php:472
/drone/src/github.com/nextcloud/server/apps/files_sharing/tests/CacheTest.php:456
/drone/src/github.com/nextcloud/server/apps/files_sharing/tests/CacheTest.php:436

--

There was 1 risky test:

1) OCA\TwoFactorBackupCodes\Tests\Db\BackupCodeMapperTest::testInsertArgonEncryptedCodes
This test did not perform any assertions

DB=postgres, ENABLE_REDIS=true, PHP=7.1, POSTGRES=9

Show full log 
There were 5 failures:

1) Test\User\UserTest::testSetEMailAddressNoChange
Expectation failed for method name is equal to "setUserValue" when invoked 1 time(s).
Method was expected to be called 1 times, actually called 0 times.

2) Test\User\UserTest::testSetQuotaAddressNoChange
Expectation failed for method name is equal to "setUserValue" when invoked 1 time(s).
Method was expected to be called 1 times, actually called 0 times.

3) OCA\Files_Sharing\Tests\CacheTest::testGetFolderContentsInRoot
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'User One'
+'test-share-user1'

/drone/src/github.com/nextcloud/server/apps/files_sharing/tests/CacheTest.php:472
/drone/src/github.com/nextcloud/server/apps/files_sharing/tests/CacheTest.php:456
/drone/src/github.com/nextcloud/server/apps/files_sharing/tests/CacheTest.php:359

4) OCA\Files_Sharing\Tests\CacheTest::testGetFolderContentsInSubdir
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'User One'
+'test-share-user1'

/drone/src/github.com/nextcloud/server/apps/files_sharing/tests/CacheTest.php:472
/drone/src/github.com/nextcloud/server/apps/files_sharing/tests/CacheTest.php:456
/drone/src/github.com/nextcloud/server/apps/files_sharing/tests/CacheTest.php:390

5) OCA\Files_Sharing\Tests\CacheTest::testGetFolderContentsWhenSubSubdirShared
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'User One'
+'test-share-user1'

/drone/src/github.com/nextcloud/server/apps/files_sharing/tests/CacheTest.php:472
/drone/src/github.com/nextcloud/server/apps/files_sharing/tests/CacheTest.php:456
/drone/src/github.com/nextcloud/server/apps/files_sharing/tests/CacheTest.php:436

--

There was 1 risky test:

1) OCA\TwoFactorBackupCodes\Tests\Db\BackupCodeMapperTest::testInsertArgonEncryptedCodes
This test did not perform any assertions

DB=postgres, ENABLE_REDIS=true, PHP=7.1, POSTGRES=10

Show full log 
There were 5 failures:

1) Test\User\UserTest::testSetEMailAddressNoChange
Expectation failed for method name is equal to "setUserValue" when invoked 1 time(s).
Method was expected to be called 1 times, actually called 0 times.

2) Test\User\UserTest::testSetQuotaAddressNoChange
Expectation failed for method name is equal to "setUserValue" when invoked 1 time(s).
Method was expected to be called 1 times, actually called 0 times.

3) OCA\Files_Sharing\Tests\CacheTest::testGetFolderContentsInRoot
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'User One'
+'test-share-user1'

/drone/src/github.com/nextcloud/server/apps/files_sharing/tests/CacheTest.php:472
/drone/src/github.com/nextcloud/server/apps/files_sharing/tests/CacheTest.php:456
/drone/src/github.com/nextcloud/server/apps/files_sharing/tests/CacheTest.php:359

4) OCA\Files_Sharing\Tests\CacheTest::testGetFolderContentsInSubdir
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'User One'
+'test-share-user1'

/drone/src/github.com/nextcloud/server/apps/files_sharing/tests/CacheTest.php:472
/drone/src/github.com/nextcloud/server/apps/files_sharing/tests/CacheTest.php:456
/drone/src/github.com/nextcloud/server/apps/files_sharing/tests/CacheTest.php:390

5) OCA\Files_Sharing\Tests\CacheTest::testGetFolderContentsWhenSubSubdirShared
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'User One'
+'test-share-user1'

/drone/src/github.com/nextcloud/server/apps/files_sharing/tests/CacheTest.php:472
/drone/src/github.com/nextcloud/server/apps/files_sharing/tests/CacheTest.php:456
/drone/src/github.com/nextcloud/server/apps/files_sharing/tests/CacheTest.php:436

--

There was 1 risky test:

1) OCA\TwoFactorBackupCodes\Tests\Db\BackupCodeMapperTest::testInsertArgonEncryptedCodes
This test did not perform any assertions

DB=mysqlmb4, ENABLE_REDIS=true, PHP=7.1

Show full log 
There were 5 failures:

1) Test\User\UserTest::testSetEMailAddressNoChange
Expectation failed for method name is equal to "setUserValue" when invoked 1 time(s).
Method was expected to be called 1 times, actually called 0 times.

2) Test\User\UserTest::testSetQuotaAddressNoChange
Expectation failed for method name is equal to "setUserValue" when invoked 1 time(s).
Method was expected to be called 1 times, actually called 0 times.

3) OCA\Files_Sharing\Tests\CacheTest::testGetFolderContentsInRoot
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'User One'
+'test-share-user1'

/drone/src/github.com/nextcloud/server/apps/files_sharing/tests/CacheTest.php:472
/drone/src/github.com/nextcloud/server/apps/files_sharing/tests/CacheTest.php:456
/drone/src/github.com/nextcloud/server/apps/files_sharing/tests/CacheTest.php:359

4) OCA\Files_Sharing\Tests\CacheTest::testGetFolderContentsInSubdir
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'User One'
+'test-share-user1'

/drone/src/github.com/nextcloud/server/apps/files_sharing/tests/CacheTest.php:472
/drone/src/github.com/nextcloud/server/apps/files_sharing/tests/CacheTest.php:456
/drone/src/github.com/nextcloud/server/apps/files_sharing/tests/CacheTest.php:390

5) OCA\Files_Sharing\Tests\CacheTest::testGetFolderContentsWhenSubSubdirShared
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'User One'
+'test-share-user1'

/drone/src/github.com/nextcloud/server/apps/files_sharing/tests/CacheTest.php:472
/drone/src/github.com/nextcloud/server/apps/files_sharing/tests/CacheTest.php:456
/drone/src/github.com/nextcloud/server/apps/files_sharing/tests/CacheTest.php:436

--

There was 1 risky test:

1) OCA\TwoFactorBackupCodes\Tests\Db\BackupCodeMapperTest::testInsertArgonEncryptedCodes
This test did not perform any assertions

DB=mysqlmb4, ENABLE_REDIS=false, PHP=7.2

Show full log 
There were 5 failures:

1) Test\User\UserTest::testSetEMailAddressNoChange
Expectation failed for method name is equal to "setUserValue" when invoked 1 time(s).
Method was expected to be called 1 times, actually called 0 times.

2) Test\User\UserTest::testSetQuotaAddressNoChange
Expectation failed for method name is equal to "setUserValue" when invoked 1 time(s).
Method was expected to be called 1 times, actually called 0 times.

3) OCA\Files_Sharing\Tests\CacheTest::testGetFolderContentsInRoot
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'User One'
+'test-share-user1'

/drone/src/github.com/nextcloud/server/apps/files_sharing/tests/CacheTest.php:472
/drone/src/github.com/nextcloud/server/apps/files_sharing/tests/CacheTest.php:456
/drone/src/github.com/nextcloud/server/apps/files_sharing/tests/CacheTest.php:359

4) OCA\Files_Sharing\Tests\CacheTest::testGetFolderContentsInSubdir
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'User One'
+'test-share-user1'

/drone/src/github.com/nextcloud/server/apps/files_sharing/tests/CacheTest.php:472
/drone/src/github.com/nextcloud/server/apps/files_sharing/tests/CacheTest.php:456
/drone/src/github.com/nextcloud/server/apps/files_sharing/tests/CacheTest.php:390

5) OCA\Files_Sharing\Tests\CacheTest::testGetFolderContentsWhenSubSubdirShared
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'User One'
+'test-share-user1'

/drone/src/github.com/nextcloud/server/apps/files_sharing/tests/CacheTest.php:472
/drone/src/github.com/nextcloud/server/apps/files_sharing/tests/CacheTest.php:456
/drone/src/github.com/nextcloud/server/apps/files_sharing/tests/CacheTest.php:436

--

There was 1 risky test:

1) OCA\TwoFactorBackupCodes\Tests\Db\BackupCodeMapperTest::testInsertArgonEncryptedCodes
This test did not perform any assertions

DB=mysqlmb4, ENABLE_REDIS=false, PHP=7.3

Show full log 
There were 5 failures:

1) Test\User\UserTest::testSetEMailAddressNoChange
Expectation failed for method name is equal to "setUserValue" when invoked 1 time(s).
Method was expected to be called 1 times, actually called 0 times.

2) Test\User\UserTest::testSetQuotaAddressNoChange
Expectation failed for method name is equal to "setUserValue" when invoked 1 time(s).
Method was expected to be called 1 times, actually called 0 times.

3) OCA\Files_Sharing\Tests\CacheTest::testGetFolderContentsInRoot
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'User One'
+'test-share-user1'

/drone/src/github.com/nextcloud/server/apps/files_sharing/tests/CacheTest.php:472
/drone/src/github.com/nextcloud/server/apps/files_sharing/tests/CacheTest.php:456
/drone/src/github.com/nextcloud/server/apps/files_sharing/tests/CacheTest.php:340

4) OCA\Files_Sharing\Tests\CacheTest::testGetFolderContentsInSubdir
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'User One'
+'test-share-user1'

/drone/src/github.com/nextcloud/server/apps/files_sharing/tests/CacheTest.php:472
/drone/src/github.com/nextcloud/server/apps/files_sharing/tests/CacheTest.php:456
/drone/src/github.com/nextcloud/server/apps/files_sharing/tests/CacheTest.php:369

5) OCA\Files_Sharing\Tests\CacheTest::testGetFolderContentsWhenSubSubdirShared
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'User One'
+'test-share-user1'

/drone/src/github.com/nextcloud/server/apps/files_sharing/tests/CacheTest.php:472
/drone/src/github.com/nextcloud/server/apps/files_sharing/tests/CacheTest.php:456
/drone/src/github.com/nextcloud/server/apps/files_sharing/tests/CacheTest.php:415

--

There was 1 risky test:

1) OCA\TwoFactorBackupCodes\Tests\Db\BackupCodeMapperTest::testInsertArgonEncryptedCodes
This test did not perform any assertions

TESTS=carddavtester-old-endpoint

@MorrisJobke MorrisJobke deleted the lib-private-user-trigger-pass-old branch March 21, 2019 15:33
@MorrisJobke MorrisJobke removed this from the Nextcloud 16 milestone Mar 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blizzz blizzz Awaiting requested review from blizzz

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@rullzer rullzer Awaiting requested review from rullzer

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

Assignees

No one assigned

Labels

3. to review Waiting for reviews bug feature: users and groups

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MorrisJobke