Skip to content

Fix filepicker's add button design #14806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MorrisJobke merged 1 commit into from
Mar 25, 2019
Merged

Fix filepicker's add button design #14806

MorrisJobke merged 1 commit into from
Mar 25, 2019

Conversation

@skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Mar 22, 2019

@nextcloud/designers

Before After
Capture d’écran_2019-03-22_10-36-45 Capture d’écran_2019-03-22_10-36-36

@skjnldsv skjnldsv added bug design Design, UI, UX, etc. 3. to review Waiting for reviews feature: filepicker labels Mar 22, 2019
@skjnldsv skjnldsv added this to the Nextcloud 16 milestone Mar 22, 2019
@skjnldsv skjnldsv self-assigned this Mar 22, 2019
@ChristophWurst
Copy link
Member

ChristophWurst commented Mar 22, 2019 •
edited by skjnldsv
Loading

  • BUG the popover is slightly misplaced

Bildschirmfoto von 2019-03-22 10-41-24

@skjnldsv
Fix filepicker's add button design
3736bc8 
Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
@skjnldsv skjnldsv force-pushed the fix/files/picker-new-button branch from f95c70a to 3736bc8 Compare March 22, 2019 10:09
@MorrisJobke
Copy link
Member

MorrisJobke commented Mar 22, 2019

  • bug: clicking the "->" results in ReferenceError: Can't find variable: Files

Bildschirmfoto 2019-03-22 um 11 45 28

@MorrisJobke
Copy link
Member

MorrisJobke commented Mar 22, 2019

Why is there the add button at all? In 15 there was no such button. Couldn't it be removed?

@ChristophWurst
Copy link
Member

ChristophWurst commented Mar 22, 2019

Why is there the add button at all? In 15 there was no such button. Couldn't it be removed?

I was wondering as well. I guess we need it for copy and move. When you literally pick a file it doesn't make sense to have this button.

@skjnldsv
Copy link
Member Author

skjnldsv commented Mar 22, 2019

I have no idea X)

@MorrisJobke
Copy link
Member

MorrisJobke commented Mar 25, 2019

Could this PR hides the button, so that it works like before?

@skjnldsv

This comment has been minimized.

Sign in to view
@skjnldsv
Copy link
Member Author

skjnldsv commented Mar 25, 2019

Ah nope! This was a feature: #13177
Approved by Jan!

@ChristophWurst
Copy link
Member

ChristophWurst commented Mar 25, 2019

Approved by Jan!

🙈 🙊 🙉

@MorrisJobke
Copy link
Member

MorrisJobke commented Mar 25, 2019

#14806 (comment) <- this is still broken 😉 (on the personal settings page)

@ChristophWurst
Copy link
Member

ChristophWurst commented Mar 25, 2019

cc'ing the original author @rummatee for help

@MorrisJobke
Copy link
Member

MorrisJobke commented Mar 25, 2019

#14806 (comment) <- this is still broken 😉 (on the personal settings page)

Anyway - was broken before as well -> let's merge this first fix.

@MorrisJobke MorrisJobke merged commit 4a1cf54 into master Mar 25, 2019
@MorrisJobke MorrisJobke deleted the fix/files/picker-new-button branch March 25, 2019 12:56
@MorrisJobke
Copy link
Member

MorrisJobke commented Mar 25, 2019

Extracted issue to #14834

@rullzer rullzer mentioned this pull request Mar 26, 2019
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@rullzer rullzer Awaiting requested review from rullzer

@jancborchardt jancborchardt Awaiting requested review from jancborchardt

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

Assignees

@skjnldsv skjnldsv

Labels

3. to review Waiting for reviews bug design Design, UI, UX, etc. feature: filepicker

Projects

None yet

Milestone

Nextcloud 16

Development

Successfully merging this pull request may close these issues.

4 participants

@skjnldsv @ChristophWurst @MorrisJobke