2FA login notification subject to be shown in HTML e-mail #14844
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nhirokinet
force-pushed
the
feature/2fa-email-action-text
branch
3 times, most recently
from
a6a5c32 to
bf29d39
Compare
Signed-off-by: NARUKAWA Hiroki <[email protected]>
nhirokinet
force-pushed
the
feature/2fa-email-action-text
branch
from
bf29d39 to
d449e32
Compare
Member
|
That looks wrong. It should work without. I will have a look tomorrow. |
Member
|
More general patch is in nextcloud/activity#357 |
Contributor
Author
|
Thank you for your confirmation and fixation! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
2FA login message in activity notification e-mail, HTML format, had empty message. Since some e-mail clients like Thunderbird does not show remote images by default, this shows almost no messages. Message is shown if e-mail client is set to text only.
By this change, message will be shown like text style e-mail notification.
I'm not sure of coding style here, please comment about it, please comment about it and I will modify according to your comments.
Best regards,
nhirokinet