Always show full previews

[juliusknorr]

The default preview manager has been limited to show full size previews only for images. There is no obvious reason to do that since we can always request a big preview image for any filetype that can generate previews. The fallback for mime icons stays untouched

Before

After

portrait documents

wide documents (e.g. presentations)

fallback (unchanged)

[ChristophWurst]

Makes sense & code looks good

[faily-bot]

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 17334: failure

ENABLE_REDIS=true, TESTS=nodb-codecov

Show full log

There were 2 failures:

1) Test\L10N\FactoryTest::testGetL10nFilesForApp with data set #3 ('settings', 'de', array('/drone/src/github.com/nextclo...e.json'))
Failed asserting that Array &0 (
    0 => '/drone/src/github.com/nextcloud/server/core/l10n/de.json'
) is identical to Array &0 (
    0 => '/drone/src/github.com/nextcloud/server/settings/l10n/de.json'
).

/drone/src/github.com/nextcloud/server/tests/lib/L10N/FactoryTest.php:459

2) Test\L10N\FactoryTest::testFindL10NDir with data set #3 ('settings', '/drone/src/github.com/nextclo.../l10n/')
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-'/drone/src/github.com/nextcloud/server/settings/l10n/'
+'/drone/src/github.com/nextcloud/server/core/l10n/'

/drone/src/github.com/nextcloud/server/tests/lib/L10N/FactoryTest.php:481

DB=NODB, ENABLE_REDIS=true, PHP=7.1

Show full log

There were 2 failures:

1) Test\L10N\FactoryTest::testGetL10nFilesForApp with data set #3 ('settings', 'de', array('/drone/src/github.com/nextclo...e.json'))
Failed asserting that Array &0 (
    0 => '/drone/src/github.com/nextcloud/server/core/l10n/de.json'
) is identical to Array &0 (
    0 => '/drone/src/github.com/nextcloud/server/settings/l10n/de.json'
).

/drone/src/github.com/nextcloud/server/tests/lib/L10N/FactoryTest.php:459

2) Test\L10N\FactoryTest::testFindL10NDir with data set #3 ('settings', '/drone/src/github.com/nextclo.../l10n/')
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-'/drone/src/github.com/nextcloud/server/settings/l10n/'
+'/drone/src/github.com/nextcloud/server/core/l10n/'

/drone/src/github.com/nextcloud/server/tests/lib/L10N/FactoryTest.php:481

DB=NODB, ENABLE_REDIS=false, PHP=7.2

Show full log

There were 2 failures:

1) Test\L10N\FactoryTest::testGetL10nFilesForApp with data set #3 ('settings', 'de', array('/drone/src/github.com/nextclo...e.json'))
Failed asserting that Array &0 (
    0 => '/drone/src/github.com/nextcloud/server/core/l10n/de.json'
) is identical to Array &0 (
    0 => '/drone/src/github.com/nextcloud/server/settings/l10n/de.json'
).

/drone/src/github.com/nextcloud/server/tests/lib/L10N/FactoryTest.php:459

2) Test\L10N\FactoryTest::testFindL10NDir with data set #3 ('settings', '/drone/src/github.com/nextclo.../l10n/')
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-'/drone/src/github.com/nextcloud/server/settings/l10n/'
+'/drone/src/github.com/nextcloud/server/core/l10n/'

/drone/src/github.com/nextcloud/server/tests/lib/L10N/FactoryTest.php:481

DB=NODB, ENABLE_REDIS=false, PHP=7.3

Show full log

There were 2 failures:

1) Test\L10N\FactoryTest::testGetL10nFilesForApp with data set #3 ('settings', 'de', array('/drone/src/github.com/nextclo...e.json'))
Failed asserting that Array &0 (
    0 => '/drone/src/github.com/nextcloud/server/core/l10n/de.json'
) is identical to Array &0 (
    0 => '/drone/src/github.com/nextcloud/server/settings/l10n/de.json'
).

/drone/src/github.com/nextcloud/server/tests/lib/L10N/FactoryTest.php:459

2) Test\L10N\FactoryTest::testFindL10NDir with data set #3 ('settings', '/drone/src/github.com/nextclo.../l10n/')
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-'/drone/src/github.com/nextcloud/server/settings/l10n/'
+'/drone/src/github.com/nextcloud/server/core/l10n/'

/drone/src/github.com/nextcloud/server/tests/lib/L10N/FactoryTest.php:481

TESTS=ui-regression

• I'm a little sad 🤖 and was not able to find the logs for this failed job - please improve me at https://github.com/MorrisJobke/drone-logs to provide this to you