Skip to content

Show comments and restore in popover menu #14931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
skjnldsv merged 1 commit into from
Apr 2, 2019
Merged

Show comments and restore in popover menu #14931

skjnldsv merged 1 commit into from
Apr 2, 2019

Conversation

@skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Apr 2, 2019

0 1 2
Capture d’écran_2019-04-02_10-56-19 Capture d’écran_2019-04-02_11-31-25 Capture d’écran_2019-04-02_11-31-50

@skjnldsv
Show comments and restore in popover menu
b38445b 
Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
@skjnldsv skjnldsv added design Design, UI, UX, etc. 3. to review Waiting for reviews 16-feedback labels Apr 2, 2019
@skjnldsv skjnldsv added this to the Nextcloud 16 milestone Apr 2, 2019
@skjnldsv skjnldsv self-assigned this Apr 2, 2019
@jancborchardt jancborchardt mentioned this pull request Apr 2, 2019
Closed
62 tasks
@jancborchardt
Copy link
Member

jancborchardt commented Apr 2, 2019

Looks nice! Do we want to just say "1 comment" without the "new"? (Will probably be worse in other translations.)

@skjnldsv
Copy link
Member Author

skjnldsv commented Apr 2, 2019

Looks nice! Do we want to just say "1 comment" without the "new"? (Will probably be worse in other translations.)

I agree, but then it would not really be appropriate if you think about the real comments count? 🤔
1 comment would mean that there is only one comment, but it's only the unread ones 😉

MorrisJobke
MorrisJobke approved these changes Apr 2, 2019
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@skjnldsv
Copy link
Member Author

skjnldsv commented Apr 2, 2019

@jancborchardt so what do we do in the end?
Maybe we should not block the popovermenu size?

@jancborchardt
Copy link
Member

jancborchardt commented Apr 2, 2019

Hm, then let's just go for it like it is in the PR now. :)

jancborchardt
jancborchardt approved these changes Apr 2, 2019
View reviewed changes
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@skjnldsv skjnldsv merged commit f2e9bab into master Apr 2, 2019
@skjnldsv skjnldsv deleted the fix/files/grid-deleted-restore branch April 2, 2019 19:00
@MorrisJobke MorrisJobke mentioned this pull request Apr 3, 2019
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@jancborchardt jancborchardt jancborchardt approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@rullzer rullzer Awaiting requested review from rullzer

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

Assignees

@skjnldsv skjnldsv

Labels

3. to review Waiting for reviews design Design, UI, UX, etc.

Projects

None yet

Milestone

Nextcloud 16

Development

Successfully merging this pull request may close these issues.

5 participants

@skjnldsv @jancborchardt @MorrisJobke @ChristophWurst