Skip to content

Fix mobile menu on users management #14934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
skjnldsv merged 1 commit into from
Apr 2, 2019
Merged

Fix mobile menu on users management #14934

skjnldsv merged 1 commit into from
Apr 2, 2019

Conversation

@skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Apr 2, 2019 •
edited
Loading

Fix #14252

Capture d’écran_2019-04-02_15-10-25

@skjnldsv skjnldsv added this to the Nextcloud 16 milestone Apr 2, 2019
@skjnldsv skjnldsv self-assigned this Apr 2, 2019
@skjnldsv skjnldsv mentioned this pull request Apr 2, 2019
Closed
@MorrisJobke
Copy link
Member

MorrisJobke commented Apr 2, 2019

Doesn't work for me somehow 🤷‍♂️ It simply does not show up even after cleaned browser caches.

ChristophWurst
ChristophWurst approved these changes Apr 2, 2019
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me on FF

@MorrisJobke
Copy link
Member

MorrisJobke commented Apr 2, 2019

Not here (tested with FF and Safari - ignore the failing avatar - there the PHP build-in server crashes, but only for this request):

Bildschirmfoto 2019-04-02 um 16 22 53

rullzer
rullzer approved these changes Apr 2, 2019
View reviewed changes
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me as well.
Lets ignore @MorrisJobke

@rullzer
Copy link
Member

rullzer commented Apr 2, 2019

But conflicts!

@skjnldsv @rullzer
Fix mobile menu on users management
6bfd77d 
Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
@rullzer rullzer force-pushed the fix/settings/hamburger-menu branch from 63bf550 to 6bfd77d Compare April 2, 2019 17:43
@MorrisJobke MorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Apr 2, 2019
@skjnldsv skjnldsv merged commit 2a5742d into master Apr 2, 2019
@skjnldsv skjnldsv deleted the fix/settings/hamburger-menu branch April 2, 2019 18:47
@MorrisJobke MorrisJobke mentioned this pull request Apr 3, 2019
Merged
2 tasks
@Octopus2
Copy link

Octopus2 commented May 13, 2019

I am on 16 RC1 and this fix doesn´t work for me on my android device (Galaxy S7, Android 8, Chrome)....

@skjnldsv
Copy link
Member Author

skjnldsv commented May 13, 2019

@Octopus2 make sure to clear your cache :)

@Octopus2
Copy link

Octopus2 commented May 13, 2019 •
edited
Loading

@skjnldsv I cleaned the Chrome-Cache and it still doesn´t work.
Just tried it with Firefox on Windows 7 and same behavior when i resize the browserwindow. No menu/Burger on the left in user- and appmanagement....
Even tried this but nothing changes: #10436 (comment)

Anything else I can do to test?

@Octopus2
Copy link

Octopus2 commented May 14, 2019

sorry, correct is for my setup with this problem: 16.0.1 RC 1

@skjnldsv skjnldsv mentioned this pull request Jun 7, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzer rullzer rullzer approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@MorrisJobke MorrisJobke Awaiting requested review from MorrisJobke

@jancborchardt jancborchardt Awaiting requested review from jancborchardt

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

Assignees

@skjnldsv skjnldsv

Labels

4. to release Ready to be released and/or waiting for tests to finish bug regression

Projects

None yet

Milestone

Nextcloud 16

Development

Successfully merging this pull request may close these issues.

Missing hamburger menu in mobile mode

6 participants

@skjnldsv @MorrisJobke @rullzer @Octopus2 @ChristophWurst