Skip to content

Fix/settings/use components multiselect #14935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MorrisJobke merged 2 commits into from
Apr 2, 2019
Merged

Fix/settings/use components multiselect #14935

MorrisJobke merged 2 commits into from
Apr 2, 2019

Conversation

@skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Apr 2, 2019

Fix #14735
Capture d’écran_2019-04-02_15-26-43

skjnldsv added 2 commits April 2, 2019 15:24
@skjnldsv
Use components multiselect in apps management
1f8674c 
Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
@skjnldsv
Update build
2b9b641 
Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
@skjnldsv skjnldsv added this to the Nextcloud 16 milestone Apr 2, 2019
@skjnldsv skjnldsv self-assigned this Apr 2, 2019
@skjnldsv skjnldsv mentioned this pull request Apr 2, 2019
Closed
skjnldsv
skjnldsv commented Apr 2, 2019
View reviewed changes
skjnldsv
skjnldsv commented Apr 2, 2019
View reviewed changes
ChristophWurst
ChristophWurst approved these changes Apr 2, 2019
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense :+

MorrisJobke
MorrisJobke approved these changes Apr 2, 2019
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested and works 👍

@MorrisJobke MorrisJobke merged commit 854cb5d into master Apr 2, 2019
@MorrisJobke MorrisJobke deleted the fix/settings/use-components-multiselect branch April 2, 2019 17:35
@MorrisJobke
Copy link
Member

MorrisJobke commented Apr 2, 2019

/backport to stable15

@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented Apr 2, 2019

The backport to stable15 failed. Please do this backport manually.

@MorrisJobke MorrisJobke mentioned this pull request Apr 3, 2019
Merged
2 tasks
@MorrisJobke
Copy link
Member

MorrisJobke commented Apr 17, 2019

@skjnldsv Mind to open the backport?

@skjnldsv
Copy link
Member Author

skjnldsv commented Apr 17, 2019

I don't want to do it. This is not a security fix nor a design fix, this is a feature on the components. We should not backport :)

@MorrisJobke
Copy link
Member

MorrisJobke commented Apr 17, 2019

Okay :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@rullzer rullzer Awaiting requested review from rullzer

@jancborchardt jancborchardt Awaiting requested review from jancborchardt

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

Assignees

@skjnldsv skjnldsv

Labels

3. to review Waiting for reviews bug feature: apps management

Projects

None yet

Milestone

Nextcloud 16

Development

Successfully merging this pull request may close these issues.

Style change of app properties needed

4 participants

@skjnldsv @MorrisJobke @ChristophWurst