Skip to content

Notifications overhaul #15040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MorrisJobke merged 12 commits into from
Jul 17, 2019
Merged

Notifications overhaul #15040

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
9b288cd
Make all interfaces strict
nickvergessen Apr 10, 2019
9690b31
Change how Notifiers and Apps are registered
nickvergessen Apr 10, 2019
f376b9f
Fix creation of the Manager
nickvergessen Apr 12, 2019
a386ece
Update twofactor_backupcodes Notifier
nickvergessen Apr 12, 2019
44bc697
Update Federated sharing notifier
nickvergessen Apr 12, 2019
865c12a
Fix detection of Notifiers
nickvergessen Apr 30, 2019
64f6781
Fix new core notifier
nickvergessen Apr 30, 2019
6d71e47
Update shipped implementations of the INotifier
nickvergessen Apr 30, 2019
55f5bc7
Keep the old method as a fallback and adjust the tests
nickvergessen Jul 16, 2019
c3ef1cd
Update autoloader
nickvergessen Jul 16, 2019
565838d
Update unit tests
nickvergessen Jul 16, 2019
594efca
Update since to the correct version
nickvergessen Jul 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix detection of Notifiers 
Signed-off-by: Joas Schilling <[email protected]>
  • Loading branch information
@nickvergessen
nickvergessen committed Jul 15, 2019
commit 865c12aa0e624d21d15b351ee5fcbedffa55f11c
14 changes: 3 additions & 11 deletions lib/private/Notification/Manager.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,22 +43,14 @@ class Manager implements IManager {

/** @var IApp[] */
protected $apps;

/** @var INotifier[] */
protected $notifiers;

/** @var array[] */
protected $notifiersInfo;

/** @var string[] */
protected $appClasses;

/** @var INotifier[] */
protected $notifiers;
/** @var string[] */
protected $notifierClasses;

/** @var \Closure[] */
protected $notifiersInfoClosures;

/** @var bool */
protected $preparingPushNotification;

Expand Down Expand Up @@ -167,7 +159,7 @@ public function createNotification(): INotification {
* @since 8.2.0
*/
public function hasNotifiers(): bool {
return !empty($this->notifiersClosures);
return !empty($this->notifiers) || !empty($this->notifierClasses);
}

/**
Expand Down