Skip to content

Pass old value to user triggerChange hook & do not update unchanged attributes #15052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MorrisJobke merged 2 commits into from
Apr 11, 2019
Merged

Pass old value to user triggerChange hook & do not update unchanged attributes #15052

MorrisJobke merged 2 commits into from
Apr 11, 2019

Conversation

@MorrisJobke
Copy link
Member

@MorrisJobke MorrisJobke commented Apr 11, 2019 •
edited
Loading

Part of #14967 and #14566 that only passes the additional value for the old value of the attribute.

Also includes that some attributes should not be updated if their value hasn't changed.

@MorrisJobke MorrisJobke added the 3. to review Waiting for reviews label Apr 11, 2019
@MorrisJobke MorrisJobke added this to the Nextcloud 16 milestone Apr 11, 2019
This was referenced Apr 11, 2019
Merged
Closed
@rullzer rullzer mentioned this pull request Apr 11, 2019
Merged
13 tasks
@MorrisJobke
Copy link
Member Author

MorrisJobke commented Apr 11, 2019

Okay - this is already causing the issue. Let's shrink it down furthermore.

@MorrisJobke MorrisJobke force-pushed the fix/noid/pass-oldvalue branch from 878aea2 to 36618b1 Compare April 11, 2019 08:03
@MorrisJobke MorrisJobke changed the title Pass old value to user triggerChange hook Pass old value to user triggerChange hook & do not update unchanged attributes Apr 11, 2019
@MorrisJobke
Copy link
Member Author

MorrisJobke commented Apr 11, 2019

This is ready to be reviewed. It contains two commits:

  • one to only pass oldvalue to the change event
  • one that modifies the code to only change the attribute if the value actually has changed

ChristophWurst
ChristophWurst approved these changes Apr 11, 2019
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good and change makes sense 👍

rullzer
rullzer approved these changes Apr 11, 2019
View reviewed changes
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If CI is happy I'm fine with this

@MorrisJobke MorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Apr 11, 2019
@MorrisJobke MorrisJobke merged commit 757a841 into master Apr 11, 2019
@MorrisJobke MorrisJobke deleted the fix/noid/pass-oldvalue branch April 11, 2019 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzer rullzer rullzer approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@blizzz blizzz Awaiting requested review from blizzz

Assignees

No one assigned

Labels

4. to release Ready to be released and/or waiting for tests to finish

Projects

None yet

Milestone

Nextcloud 16

Development

Successfully merging this pull request may close these issues.

4 participants

@MorrisJobke @rullzer @ChristophWurst