Make sure we have a proper node before parsing #15110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
skjnldsv
requested review from
ChristophWurst,
MorrisJobke,
georgehrke and
rullzer
Member
Author
|
/backport to stable16 |
rullzer
approved these changes
Apr 15, 2019
|
backport to stable16 in #15111 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix viewer compatibility with ie11.
We have a fallback in jquery that do that when doing requests and make sure we return a xml node, but external apps can use other things as jQuery (and they should 😝) But then iedavclient is used for ie11 dav queries and breaking compatibility.
To test: launch ie, open an image in viewer. 🖼️