Check if the data is in the lookup server #15122
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joas Schilling <[email protected]>
Member
Author
|
/backport to stable16 |
Member
Author
|
/backport to stable15 |
Member
Author
|
/backport to stable14 |
Contributor
|
Is it correct to return false in this case? Is it possible that the information is available if you retry later? |
Member
This is exactly what the method should return as per doc block. it can't check the verification right now ;) |
Member
Author
|
Reviews please |
ChristophWurst
approved these changes
Apr 29, 2019
MorrisJobke
approved these changes
May 2, 2019
|
backport to stable16 in #15341 |
|
backport to stable15 in #15342 |
|
backport to stable14 in #15343 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related log entry:
Undefined index: email at /var/www/settings/BackgroundJobs/VerifyUserData.php#213