Fix setupcheck for intl module #15188
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A polyfill for intl is loaded very early (somewhere in base). Polyfill defines grapheme_strlen as function if intl extension is not loaded. The check here is always true because there is a function with that name. Signed-off-by: Daniel Kesselberg <[email protected]>
rullzer
approved these changes
Apr 24, 2019
ChristophWurst
approved these changes
Apr 24, 2019
ChristophWurst
added
4. to release
Member
|
/backport to stable16 |
|
backport to stable16 in #15223 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A polyfill for intl is loaded very early (somewhere in base). Polyfill defines grapheme_strlen as function if
intl extension is not loaded. The check here is always true
because there is a function with that name.
server/lib/base.php
Line 630 in 4982948
https://github.com/nextcloud/3rdparty/blob/9e49623fa57786c0874529e66c2ebd0ff2dc5075/patchwork/utf8/src/Patchwork/Utf8/Bootup/intl.php#L26 (here is the function defined)