Skip to content

Remove the custom prefix from the table name length when checking on … #15289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MorrisJobke merged 1 commit into from
Apr 30, 2019
Merged

Remove the custom prefix from the table name length when checking on … #15289

MorrisJobke merged 1 commit into from
Apr 30, 2019

Conversation

@nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Apr 29, 2019

…the default primary index

Fix #15229

@nickvergessen nickvergessen added this to the Nextcloud 17 milestone Apr 29, 2019
@nickvergessen
Copy link
Member Author

nickvergessen commented Apr 29, 2019

/backport to stable16

@skjnldsv
Copy link
Member

skjnldsv commented Apr 30, 2019

Well, we should probably also check and/or enforce innodb_large_prefix as well as mariadb > 12.2.
Just upgrading mariadb fixed everything for me.

skjnldsv
skjnldsv approved these changes Apr 30, 2019
View reviewed changes
Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But otherwise, fine forme

@nickvergessen
Copy link
Member Author

nickvergessen commented Apr 30, 2019

Well, we should probably also check and/or enforce innodb_large_prefix as well as mariadb > 12.2.

That is completely unrelated. But feel free to create a new issue, explain what the problem is and assign it to me.

@skjnldsv
Copy link
Member

skjnldsv commented Apr 30, 2019

That is completely unrelated. But feel free to create a new issue, explain what the problem is and assign it to me.

Ah sorry, I thought it was related to the Syntax error or access violation: 1071 Specified key was too long; max key length is 767 bytes

blizzz
blizzz reviewed Apr 30, 2019
View reviewed changes
@nickvergessen
Remove the custom prefix from the table name length when checking on …
b3e6cbc 
…the default primary index

Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen nickvergessen force-pushed the bugfix/15229/fix-non-default-prefixes branch from 01cf3b3 to b3e6cbc Compare April 30, 2019 10:09
blizzz
blizzz approved these changes Apr 30, 2019
View reviewed changes
Copy link
Member

@blizzz blizzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense

@MorrisJobke MorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Apr 30, 2019
@MorrisJobke MorrisJobke merged commit 4907b4e into master Apr 30, 2019
@MorrisJobke MorrisJobke deleted the bugfix/15229/fix-non-default-prefixes branch April 30, 2019 12:18
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Apr 30, 2019
Merged
@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented Apr 30, 2019

backport to stable16 in #15312

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blizzz blizzz blizzz approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@rullzer rullzer Awaiting requested review from rullzer

@MorrisJobke MorrisJobke Awaiting requested review from MorrisJobke

Assignees

No one assigned

Labels

4. to release Ready to be released and/or waiting for tests to finish bug feature: install and update

Projects

None yet

Milestone

Nextcloud 17

Development

Successfully merging this pull request may close these issues.

Update to 16.0 - InvalidArgumentException: Primary index name on "xxxxxx_collres_collections" is too long.

5 participants

@nickvergessen @skjnldsv @blizzz @MorrisJobke