Skip to content

take return of mkdir into consideration; photocache to not create a folder for deletion #15290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
skjnldsv merged 2 commits into from
Apr 30, 2019
Merged

take return of mkdir into consideration; photocache to not create a folder for deletion #15290

skjnldsv merged 2 commits into from
Apr 30, 2019

Conversation

@blizzz
Copy link
Member

@blizzz blizzz commented Apr 29, 2019 •
edited
Loading

Resolves #8635

I am not deep into the Node/filessystem things… i hope the additional exception does not kill stuff. What is still unknown is why the folder could not have been created in the first place, because mkdir on the local storage was silenced previously. update and still is as it causes tests to fail :-/ /update

@blizzz blizzz added this to the Nextcloud 17 milestone Apr 29, 2019
@blizzz blizzz changed the title Fix/8635/mdkir handling+no create to delete take return of mkdir into consideration; photocache to not create a folder for deletion Apr 29, 2019
@blizzz blizzz mentioned this pull request Apr 29, 2019
Closed
@blizzz blizzz force-pushed the fix/8635/mdkir-handling+no-create-to-delete branch from a87b9ed to 3c78116 Compare April 29, 2019 14:47
@blizzz
Copy link
Member Author

blizzz commented Apr 29, 2019

/backport to stable16

@blizzz
Copy link
Member Author

blizzz commented Apr 29, 2019

/backport to stable15

ChristophWurst
ChristophWurst approved these changes Apr 30, 2019
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code makes sense 👍

skjnldsv
skjnldsv approved these changes Apr 30, 2019
View reviewed changes
Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code make sense

@skjnldsv skjnldsv merged commit e727e01 into master Apr 30, 2019
@skjnldsv skjnldsv deleted the fix/8635/mdkir-handling+no-create-to-delete branch April 30, 2019 07:25
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Apr 30, 2019
Merged
@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented Apr 30, 2019

backport to stable16 in #15303

@MorrisJobke
Copy link
Member

MorrisJobke commented Apr 30, 2019

/backport to stable15

@blizzz blizzz mentioned this pull request Apr 30, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@rullzer rullzer Awaiting requested review from rullzer

@MorrisJobke MorrisJobke Awaiting requested review from MorrisJobke

@icewind1991 icewind1991 Awaiting requested review from icewind1991

Assignees

No one assigned

Labels

3. to review Waiting for reviews bug feature: dav feature: filesystem

Projects

None yet

Milestone

Nextcloud 17

Development

Successfully merging this pull request may close these issues.

OCP\Files\NotFoundException related to user's avatar

5 participants

@blizzz @MorrisJobke @ChristophWurst @skjnldsv