Move oc_appconfig/OC.appConfig to the main bundle #15354
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Christoph Wurst <[email protected]>
ChristophWurst
force-pushed
the
refactor/oc-appconfig-bundle
branch
from
6bb116f to
42be4b7
Compare
Member
Author
|
CI fails with MySQL has gone away -> unrelated |
skjnldsv
approved these changes
May 6, 2019
skjnldsv
added
4. to release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves that global variable to the bundle. Deprecation is not possible right now. See details below.
Details
The `oc_appconfig` var can't be deprecated though, as dirty hacks like https://github.com/nextcloud/server/blob/3d42d4c9dc75f0bddda5140835ff0a232768d529/apps/sharebymail/lib/Settings.php#L37-L52 hook into the config array and write `oc_appconfig`. For the deprecation property getter we'd can't have an existing `window.oc_appconfig` property though.How public is that config hook? What if I just renamed all
oc_appconfigoccurences to_oc_appconfigin this repo. @MorrisJobke could you maybe check with your local apps if the\OCP\Config::jshook is used anywhere outside server?If possible I will make
window.oc_appconfiga deprecated prop in a follow-up PR.