Fix collapse button in app navigation in IE11 #15384
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Although the collapse button has an absolute position Internet Explorer 11 needs the left position of that button to be explicitly set to 0 (other browsers do it implicitly due to the absolute position); otherwise the button appears to the right of the link (and behind the app content). Signed-off-by: Daniel Calviño Sánchez <[email protected]>
skjnldsv
approved these changes
May 6, 2019
Member
|
/backport to stable16 |
Member
|
/backport to stable15 |
Member
|
/backport to stable14 |
MorrisJobke
approved these changes
May 6, 2019
Member
MorrisJobke
left a comment
MorrisJobke
left a comment
There was a problem hiding this comment.
Tested, verified and works 👍
|
backport to stable16 in #15389 |
|
backport to stable15 in #15390 |
|
backport to stable14 in #15391 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #10230
Fixes #11840 (note that the JavaScript error mentioned in the bug is not related even if it seems so ;-) ).
This has been broken since Nextcloud 14, but... how far back this deserves to be backported?
How to test
-Open the Files app in Internet Explorer 11
-Create a new folder
-Add that folder to favorites
-Click twice on the button to the left of Favorites in the app navigation
-Click twice on the button to the left of Shares in the app navigation
Result with this pull request
The favorites and shares sections in the app navigation are expanded and collapsed.
Result without this pull request
The favorites and shares sections in the app navigation are not modified (but they are loaded in the file list).