Move the initCore function to the bundle #15440
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristophWurst
changed the title
ChristophWurst
force-pushed
the
refactor/js-init-core-bundle
branch
2 times, most recently
from
a41397c to
2c58f24
Compare
ChristophWurst
added
3. to review
This comment has been minimized.
This comment has been minimized.
ChristophWurst
force-pushed
the
refactor/js-init-core-bundle
branch
from
fc2577d to
33f1718
Compare
Signed-off-by: Christoph Wurst <[email protected]>
ChristophWurst
force-pushed
the
refactor/js-init-core-bundle
branch
from
33f1718 to
51d49c3
Compare
ChristophWurst
requested review from
blizzz,
georgehrke,
juliusknorr,
rullzer and
skjnldsv
Member
Author
|
Time to review 🚀 |
This was referenced May 10, 2019
georgehrke
approved these changes
May 10, 2019
Member
georgehrke
left a comment
georgehrke
left a comment
There was a problem hiding this comment.
✅ contacts menu works
✅ User menu works
✅ Snap.js works
✅ Session heartbeat works
✅ Resize App menu works
✅ ...
Anything else that's important in this context?
Member
Author
I think you have covered the important ones 👍 Some of the code is hard to understand. I think some is even dead or unused. |
rullzer
approved these changes
May 10, 2019
Member
rullzer
left a comment
rullzer
left a comment
There was a problem hiding this comment.
Coke make sense. And a smoke test with me clicking around like a maniac didn't have anything blow up. Lets do this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a big one. It's moving the dreaded
initCoreinto a module of its own, plus splitting it a bit into a few submodules where easily possible and switching code constructs to newer syntax.I'm pretty sure jsunit won't like it, but let's see what Drone reports.
Ref https://github.com/orgs/nextcloud/projects/31#card-21177484.
Todo
initCoreglobally again, but deprecate it as well