fixes possible override of uniqueMember by autodetection #15604
Merged
+17
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* uniqueMember was the default so we did not know whether this setting is desired or the initial value * autodetection of the user-group association attribute runs only when it was not set (as far as we knew) * the default is now empty * thus LDAPProvider might return this value as well (in exceptional cases) * if a group base is given (edge case), use this instead of general base * resolves #12682 Signed-off-by: Arthur Schiwon <[email protected]>
blizzz
added
bug
3. to review
blizzz
added
2. developing
MorrisJobke
approved these changes
May 21, 2019
Member
MorrisJobke
left a comment
MorrisJobke
left a comment
There was a problem hiding this comment.
Code change makes sense 👍
rullzer
approved these changes
May 21, 2019
Member
rullzer
left a comment
rullzer
left a comment
There was a problem hiding this comment.
I could not test. But it makes some sense to me with my limited LDAP knowledge
Signed-off-by: Arthur Schiwon <[email protected]>
blizzz
added
4. to release
Member
Author
|
Still unsure about the backports. It's not the proper way. |
Member
Author
|
Let's leave it for 17. I'll just respond it's fixed but not backportable since default values change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
desired or the initial value
was not set (as far as we knew)
It changes behaviour a bit:
uniqueMemberis not so common, and neither is not hitting "count groups". Imho, only impact for auto-installations were the attribute is not set specifically.I would say it is still OK to backport… more to the rules is to keep for 17 only though. The impact is small and rather beneficial.
What's left