Also allow dragging below the file list #15747
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julius Härtl <[email protected]>
juliusknorr
requested review from
ChristophWurst,
MorrisJobke,
danxuliu and
skjnldsv
Member
Author
|
/backport to stable16 |
Member
Author
|
/backport to stable15 |
Member
Author
|
/backport to stable14 |
MorrisJobke
added
4. to release
|
backport to stable16 in #15754 |
|
backport to stable15 in #15755 |
|
backport to stable14 in #15756 |
|
@juliushaertl are you able to upload files via drag and drop into the browser with NC16.0.2 now? I'm just asking because it stopped working for me after the update and I'm only guessing, that this might have to do with this fix. The only error message I see is from NC in the browser: In English: "You have no permission to upload or create files here." So no matter if I drag the file into the upper or lower area, the upload fails. The only way the upload works right now is via the + button. I'm using: |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes file upload by dragging files to the browser when there is empty space below the file list. The file list is not stretched to 100% height, as possible search results need to be displayed right below the list. Therefore we should not cancel the drop action if the dropTarget is the main
#app-contentcontainer.To reproduce, drag a file below the
#app-content-filescontainer: