Hide newFile menu if quota is set to 0B #15767
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julius Härtl <[email protected]>
juliusknorr
requested review from
ChristophWurst,
MorrisJobke,
danxuliu and
skjnldsv
Member
|
Isn't the text misleading? Not enough quote is not the same as no permissions. You could still have permission to create, but the quote doesn't allow it. |
Member
Author
Yes, but on the other hand the 0B quota workaround is always used to block users from uploading files to their home, so the permission-wording made sense from my perspective. I tried to keep the changes as minimal as possible so we can backport this easier. |
Member
Author
|
/backport to stable16 |
Member
Author
|
/backport to stable15 |
|
backport to stable15 in #15855 |
Member
Author
|
/backport to stable16 |
|
backport to stable16 in #15856 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hide the add new file button if 0B quota is configured for a user.
The button will be shown again, once the user enters a folder that has a different quota on the mount, e.g. inside of shared folders with write permissions.