search files by id in shared storages last #15776
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kesselb
reviewed
May 28, 2019
lib/private/Files/View.php
Outdated
|
|
||
| // put non shared mounts in front of the shared mount | ||
| // this prevent unneeded recursion into shares | ||
| $sharedMount = array_filter($mounts, function(IMountPoint $mountPoint) { |
Contributor
There was a problem hiding this comment.
Why don't u use a custom sort function here? Is this faster? 🤔
this prevents unneeded recursion when the file is not in the share Signed-off-by: Robin Appelman <[email protected]>
icewind1991
force-pushed
the
get-by-id-shares-last
branch
from
728bd9d to
98dd526
Compare
Member
Author
|
/backport to stable16 |
Member
Author
|
/backport to stable15 |
rullzer
approved these changes
May 29, 2019
Member
|
this seems to fix also possible ServiceUnavailale exceptions when unsharing (in some conditions i could not reproduce though) |
blizzz
approved these changes
May 29, 2019
blizzz
added
4. to release
|
backport to stable16 in #15799 |
|
backport to stable15 in #15800 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this prevents unneeded recursion when the file is not in the share
Signed-off-by: Robin Appelman [email protected]